From: Greygjhart <gre...@la...> - 2012-03-16 12:56:27
Attachments:
0001_coherent_naming_scheme_for_backdrops.patch
|
Hello there, I had a very hard time trying to figure out what I was expected to write to get a RPC command to actually set my wallpaper in a given mode. Of course my first instinct was to look at the config file to find a hint, as I could perfectly set it with rox' utility. I was very surprised to find that what was called Centred in one was Centre in the other one, and that's the same for others, though there doesn't seem to be any generality here. As I still could manage to get the 'Fit' mode to work (even after having commited atrocities like 'Fitted' or such), I proceeded to read the source code. This is when I was flabbergasted to discover that Fit mode wasn't even possible to set with a RPC command because its line had obviously been forgotten. I promised I searched a long time on the forum but I couldn't find any topic mentioning that. Plus, it's not really a feature request or a bug report, it's just a tiny mistake that takes no time to correct so I really think it would've been corrected at once. So here is the patch I propose to solve this issue and use the same names everywhere (in the config and in the RPC commands). Thanks a lot everybody and keep up the good work ! I've never found anything quite like Rox among other file managers. Greygjhart |
From: Stephen W. <st...@ke...> - 2012-03-17 16:10:24
|
Greygjhart <gre...@la...> wrote: > Hello there, > > I had a very hard time trying to figure out what I was expected to write > to get a RPC command to actually set my wallpaper in a given mode. Of > course my first instinct was to look at the config file to find a hint, > as I could perfectly set it with rox' utility. > > I was very surprised to find that what was called Centred in one was > Centre in the other one, and that's the same for others, though there > doesn't seem to be any generality here. As I still could manage to get > the 'Fit' mode to work (even after having commited atrocities like > 'Fitted' or such), I proceeded to read the source code. > > This is when I was flabbergasted to discover that Fit mode wasn't even > possible to set with a RPC command because its line had obviously been > forgotten. > > I promised I searched a long time on the forum but I couldn't find any > topic mentioning that. Plus, it's not really a feature request or a bug > report, it's just a tiny mistake that takes no time to correct so I > really think it would've been corrected at once. > > So here is the patch I propose to solve this issue and use the same > names everywhere (in the config and in the RPC commands). Changing the names used in the config isn't really viable as it would invalidate existing configuration files. The missing Fit in RPC is a genuine bug, as is the lack of a mention of Stretch in the manual. -- Stephen Watson http://www.kerofin.demon.co.uk/ If you read this on a mailing list, send any reply back to the list and not to me. Not even CC. "Daleks have no concept of elegance!" "That is obvious." |
From: Thomas L. <ta...@gm...> - 2012-03-18 21:41:33
|
On 17 March 2012 16:10, Stephen Watson <st...@ke...> wrote: > Greygjhart <gre...@la...> wrote: > >> Hello there, >> >> I had a very hard time trying to figure out what I was expected to write >> to get a RPC command to actually set my wallpaper in a given mode. Of >> course my first instinct was to look at the config file to find a hint, >> as I could perfectly set it with rox' utility. >> >> I was very surprised to find that what was called Centred in one was >> Centre in the other one, and that's the same for others, though there >> doesn't seem to be any generality here. As I still could manage to get >> the 'Fit' mode to work (even after having commited atrocities like >> 'Fitted' or such), I proceeded to read the source code. >> >> This is when I was flabbergasted to discover that Fit mode wasn't even >> possible to set with a RPC command because its line had obviously been >> forgotten. >> >> I promised I searched a long time on the forum but I couldn't find any >> topic mentioning that. Plus, it's not really a feature request or a bug >> report, it's just a tiny mistake that takes no time to correct so I >> really think it would've been corrected at once. >> >> So here is the patch I propose to solve this issue and use the same >> names everywhere (in the config and in the RPC commands). > > Changing the names used in the config isn't really viable as it would > invalidate existing configuration files. The missing Fit in RPC is a > genuine bug, as is the lack of a mention of Stretch in the manual. I've applied the Fit RPC part of the patch. Thanks! -- Dr Thomas Leonard http://0install.net/ GPG: 9242 9807 C985 3C07 44A6 8B9A AE07 8280 59A5 3CC1 GPG: DA98 25AE CAD0 8975 7CDA BD8E 0713 3F96 CA74 D8BA |
From: Greygjhart <gre...@la...> - 2012-03-19 10:07:44
|
Hi there, > > Changing the names used in the config isn't really viable as it would > invalidate existing configuration files. The missing Fit in RPC is a > genuine bug, as is the lack of a mention of Stretch in the manual. > > -- > Stephen Watson http://www.kerofin.demon.co.uk/ > If you read this on a mailing list, send any reply back to the list and not > to me. Not even CC. > "Daleks have no concept of elegance!" "That is obvious." > Yes I'm not very familiar yet with the development process of a 'real' software like rox so I totally missed out backward compatibility problems. I guess that's fine as long as the manual documents properly documents which name to use for each property in which place. > > I've applied the Fit RPC part of the patch. > > Thanks! > > > -- > Dr Thomas Leonard http://0install.net/ > GPG: 9242 9807 C985 3C07 44A6 8B9A AE07 8280 59A5 3CC1 > GPG: DA98 25AE CAD0 8975 7CDA BD8E 0713 3F96 CA74 D8BA > Cool ! Good to see that my mail wasn't completely useless : ) Greygjhart |