From: Thomas L. <ta...@ec...> - 2001-09-20 13:41:15
|
On Mon, Sep 17, 2001 at 08:51:49AM +0200, Mohari Andras wrote: > Hello, > > I have seen a message about coloured filenames on rox-devel and I > thought I would give it a try. Here is a patch to allow colouring > based on the file types (base type, not MIME-type). Even executables, > appdirs, unknown types and errors (TYPE_ERROR) are handled, but > symlinks are coloured according to their targets (I think the target > is more important than the symlink itself---the icons identify > symlinks anyway). Colouring is disabled by default. This is a really good patch - it's in :-) I've changed the default colour for appdirs to the same as executables as it's more distinctive (and spotting 'fake' directories is important). It might be worth-while adding an option for the background colour here too... The only issue I see is that the colours are always allocated, even if colouring is off. This might cause problems for people with very old displays? Thanks! -- Thomas Leonard http://rox.sourceforge.net ta...@ec... ta...@us... |
From: Mohari A. <ma...@ma...> - 2001-09-26 07:42:04
|
Thomas Leonard wrote: > > > It might be worth-while adding an option for the background colour here > > > too... > > > > In this case there should be a way to put the colour boxes and labels into > > a table or something, as there's no way to align the widgets in the options > > box now, AFAIK. <colour lpos=X ... > is an ugly hack. :) > Well, I already added that to make the list shorter ;-) Yes, I know _now_. I did not notice it at the time of the writing. X-) > I meant just one colour for the window background, rather than for > individual items... Oops, I misunderstood it, sorry. %-) -- Best regards, Andras Mohari |
From: Vincent L. <vi...@vi...> - 2001-09-20 14:32:18
|
On Thu, Sep 20, 2001 at 14:38:53 +0100, Thomas Leonard wrote: > I've changed the default colour for appdirs to the same as executables as > it's more distinctive (and spotting 'fake' directories is important). > > It might be worth-while adding an option for the background colour here > too... Yes, like with ls from the GNU fileutils. I haven't look at the new feature, but if the environment variable LS_COLORS already exists, could it be used in some way? -- Vincent Lefèvre <vi...@vi...> - Web: <http://www.vinc17.org/> - 100% validated HTML - Acorn Risc PC, Yellow Pig 17, Championnat International des Jeux Mathématiques et Logiques, TETRHEX, etc. Work: CR INRIA - computer arithmetic / SPACES project at LORIA |
From: Stephen W. <wa...@ul...> - 2001-09-21 09:38:36
|
In message <200...@ev...> Thomas Leonard <ta...@ec...> scribbled: > On Mon, Sep 17, 2001 at 08:51:49AM +0200, Mohari Andras wrote: > > Hello, > > > > I have seen a message about coloured filenames on rox-devel and I > > thought I would give it a try. Here is a patch to allow colouring > > based on the file types (base type, not MIME-type). > > This is a really good patch - it's in :-) A typo crept into display.c in todays CVS snapshot. Line 856 the *? should be */. -- Stephen Watson Physicist Ultra Electronics Ltd - Signature Management Systems (UESMS) Tel: +44 (0)1543 878888 (switchboard) Fax: +44 (0)1543 878249 Email: wa...@ul... |
From: Stephen W. <wa...@ul...> - 2001-09-24 08:43:42
|
In message <200...@ev...> Thomas Leonard <ta...@ec...> scribbled: > This is a really good patch - it's in :-) I was getting the wrong colours on Solaris 8 (Gtk 1.2.10) until I changed gtk_widget_get_default_colormap() to gdk_rgb_get_cmap() in alloc_type_colours(). A quick perusal of the GTK+ code seems to show that gtk_widget_get_default_colormap() returns the colourmap set by gtk_widget_set_default_colormap(), which does not appear to be the same as that set by gtk_widget_push_colormap(). -- Stephen Watson Physicist Ultra Electronics Ltd - Signature Management Systems (UESMS) Tel: +44 (0)1543 878888 (switchboard) Fax: +44 (0)1543 878249 Email: wa...@ul... |
From: Thomas L. <ta...@ec...> - 2001-09-24 12:23:30
|
On Fri, Sep 21, 2001 at 01:09:32PM +0200, Mohari Andras wrote: > On Thu, Sep 20, 2001 at 02:38:53PM +0100, Thomas Leonard wrote: > > This is a really good patch - it's in :-) > > Thanks! > > > It might be worth-while adding an option for the background colour here > > too... > > In this case there should be a way to put the colour boxes and labels into > a table or something, as there's no way to align the widgets in the options > box now, AFAIK. <colour lpos=X ... > is an ugly hack. :) Well, I already added that to make the list shorter ;-) I meant just one colour for the window background, rather than for individual items... -- Thomas Leonard http://rox.sourceforge.net ta...@ec... ta...@us... |
From: Thomas L. <ta...@ec...> - 2001-09-24 16:53:33
|
On Mon, Sep 24, 2001 at 08:30:17AM +0200, Mohari Andras wrote: > On Thu, Sep 20, 2001 at 02:38:53PM +0100, Thomas Leonard wrote: > > The only issue I see is that the colours are always allocated, even if > > colouring is off. This might cause problems for people with very old > > displays? > > Here is a diff to fix this. Now colours are freed/allocated as needed. Applied, along with Stephen's patch for the colourmap problems. > It is from TODO: > Enter '/usr/bin', then 'mh'. Go up, and the filer scrolls to the bottom! > > It seems to happen only if the cursor is hidden. I attached a diff that > (hopefully) fixes this problem. Yep, that works for me -- also applied. > And last: here is an updated hu.po for the CVS version. Thanks! -- Thomas Leonard http://rox.sourceforge.net ta...@ec... ta...@us... |