From: Guido S. <__g...@we...> - 2005-02-27 19:06:12
|
On Sun, 27 Feb 2005 15:22:08 +0000 Bungee <bu...@er...> wrote: > Hi Guido, > > I was very pleased to see this on your site and immediately downloaded > it :) At least one :) > I have identified a few more bugs! Some I have fixed myself, others are > too complex for me to find. > > I still haven't worked out how to create patch files properly so I've > attached the complete modified events.c file. diff -Nur path/to/original path/to/patched >program-release-what_this_patch_is_about.diff e.g. diff -Nur /home/bungee/Apps/OroboROX /home/bungee/devel/OroboROX >OroboROX-0.9.6-RiscOS.diff or diff -Nu /home/bungee/Apps/OroboROX/src/events.c \ /home/bungee/devel/OroboROX/src/events.c >OroboROX-0.9.6-events.c-RiscOS.diff > I've marked up the changes I made with my name and the date - this isn't > to get any special recognition, just so you can see what I've done. No, that's fine. That's how it should be. > These are the bugs I identified: > > RISC OS style patched bugs > > Clicking on the title with button 1 did not bring the window to the > front. Clicking on the content did - corrected > > Resize did not work for Buttons 2 & 3 - corrected Before I have a look, does this patch potentially affect non-RiscOS modes? Would need a bit of testing then. Otherwise, users of this mode should scream now if they think the change isn't right. "Object now or be silent forever" or whatever the exact words in the English wedding ceremony :) > Unpatched bugs > > Pointer does not change to resize (or move) when passing over window > sides or bottom. Corners are correct. Confirmed. > If window is at the very top of the screen pointer resize icon is moved > to the right when over either of the top corners. Need a precise test-case. Don't know how to reproduce that, trying it quickly. > KDE? bugs. In this case a fix might have to wait until kde-3.4 is released. Haven't kdelibs installed now, but will compile kdelibs-3.4 when released. > Kview always seems to open with the title bar off the top of the screen > and the left border outside. I can't find any other applications that > show this behavior. Can you try this with other WMs?. I suppose it doesn't happen with KWin. Any other WM's installed you could try? Gives a better picture of who might be at fault. Incidentally, there is a new Gnome (with sane dependencies) PS/PDF viewer in the works called Evince. Despite its low version number (0.1.5) it seems to work nicely already. It combines the capabilities of ggv and gpdf and doesn't come as a flaky and useless bonobo component. > K3b creates a blank window (supposed to be a status window) when > actually burning, that stays at the front of all other windows and in > the centre of the screen. This has no borders but shows a small K3b icon > in the top left corner. This window disappears when the burning is > completed and the main dialogue window is closed. Please do: xprop >kview.txt (click the window in question) xprop >k3b.txt (click the window in question) and mail me those. I think there is still a bug in OroboROX with windows becoming withdrawn when they shouldn't. |