Menu
▾
▴
rox-devel
|
From: David R. <dav...@t-...> - 2015-02-04 16:56:03
Attachments:
columnclick.patch
|
Hi, on the off chance that this mailing list is still active: Attached you find a tiny patch that changes selection events in details mode so that only clicks on the name or icon initiate actions on the file and that all other columns count as background for the purposes of filer_perform_action. That makes lasso selection MUCH easier, without that change you have to aim for some few pixels "between" the files. Beware, I know basically nothing about C or GTK, so this is more of a demo than anything else, but it works and does not appear to introduce any problems. Furthermore, a bug report: According to strace, rox-filer hangs on listxattr when browsing NFS directories or directories that contain symlinks into or mountpoints for them. (Unless xattr is disabled, of course.) I don't know if that's a problem of rox-filer or of the library you use, but I guess you're using an obsolete call there or something like that because the bug was introduced without changes in rox-filer. Regards, David PS: If this list and project are dead, that's sad - RF is still the best light-weight file manager for Linux. |
|
From: Thomas L. <ta...@gm...> - 2015-02-08 14:09:27
|
On 4 February 2015 at 16:55, David Reis <dav...@t-...> wrote: > Hi, > > on the off chance that this mailing list is still active: Attached you > find a tiny patch that changes selection events in details mode so that > only clicks on the name or icon initiate actions on the file and that > all other columns count as background for the purposes of > filer_perform_action. That makes lasso selection MUCH easier, without > that change you have to aim for some few pixels "between" the files. > Beware, I know basically nothing about C or GTK, so this is more of a > demo than anything else, but it works and does not appear to introduce > any problems. Sounds reasonable, but the patch doesn't apply: $ git apply /tmp/columnclick.patch error: patch failed: ROX-Filer/src/filer.c:3647 error: ROX-Filer/src/filer.c: patch does not apply How did you create it? It seems to be missing the normal Git header. Try creating a pull request from here: https://github.com/rox-desktop/rox-filer > Furthermore, a bug report: According to strace, rox-filer hangs on > listxattr when browsing NFS directories or directories that contain > symlinks into or mountpoints for them. (Unless xattr is disabled, of > course.) I don't know if that's a problem of rox-filer or of the library > you use, but I guess you're using an obsolete call there or something > like that because the bug was introduced without changes in rox-filer. I don't have an NFS system to test on, but if you find the problem let me know. Can you attach gdb to it once it hangs? > Regards, > David > > PS: If this list and project are dead, that's sad - RF is still the best > light-weight file manager for Linux. -- Dr Thomas Leonard http://0install.net/ GPG: 9242 9807 C985 3C07 44A6 8B9A AE07 8280 59A5 3CC1 GPG: DA98 25AE CAD0 8975 7CDA BD8E 0713 3F96 CA74 D8BA |
|
From: David R. <dav...@t-...> - 2015-02-09 10:38:18
|
Hi! On Sun, 2015-02-08 at 14:09 +0000, Thomas Leonard wrote: > Sounds reasonable, but the patch doesn't apply: > How did you create it? It seems to be missing the normal Git header. Yeah, I just made a normal diff, didn't know how to use git except git clone. I tried to do it "properly" now, the patch is attached - I hope everything's in order with it. > I don't have an NFS system to test on, but if you find the problem let > me know. Can you attach gdb to it once it hangs? I can't anymore, because it works now - I went back to Debian Sid's stock kernel in the meantime, and don't have any problems any more. Before that, I had a Liquorix kernel, maybe they tuned a bit too much there. Regards, David |
|
From: Thomas L. <ta...@gm...> - 2015-02-14 12:02:37
|
On 9 February 2015 at 10:38, David Reis <dav...@t-...> wrote: > Hi! > > On Sun, 2015-02-08 at 14:09 +0000, Thomas Leonard wrote: > >> Sounds reasonable, but the patch doesn't apply: >> How did you create it? It seems to be missing the normal Git header. > > Yeah, I just made a normal diff, didn't know how to use git except git > clone. I tried to do it "properly" now, the patch is attached - I hope > everything's in order with it. Yep, this works. I'm not sure about it, though. It feels like clicking on the text in any column should select and it feels strange when it doesn't. How about making it so that dragging from any text or icon works as before, but clicking in the empty space in any table cell starts a lasso? I think that might be more natural. Thanks, -- Dr Thomas Leonard http://0install.net/ GPG: 9242 9807 C985 3C07 44A6 8B9A AE07 8280 59A5 3CC1 GPG: DA98 25AE CAD0 8975 7CDA BD8E 0713 3F96 CA74 D8BA |
Thanks for helping keep SourceForge clean.
X