From: Thomas L. <ta...@ec...> - 2001-01-29 11:21:16
|
On Sun, Jan 28, 2001 at 01:03:45PM -0500, Diego Zamboni wrote: > > How about if we call it 'DirIcon.png' and use that for applications and > > directories? We'll want to change from AppIcon.xpm sometime soon anyway... > > Fine with me. Although I personally like the xpm format. There's something > nice about a graphics format I can edit with vi :-) (and I actually do a > fair amount of hand-editing in xpm files) Besides, almost every > single icon out there is already in xpm. My main reason for liking png is that it supports variable alpha, which means we get smooth edges whatever the background colour (currently, some icons have a white halo on a dark background). This will probably need XRender and other changes before it actually works, of course ;-) [ hidden files ] OK, if we're going to use hidden files then I think we should change AppRun too, eg: .DirIcon.png and .AppRun The old files will still be supported for compatibility for a while... Everyone OK with that? Maybe we should add a '[2 hidden files]' message to the toolbar when you open the directory? > > The interface for changing the icon is rather fun :-) > > Isn't it? :-) I have spent a lot of time browsing in thumbs mode through > my icons directory looking for appropriate images for some files and > directories... productivity down the drain. > > > But, in practice, maybe the glob stuff isn't really needed. > > ... I know, I keep changing my mind! > > Yes you do :-) > > I think globicons is good. See my reasons below. > > > - Keeping the 'File' menu short is good > > Agree. How about combining "Set run action" and "Set icon" on a single > dialog? No - one works on type, the other on a specific file! > > - Storing icon information away from the file is bad (imagine if users > > keep setting icons and then move/delete the files - the globicons file > > will grow without limit!). > > Agree. However, I believe that people will only change the icons of certain > "special" files and directories, therefore making keeping track of them > not too complicated. OK. [ ... ] > Along those lines, how about looking for both .png and .xpm files? Let > people use what they want. Again, a really small addition to the code. Every extra file is an extra stat() we have to do on *every* directory listed in a filer window... we'll do this for a while for compatibility, of course... > > Would that be OK? > > As you may remember, my original patch for directory icons only used the > .DirIcon.xpm file. However, once I started exploring the use of the globicons > file, I really liked it because: > > - it allows you to set the icons for files > > - it uses glob patterns, so you can cover a lot of files/directories > with a single entry. For example, I have /home/* set to a "neighbor's > house" icon, before the entry for /home/zamboni that sets my home > directory to the "house" icon. Nice... maybe that should be set in the defaults ;-) Is '~' allowed in globicons? Anyway, some notes on the patch: - You don't need to check the size of globicons icons, since they always come from a trusted source. - Maybe we should merge all the globicon lists in Choices? But then, how do we let a user disable a sysadmin's choice? - Much of the patch could be moved to a new file? - Closing the Set Icon dialog says: Gtk-CRITICAL **: file gtkwidget.c: line 1385 (gtk_widget_destroy): assertion `GTK_IS_WIDGET (widget)' failed. It's a fun patch, though, so I guess it will go in soon ;-) -- Thomas Leonard http://rox.sourceforge.net ta...@ec... ta...@us... |