Re: [rox-devel] Feature Suggestion Patch and Bug Report for Filer

[Thomas L. <ta...@gm...>]

On 4 February 2015 at 16:55, David Reis <dav...@t-...> wrote:
> Hi,
>
> on the off chance that this mailing list is still active: Attached you
> find a tiny patch that changes selection events in details mode so that
> only clicks on the name or icon initiate actions on the file and that
> all other columns count as background for the purposes of
> filer_perform_action. That makes lasso selection MUCH easier, without
> that change you have to aim for some few pixels "between" the files.
> Beware, I know basically nothing about C or GTK, so this is more of a
> demo than anything else, but it works and does not appear to introduce
> any problems.

Sounds reasonable, but the patch doesn't apply:

$ git apply /tmp/columnclick.patch
error: patch failed: ROX-Filer/src/filer.c:3647
error: ROX-Filer/src/filer.c: patch does not apply

How did you create it? It seems to be missing the normal Git header.
Try creating a pull request from here:

https://github.com/rox-desktop/rox-filer

> Furthermore, a bug report: According to strace, rox-filer hangs on
> listxattr when browsing NFS directories or directories that contain
> symlinks into or mountpoints for them. (Unless xattr is disabled, of
> course.) I don't know if that's a problem of rox-filer or of the library
> you use, but I guess you're using an obsolete call there or something
> like that because the bug was introduced without changes in rox-filer.

I don't have an NFS system to test on, but if you find the problem let
me know. Can you attach gdb to it once it hangs?

> Regards,
> David
>
> PS: If this list and project are dead, that's sad - RF is still the best
> light-weight file manager for Linux.



-- 
Dr Thomas Leonard        http://0install.net/
GPG: 9242 9807 C985 3C07 44A6  8B9A AE07 8280 59A5 3CC1
GPG: DA98 25AE CAD0 8975 7CDA  BD8E 0713 3F96 CA74 D8BA