From: Tony H. <h...@re...> - 2004-08-29 17:33:37
|
In <200...@re...>, Tony Houghton wrote: > In <1093488096l.23736l.1l@RoxOS>, Guido Schimmels wrote: > > > Am 24.08.2004 22:01:12 schrieb(en) Tony Houghton: > > > > >I'm seeing something different. The panel doesn't gain focus but if I > > >move the pointer to its bottom so that it raises then move the > > >pointer off it, the current window loses focus. > > > > > >I guess that's something to do with my new code for dealing with > > >above and below states being switched on and off. I know we agreed it > > >needed some work anyway because it shouldn't (completely) lower > > >windows when they lose STATE_ABOVE, but we never properly discussed a > > >solution. > > > > Unless you say it makes OroboROX unusable, or at least an (overall) > > regression from 0.8.7.3, I'm not going to fix stacking behaviour for > > 0.8.8. The thing is we are using an unbecoming mix of Gnome and EWMH > > stacking hints. That's never going to work too well without a lot of > > crazy tricks. I'm already working on a version which has the Gnome > > hints dropped entirely in favor of EWMH. The two code bases are > > drifting apart rapidly. I don't want to spend much time with the old > > code in 0.8.8 anymore. > > A possible quick fix for 0.8.8 is to basically regress most of the code > so it does no more than set or clear the states and leaves it up to the > application to raise or lower as necessary, which ROX does with its > panel. I don't mind doing that, but if you're moving away from 0.8.8 I > don't think it's worth doing anything more sophisticated than that. I've had a quick look at it again and I can't see anything in my changes that would cause these focus problems. I can still do a quick fix to stop it lowering windows when you turn "on top" off by right clicking the sticky button, relying on applications to raise and lower when necessary, but I think as it's not a big problem it might be better to wait for the new code base. I also realised why the indenting was going wrong; it's using a mixture of tabs and spaces and your tab stop is 4 whereas mine is 8. I think it would be best to expand all the tabs, agreed? -- TH * http://www.realh.co.uk |