Re: [rox-devel] [Patch] OroboROX, Xinerama and Solaris

[Jonatan Liljedahl <than@ho...>]

On Mon, 28 Jun 2004 17:14:51 +0100
Tony Houghton <h@...> wrote:

> In <04Jun28.142832bst.23634@...>, Stephen Watson wrote:
> 
> > In message <20040623142148.GA25680@...>
> >           Tony Houghton <h@...> scribbled:
> > 
> > > Version 3.1 of my patch is now available with improvements as
> > > discussed before, most importantly Solaris support (I hope).
> > > Stephen Watson, please can you test this for me, as obviously I
> > > haven't been able to. I don't suppose you'll be able to test it
> > > with a proper Xinerama setup, but if it works on Solaris at all at
> > > least that's something!
> > 
> > This is an updated patch.  It fixes one undefined variable and one
> > missing function.  This produces a executable that does work on an
> > non-Xinerama setup.
> 
> I think we both slipped up a bit. I shouldn't have made those
> mistakes, but you could have replaced XineramaIsActive(dpy) with
> XineramaGetState(dpy, screen). Hopefully the latest version(s) at
> <http://www.realh.co.uk/unix.html#oroxine>; will now both compile under
> Solaris and proveide Xinerama support on it for those that want it!
> 
> Please could you test version 3.2 of the patch and report back so
> Jonatan can apply it if it works.

I can only find 3.1-3.2 on your website, and the last one I applied was
3.0...
But I guess
http://www.realh.plus.com/unix/oroborox-0.8.7.2-xinerama-3.0-3.1.diff is
valid?


--
/Jonatan - [ http://kymatica.com ]

[rox-devel] [Patch] OroboROX, Xinerama and Solaris

[Tony Houghton <h@re...>]

Version 3.1 of my patch is now available with improvements as discussed
before, most importantly Solaris support (I hope). Stephen Watson,
please can you test this for me, as obviously I haven't been able to. I
don't suppose you'll be able to test it with a proper Xinerama setup,
but if it works on Solaris at all at least that's something!

If you get an error about MAXFRAMEBUFFERS being undefined, try replacing
it with a magic number. AFAICT 16 is safe (GDK uses that as an
apparently related magic number, and who would have that many
monitors?); < 16 might cause nasty crashes if someone is lucky enough to
have that many monitors; > 16 is safer still, but anything very much
bigger might be detrimental to performance with stack memory usage.

-- 
TH * http://www.realh.co.uk

Re: [rox-devel] [Patch] OroboROX, Xinerama and Solaris

[Jonatan Liljedahl <than@ho...>]

On Wed, 23 Jun 2004 15:21:49 +0100
Tony Houghton <h@...> wrote:

> Version 3.1 of my patch is now available with improvements as
> discussed
>  before, most importantly Solaris support (I hope). Stephen Watson,
>  please can you test this for me, as obviously I haven't been able to.
>  I don't suppose you'll be able to test it with a proper Xinerama
>  setup, but if it works on Solaris at all at least that's something!

I'll wait for Stephen to test it before I apply it and release 0.8.7.3.

I hope you have a patch to apply on top of your last one
(0.8.7.2-xinerama-3.0), and that it will succeed to patch as I've hacked
around a bit in the code after that... =)

--
/Jonatan - [ http://kymatica.com ]

Re: [rox-devel] [Patch] OroboROX, Xinerama and Solaris

[Tony Houghton <h@re...>]

In <20040623163848.448166fe.than@...>, Jonatan Liljedahl wrote:

> On Wed, 23 Jun 2004 15:21:49 +0100 Tony Houghton <h@...>
> wrote:
> 
> > Version 3.1 of my patch is now available with improvements as
> > discussed before, most importantly Solaris support (I hope). Stephen
> > Watson, please can you test this for me, as obviously I haven't been
> > able to.  I don't suppose you'll be able to test it with a proper
> > Xinerama setup, but if it works on Solaris at all at least that's
> > something!
> 
> I'll wait for Stephen to test it before I apply it and release
> 0.8.7.3.
> 
> I hope you have a patch to apply on top of your last one
> (0.8.7.2-xinerama-3.0), and that it will succeed to patch as I've
> hacked around a bit in the code after that... =)

Yes, I have got an incremental patch. Hopefully it will apply with some
"fuzz" or whatever it usually says, because I don't think I would have
changed the same functions as you. I included the changes that Stephen
posted, but even if you've also already included them, patch should ask
you whether you want to skip or reverse them if the same changes are in
my patch. You should be able to work out any problems by reading the
patch file anyway.

I forgot to post the URL last time:

http://www.realh.co.uk/unix.html#oroxine

-- 
TH * http://www.realh.co.uk

Re: [rox-devel] [Patch] OroboROX, Xinerama and Solaris

[Stephen Watson <swatson@ue...>]

In message <20040623142148.GA25680@...>
          Tony Houghton <h@...> scribbled:

> Version 3.1 of my patch is now available with improvements as discussed
> before, most importantly Solaris support (I hope). Stephen Watson,
> please can you test this for me, as obviously I haven't been able to. I
> don't suppose you'll be able to test it with a proper Xinerama setup,
> but if it works on Solaris at all at least that's something!

This is an updated patch.  It fixes one undefined variable and one missing
function.  This produces a executable that does work on an non-Xinerama
setup.

-- 
Stephen Watson          Physicist
Ultra Electronics Ltd - Signature Management Systems (UESMS)
Tel: +44 (0)1543 878888 (switchboard)     Fax: +44 (0)1543 878249
Email: watson@...

Re: [rox-devel] [Patch] OroboROX, Xinerama and Solaris

[Tony Houghton <h@re...>]

In <04Jun28.142832bst.23634@...>, Stephen Watson wrote:

> In message <20040623142148.GA25680@...>
>           Tony Houghton <h@...> scribbled:
> 
> > Version 3.1 of my patch is now available with improvements as discussed
> > before, most importantly Solaris support (I hope). Stephen Watson,
> > please can you test this for me, as obviously I haven't been able to. I
> > don't suppose you'll be able to test it with a proper Xinerama setup,
> > but if it works on Solaris at all at least that's something!
> 
> This is an updated patch.  It fixes one undefined variable and one missing
> function.  This produces a executable that does work on an non-Xinerama
> setup.

I think we both slipped up a bit. I shouldn't have made those mistakes,
but you could have replaced XineramaIsActive(dpy) with
XineramaGetState(dpy, screen). Hopefully the latest version(s) at
<http://www.realh.co.uk/unix.html#oroxine>; will now both compile under
Solaris and proveide Xinerama support on it for those that want it!

Please could you test version 3.2 of the patch and report back so
Jonatan can apply it if it works.

-- 
TH * http://www.realh.co.uk

Re: [rox-devel] [Patch] OroboROX, Xinerama and Solaris

[Jonatan Liljedahl <than@ho...>]

On Mon, 28 Jun 2004 17:14:51 +0100
Tony Houghton <h@...> wrote:

> In <04Jun28.142832bst.23634@...>, Stephen Watson wrote:
> 
> > In message <20040623142148.GA25680@...>
> >           Tony Houghton <h@...> scribbled:
> > 
> > > Version 3.1 of my patch is now available with improvements as
> > > discussed before, most importantly Solaris support (I hope).
> > > Stephen Watson, please can you test this for me, as obviously I
> > > haven't been able to. I don't suppose you'll be able to test it
> > > with a proper Xinerama setup, but if it works on Solaris at all at
> > > least that's something!
> > 
> > This is an updated patch.  It fixes one undefined variable and one
> > missing function.  This produces a executable that does work on an
> > non-Xinerama setup.
> 
> I think we both slipped up a bit. I shouldn't have made those
> mistakes, but you could have replaced XineramaIsActive(dpy) with
> XineramaGetState(dpy, screen). Hopefully the latest version(s) at
> <http://www.realh.co.uk/unix.html#oroxine>; will now both compile under
> Solaris and proveide Xinerama support on it for those that want it!
> 
> Please could you test version 3.2 of the patch and report back so
> Jonatan can apply it if it works.

I can only find 3.1-3.2 on your website, and the last one I applied was
3.0...
But I guess
http://www.realh.plus.com/unix/oroborox-0.8.7.2-xinerama-3.0-3.1.diff is
valid?


--
/Jonatan - [ http://kymatica.com ]

Re: [rox-devel] [Patch] OroboROX, Xinerama and Solaris

[Tony Houghton <h@re...>]

In <20040628215317.73396444.than@...>, Jonatan Liljedahl wrote:

> I can only find 3.1-3.2 on your website, and the last one I applied was
> 3.0...
> But I guess
> http://www.realh.plus.com/unix/oroborox-0.8.7.2-xinerama-3.0-3.1.diff is
> valid?

The web page is meant as a guide rather than a complete listing which is
at <http://www.realh.plus.com/unix/>;. You're right about the above link
though, you should be able to apply that then 3.1-3.2.

-- 
TH * http://www.realh.co.uk