#111 Merge directory quiet functionality

Incorrect_behaviour
closed-fixed
nobody
None
5
2014-06-15
2014-06-11
And Sch
No

This is incorrect behavior in Rox Filer 2.11. When merging directories, even with quiet on, it will prompt for every single file. This is very annoying and incorrect behavior. I have a proposed fix which seems to work in action.c:

if (!printf_reply(from_parent, TRUE,
                      _("?'%s' already exists - %s?"),
                      dest_path,
                      merge ? _("merge contents")
                        : _("overwrite")))
                return;

Should be split into:

if (merge)
            {
                if (!printf_reply(from_parent, TRUE,
                      _("?'%s' already exists - %s?"),
                      dest_path, _("merge contents")))
                return;
            }
            else
            {
                if (!printf_reply(from_parent, FALSE,
                      _("?'%s' already exists - %s?"),
                      dest_path, _("overwrite")))
                return;
            }

This way the handling of merging and overwriting is done separately. If quiet is on, overwriting should be quieted, but merging the directory should not.

Thanks for your consideration.

Discussion

  • Thomas Leonard

    Thomas Leonard - 2014-06-15

    Seems reasonable. Done (changed TRUE to merge).

     
  • Thomas Leonard

    Thomas Leonard - 2014-06-15
    • status: open --> closed-fixed
     

Log in to post a comment.

Get latest updates about Open Source Projects, Conferences and News.

Sign up for the SourceForge newsletter:





No, thanks