From: Philippe M. <phi...@gm...> - 2008-02-13 08:51:24
Attachments:
patch_1875876.txt
|
Attached is a patch to be applied to Trunk for making the transport mode persistent. The retrieval of the mode value from RG files now works also when loading the default document, which allows for giving a default setting to the transport mode. A couple of design choices: - transportmode is stored in the <configuration> element of the RG file, as a string, which is mapped to the enum by the TransportDialog - no error is raised if a wrong value is found (fails to default value silently) - I commented out the call to make the document modified: I found it strange to open a song for listening, changing the transport mode, and then being prompted for a changed file. But as it does it for zoom level change, it may be done as such here, just for consistency. Feel free to comment, criticize, try out, debug, etc. Thanks for the time. -- Best regards, Philippe. |
From: D. M. M. <mic...@ro...> - 2008-02-13 22:40:05
Attachments:
big-smile.jpg
|
On Wednesday 13 February 2008, Philippe Macaire wrote: > Feel free to comment, criticize, try out, debug, etc. Or commit. Revision 8646. I didn't beat the hell out of it, but it seems to be working reasonably for new files I create, and not breaking any random old files I tried, so I don't see a lot of opportunity for a sneaky crash to show up, and it looks good to me. Thanks for implementing your own idea! -- D. Michael McIntyre |
From: Philippe M. <phi...@gm...> - 2008-02-14 11:38:36
|
On Wed, Feb 13, 2008 at 11:38 PM, D. Michael McIntyre <mic...@ro...> wrote: > Or commit. Revision 8646. I didn't beat the hell out of it, but it seems to > be working reasonably for new files I create, and not breaking any random old > files I tried, so I don't see a lot of opportunity for a sneaky crash to show > up, and it looks good to me. Great! Thanks for the feedback. -- Best regards, Philippe. |