From: Dr N. J B. <Nic...@gl...> - 2011-06-28 11:21:00
Attachments:
rg.diff
|
The attached patch fixes a silly bug in the pitch-tracker which causes it to have a target frequency of 0Hz whenever the target note is in the octave below the reference octave (usually the one with A440 in it). As this is in the master branch now, I wonder if somebody with the appropriate permissions could apply it? Thanks, Nick/. -- Nick Bailey Science and Music Research Group, The University of Glasgow http://www.n-ism.org/People/nick.php Find out about our Masters in Signal Processing, Electronics and Computing Techniques for Researching and Understanding Music http://www.n-ism.org/SPECTRUM |
From: Chris C. <ca...@al...> - 2011-07-11 12:03:42
|
On 28 June 2011 12:00, Dr Nicholas J Bailey <Nic...@gl...> wrote: > The attached patch fixes a silly bug in the pitch-tracker which causes it to > have a target frequency of 0Hz whenever the target note is in the octave below > the reference octave (usually the one with A440 in it). I've only just got around to looking at this (I see that Michael has committed it for you) and I'm intrigued -- all it does is add three consts, right? How does that fix anything? What am I missing? Chris |
From: Alvar U. <alv...@gm...> - 2011-07-11 12:51:00
|
Hello I see theres also - int octaveRatio = pow( 2, octaveDifference ); + const double octaveRatio = pow( 2, octaveDifference ); in the patch. So the bug was probably due to lost precision when converting floating point to int. Alvar On Mon, Jul 11, 2011 at 3:03 PM, Chris Cannam <ca...@al...>wrote: > On 28 June 2011 12:00, Dr Nicholas J Bailey > <Nic...@gl...> wrote: > > The attached patch fixes a silly bug in the pitch-tracker which causes it > to > > have a target frequency of 0Hz whenever the target note is in the octave > below > > the reference octave (usually the one with A440 in it). > > I've only just got around to looking at this (I see that Michael has > committed it for you) and I'm intrigued -- all it does is add three > consts, right? How does that fix anything? What am I missing? > > > Chris > > > ------------------------------------------------------------------------------ > All of the data generated in your IT infrastructure is seriously valuable. > Why? It contains a definitive record of application performance, security > threats, fraudulent activity, and more. Splunk takes this data and makes > sense of it. IT sense. And common sense. > http://p.sf.net/sfu/splunk-d2d-c2 > _______________________________________________ > Rosegarden-devel mailing list > Ros...@li... - use the link below to unsubscribe > https://lists.sourceforge.net/lists/listinfo/rosegarden-devel > |
From: Chris C. <ca...@al...> - 2011-07-11 12:53:12
|
On 11 July 2011 13:50, Alvar Udras <alv...@gm...> wrote: > I see theres also > > - int octaveRatio = pow( 2, octaveDifference ); > + const double octaveRatio = pow( 2, octaveDifference ); Doh! Of course I saw that line, but I missed the important bit -- my brain just saw that it was similar to the other two. Thanks. Chris |
From: D. M. M. <mic...@ro...> - 2011-07-11 20:09:21
|
On Monday, July 11, 2011, Chris Cannam wrote: > Doh! Of course I saw that line, but I missed the important bit -- my > brain just saw that it was similar to the other two. Thanks. I missed it too. I just committed the patch blindly, figuring I was probably missing something. Now I know what it was. -- D. Michael McIntyre |