From: D. M. M. <mic...@ro...> - 2008-02-09 17:31:46
|
> Log Message: > ----------- > preparation for undo'ing changing the playable range This commit is broken. It includes at least one typo, but fixing the typo doesn't make it build. Committing broken code to a branch is OK, but code committed to trunk/ should always build, and should ideally be tested for immediate, show-stopping crashes too. Most common causes of problems are from forgetting to add a file, or from committing something without checking to make sure it actually builds first. We've all made this mistake at one time or another, but it's really obnoxious, and should please be avoided. (It's especially obnoxious since I grabbed that and merged it straight into my branch, so now I've broken *both* trees today. OK, I shouldn't be so quick to merge every change in trunk/ I guess, but still.) [ 0%] Building CXX object RGbuild/CMakeFiles/RosegardenCommands.dir/commands/segment/SegmentChangePlayableRangeCommand.o /home/silvan/SVN/rosegarden/src/commands/segment/SegmentChangePlayableRangeCommand.h: In constructor ‘Rosegarden::SegmentChangePlayableRangeCommand::SegmentChangePlayableRangeCommand(int, int, Rosegarden::Segment*)’: /home/silvan/SVN/rosegarden/src/commands/segment/SegmentChangePlayableRangeCommand.h:60: warning: ‘Rosegarden::SegmentChangePlayableRangeCommand::m_highestPlayableNote’ will be initialized after /home/silvan/SVN/rosegarden/src/commands/segment/SegmentChangePlayableRangeCommand.h:56: warning: ‘Rosegarden::Segment* Rosegarden::SegmentChangePlayableRangeCommand::m_segment’ /home/silvan/SVN/rosegarden/src/commands/segment/SegmentChangePlayableRangeCommand.cpp:36: warning: when initialized here /home/silvan/SVN/rosegarden/src/commands/segment/SegmentChangePlayableRangeCommand.cpp: In static member function ‘static QString Rosegarden::SegmentChangePlayableRangeCommand::getGlobalName(int, int)’: /home/silvan/SVN/rosegarden/src/commands/segment/SegmentChangePlayableRangeCommand.cpp:69: error: ‘unit’ was not declared in this scope make[2]: *** [RGbuild/CMakeFiles/RosegardenCommands.dir/commands/segment/SegmentChangePlayableRangeCommand.o] Error 1 make[1]: *** [RGbuild/CMakeFiles/RosegardenCommands.dir/all] Error 2 make: *** [all] Error 2 -- D. Michael McIntyre |
From: D. M. M. <mic...@ro...> - 2008-02-09 17:53:36
|
On Saturday 09 February 2008, D. Michael McIntyre wrote: > show-stopping crashes too. Most common causes of problems are from > forgetting to add a file, or from committing something without checking to > make sure it actually builds first. ...and making sure it actually runs without show-stopping crashes. Not the case here, I don't guess, but we've seen it. Somebody commits something that crashes at startup, upon creating a segment, or something similarly obvious and critical. Then two other people both commit conflicting fixes for the broken code, which both conflict with the original person's work under way, and the whole thing winds up being a huge mess. OK, we haven't actually seen a train wreck like that since the early days, when everybody was working heavily at the same time, but it's still a good practice to be careful something isn't busted before committing to trunk/. Thanks. -- D. Michael McIntyre |