From: Chris C. <ca...@al...> - 2006-11-29 13:41:14
|
Can someone tell me why the code I just committed (but commented out) at gui/editors/segment/SegmentSelector.cpp:146 doesn't appear to work? I had expected it to unselect a selected segment if you shift-click on it, but it seems to leave the segment a selected colour, remove the name label from it, and leave it in a kind of zombie halfway state. Chris |
From: Chris C. <ca...@al...> - 2006-11-29 13:45:01
|
On Wednesday 29 Nov 2006 13:41, Chris Cannam wrote: > Can someone tell me why the code I just committed (but commented out) at > gui/editors/segment/SegmentSelector.cpp:146 doesn't appear to work? ...and please don't even think of answering "because it's commented out"... Chris |
From: Guillaume L. <gla...@te...> - 2006-11-29 22:32:16
|
On Wednesday 29 November 2006 14:41, Chris Cannam wrote: > Can someone tell me why the code I just committed (but commented out) at > gui/editors/segment/SegmentSelector.cpp:146 doesn't appear to work? > > I had expected it to unselect a selected segment if you shift-click on it, > but it seems to leave the segment a selected colour, remove the name label > from it, and leave it in a kind of zombie halfway state. Quick answer after cursory look would be that it's because I haven't handled that case, that is unselecting a single segment - you either select some or clear the selection, the model doesn't handle any other case. If there's a bug/feature request attached to this (I think I've seen one), please assign it to me. -- Guillaume. http://telegraph-road.org |
From: Guillaume L. <gla...@te...> - 2006-12-04 13:12:02
|
On Wednesday 29 November 2006 23:32, Guillaume Laurent wrote: > On Wednesday 29 November 2006 14:41, Chris Cannam wrote: > > Can someone tell me why the code I just committed (but commented out) at > > gui/editors/segment/SegmentSelector.cpp:146 doesn't appear to work? > > > > I had expected it to unselect a selected segment if you shift-click on > > it, but it seems to leave the segment a selected colour, remove the name > > label from it, and leave it in a kind of zombie halfway state. > > Quick answer after cursory look would be that it's because I haven't > handled that case, that is unselecting a single segment - you either select > some or clear the selection, the model doesn't handle any other case. If > there's a bug/feature request attached to this (I think I've seen one), > please assign it to me. That was completely wrong, actually the segment is put in a 'moving' state, and is subsequently ignored by further redraws. Fix coming. -- Guillaume. http://telegraph-road.org |