#1747 X11 seems not required

[Nico P]

Hi,

X11 is required in CMakeLists.txt but it seems no longer strictly required now.
I found no header from X11 in code and it doesn't link against.
No trace of functions XSetErrorHandler & XGetErrorText from the comment.

[Ted Felix]

I'm guessing that was from the ancient X11 version of rosegarden. Sounds like it would be safe to remove that. We should do this for 26.06. If you have a patch, please send it and we will incorporate it. Otherwise I will take a closer look after 25.12 is released.

[Nico P]

Delete the line is sufficient.

--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -172,8 +172,6 @@ endif()

 find_package(ZLIB REQUIRED)

-find_package(X11 REQUIRED) # for XSetErrorHandler & XGetErrorText
-
 pkg_check_modules(LIBLO REQUIRED liblo>=0.7)

 pkg_check_modules(LRDF REQUIRED lrdf>=0.2)

[Ted Felix]

Fixed in [12a6aa]. Please test latest git.

Looks like X11 was only used in main.cpp back in 2015 and it was removed in November 2018 [8721fe]. Since I was able to track this down, I've pushed this to master for the 25.12 build.