#1549 Matrix Editor: Velocity ruler not updated correctly when changing velocity using the velocity tool
When I change the velocity of a note using the velocity tool (F7), the velocity ruler is not updated to show the new velocity value when I release the mouse button, if the X-axis is zoomed in more than the initial zoom. Instead, the velocity of that note is updated in the velocity ruler once you start changing it again. However, when you've made the new change, it is not updated, so you're stuck with the velocity value from one change ago. When you release the mouse button after changing the velocity, sometimes the velocity bars of other notes are updated in the velocity ruler, but I haven't found any consistent pattern for which notes affect each other.
Changing the velocity using the "Increase Velocity (Shift+Up)" and "Reduce Velocity (Shift+Down)", and through the velocity ruler itself works fine, so that works as a work-around. I've reproduced this bug in both the Percussion Matrix editor and the usual Matrix editor.
To reproduce:
1. Create new composition
2. Create new segment
3. Open segment in Matrix view
4. Place a couple notes
5. Open the velocity ruler
6. Zoom in a bit
7. Change to the velocity tool
8. Try changing the velocity of notes by click-and-dragging on the notes in the matrix editor, and observe that the new velocity value is not shown in the velocity ruler.
To see the expected behaviour, simply go back to the initial zoom.
I use Rosegarden version 17.04 (built from source) and Qt version 4.8.7 on Ubuntu Studio 16.04.
I confirm the problem (with or without zoom).
There are some other (more or less related) issues:
The velocity is displayed in the status bar when using the velocity tool, but not when dragging inside the velocity ruler.
Selecting multiple notes with the velocity tool (+ shift) is possible, but , to deselect them, you have to select another note. So when all notes are selected you can't deselect them with the velocity tool.
When using the velocity tool with multiple notes selected, the velocity of the first one is never updated in the velocity ruler.
The notes should not be highlighted on the piano keyboard when the velocity tool is used.
Why not? The highlighted note on the keyboard lets you know the pitch of the note you are about to change with the velocity tool. This seems like useful information. Of course, I think there was supposed to be some pitch display in the status bar that got broken and lost years ago.
Also, the keyboard is showing up with a color scheme like a harpsichord now, and probably has been since David Faure rewrote all the stuff to get rid of the hideous stylesheet. I should fix that one of these days. If things ever slow down at work or if I reach the end of my rope and quit this job to have a life again.
When you move the velocity tool, you change the velocity of the selected note, not its pitch. It would be fine to have the pitch of this note kept highlighted, but, currently, it is the keyboard note with the ypos of the mouse pointer which is highlighted.
When looking at the piano keyboard, you get the impression the pitch is changing which is not the case.
Ah yes, I see what you mean now! You are correct. That behavior is weird.
The main issue should be fixed in rev. 15041.
I'll fix the others ASAP.
The bug should now be totally fixed in rev. 15045.
I didn't modify the way notes are selected/deselected (or not deselected) with the velocity tool because:
- It's always possible to return to the select tool when deselecting notes is needed.
- To accidentally deselect a bunch of notes patiently selected is quite unpleasant.
I went ahead and tried out rev. 15045, and can indeed confirm that the problem is no more! It was a pleasant surprise to have the velocity ruler updated even while you're still changing the value, that makes it much easier to work with and a vast improvement over how it was before. With this, it'll be even easier to add dynamics to drum tracks (among others). Thank you so much for your work, Yves Guillemot :)