#1415 Up/Down Arrow to raise/lower pitch respects no boundary in notation

One Of These Days
closed
None
1
2016-03-21
2013-10-16
No

Draw a middle C in the notation editor, press the up arrow, and hold it there. The note will climb higher than seven neighboring staffs. I couldn't tell you what Rosegarden thought the pitch of that note was, but when I entered a 127 manually, it was nowhere near this high. I must have ascended to 256 or even 512 by that point. We get MIDI pitch from height on staff, and I'm not sure what we would even resolve this craziness to.

Unsurprisingly, I had a crash before I could investigate too deeply.

Extreme edge case not worth any priority, but since it's an edge case that could be fixed pretty easily, it might be worth an evening one day.

Discussion

  • D. Michael McIntyre

    • status: open --> closed
     
  • D. Michael McIntyre

    Fixed in [r14559]. Both versions of TransposeCommand avoid setting the pitch higher than 127 or lower than 0. This allows a clipping/flattening effect if you wield this thing poorly, but that kind of behavior is consistent with how we were already handling velocity, for example, and the change should be fine. MIDI pitches outside the 0 to 127 range are meaningless anyway.

     

    Related

    Commit: [r14559]


Log in to post a comment.