From: Zoltan B. <zb...@du...> - 2008-08-11 13:30:40
|
Hi, here are the patches that make RLIB compile on Windows. The patches are split up in a way to contain only one fix. There's one thing that's missing though, namely PHP. PHP on Windows absolutely requires MSVC, the PHP/Win distribution(s) doesn't even contain php.h, etc., only the stub library called php5ts.lib to make it possible to link with php5ts.dll. Making a Zend extension under Windows starts with compiling PHP from source, it seems... Best regards, Zoltán Böszörményi |
From: Bob D. <bd...@si...> - 2008-08-12 13:59:53
|
Hi Zoltan, All patches have been applied. We're ready for the next round :) - Bob On Mon, 2008-08-11 at 15:30 +0200, Zoltan Boszormenyi wrote: > Hi, > > here are the patches that make RLIB compile on Windows. > The patches are split up in a way to contain only one fix. > > There's one thing that's missing though, namely PHP. > PHP on Windows absolutely requires MSVC, the PHP/Win > distribution(s) doesn't even contain php.h, etc., only the stub > library called php5ts.lib to make it possible to link with php5ts.dll. > Making a Zend extension under Windows starts with compiling > PHP from source, it seems... > > Best regards, > Zoltán Böszörményi > > ------------------------------------------------------------------------- > This SF.Net email is sponsored by the Moblin Your Move Developer's challenge > Build the coolest Linux based applications with Moblin SDK & win great prizes > Grand prize is a trip for two to an Open Source event anywhere in the world > http://moblin-contest.org/redirect.php?banner_id=100&url=/ > _______________________________________________ Rlib-devel mailing list Rli...@li... https://lists.sourceforge.net/lists/listinfo/rlib-devel |
From: Bob D. <bd...@si...> - 2008-08-12 15:03:10
|
We have already. :) Looks good. Keep going. On Tue, 2008-08-12 at 16:46 +0200, Zoltan Boszormenyi wrote: > Hi, > > look at http://newrlib.sicom.com/index.php?title=Documentation_Install > > Best regards, > Zoltán > > Bob Doan írta: > > Hi Zoltan, > > > > All patches have been applied. > > > > We're ready for the next round :) > > > > - Bob > > > > On Mon, 2008-08-11 at 15:30 +0200, Zoltan Boszormenyi wrote: > > > >> Hi, > >> > >> here are the patches that make RLIB compile on Windows. > >> The patches are split up in a way to contain only one fix. > >> > >> There's one thing that's missing though, namely PHP. > >> PHP on Windows absolutely requires MSVC, the PHP/Win > >> distribution(s) doesn't even contain php.h, etc., only the stub > >> library called php5ts.lib to make it possible to link with php5ts.dll. > >> Making a Zend extension under Windows starts with compiling > >> PHP from source, it seems... > >> > >> Best regards, > >> Zoltán Böszörményi > >> > >> ------------------------------------------------------------------------- > >> This SF.Net email is sponsored by the Moblin Your Move Developer's challenge > >> Build the coolest Linux based applications with Moblin SDK & win great prizes > >> Grand prize is a trip for two to an Open Source event anywhere in the world > >> http://moblin-contest.org/redirect.php?banner_id=100&url=/ > >> _______________________________________________ Rlib-devel mailing list Rli...@li... https://lists.sourceforge.net/lists/listinfo/rlib-devel > >> > > > > > > > > |
From: Zoltan B. <zb...@du...> - 2008-08-15 08:46:10
Attachments:
09-pcode_op_functions-fix.diff
|
Hi, I was reviewing the function reference and crosschecking it with the source. Some notes: I think the source mixes up bitwise AND and logical AND. * && works on expressions of the same type: NUMBER && NUMBER (and performs logical AND) STRING && STRING returns TRUE if both STRINGs are non-NULL DATE && DATE would return TRUE always by intention but there's a missing "return TRUE;" in the code, causing double freeing. Fix is attached. * & works on NUMBERs only and performs bitwise or binary AND but the naming in the source labels it as "logical AND" I don't intend to change the naming in the source but it's good to know. The wiki documentation lacked bitwise AND up to now. Also, some others are also missing: * N^M, a.k.a. power(N, M) * chgdateof() * dtosf() Best regards, Zoltán Böszörményi Bob Doan írta: > Hi Zoltan, > > All patches have been applied. > > We're ready for the next round :) > > - Bob > > On Mon, 2008-08-11 at 15:30 +0200, Zoltan Boszormenyi wrote: > >> Hi, >> >> here are the patches that make RLIB compile on Windows. >> The patches are split up in a way to contain only one fix. >> >> There's one thing that's missing though, namely PHP. >> PHP on Windows absolutely requires MSVC, the PHP/Win >> distribution(s) doesn't even contain php.h, etc., only the stub >> library called php5ts.lib to make it possible to link with php5ts.dll. >> Making a Zend extension under Windows starts with compiling >> PHP from source, it seems... >> >> Best regards, >> Zoltán Böszörményi >> >> ------------------------------------------------------------------------- >> This SF.Net email is sponsored by the Moblin Your Move Developer's challenge >> Build the coolest Linux based applications with Moblin SDK & win great prizes >> Grand prize is a trip for two to an Open Source event anywhere in the world >> http://moblin-contest.org/redirect.php?banner_id=100&url=/ >> _______________________________________________ Rlib-devel mailing list Rli...@li... https://lists.sourceforge.net/lists/listinfo/rlib-devel >> > > > ------------------------------------------------------------------------- > This SF.Net email is sponsored by the Moblin Your Move Developer's challenge > Build the coolest Linux based applications with Moblin SDK & win great prizes > Grand prize is a trip for two to an Open Source event anywhere in the world > http://moblin-contest.org/redirect.php?banner_id=100&url=/ > _______________________________________________ > Rlib-devel mailing list > Rli...@li... > https://lists.sourceforge.net/lists/listinfo/rlib-devel > |
From: Zoltan B. <zb...@du...> - 2008-08-15 11:37:53
Attachments:
10-rlib_add_query_pointer_as-fix.diff
|
Hi, another question. There's two difference between rlib_add_query_pointer_as() and rlib_add_query_as(): - The "sql" parameter string is strdup()ed by rlib_add_query_as() but not by rlib_add_query_pointer_as(). I guess it's intentional, that's why there's a distinction at all. - rlib_add_query_as() returns an error if "input_source" was not yet defined as an input source by one of the rlib_add_datasource_*() calls. But rlib_add_query_pointer_as() doesn't. And there's not a single C source under libsrc where this is rechecked later. This seems to be a bug, fix is attached. Best regards, Zoltán Böszörményi Zoltan Boszormenyi írta: > Hi, > > I was reviewing the function reference and crosschecking it > with the source. Some notes: > I think the source mixes up bitwise AND and logical AND. > * && works on expressions of the same type: > NUMBER && NUMBER (and performs logical AND) > STRING && STRING returns TRUE if both STRINGs are non-NULL > DATE && DATE would return TRUE always by intention > but there's a missing "return TRUE;" in the code, causing > double freeing. > Fix is attached. > * & works on NUMBERs only and performs bitwise or binary AND > but the naming in the source labels it as "logical AND" > I don't intend to change the naming in the source but it's good to know. > The wiki documentation lacked bitwise AND up to now. > Also, some others are also missing: > * N^M, a.k.a. power(N, M) > * chgdateof() > * dtosf() > > Best regards, > Zoltán Böszörményi > > Bob Doan írta: > >> Hi Zoltan, >> >> All patches have been applied. >> >> We're ready for the next round :) >> >> - Bob >> >> On Mon, 2008-08-11 at 15:30 +0200, Zoltan Boszormenyi wrote: >> >> >>> Hi, >>> >>> here are the patches that make RLIB compile on Windows. >>> The patches are split up in a way to contain only one fix. >>> >>> There's one thing that's missing though, namely PHP. >>> PHP on Windows absolutely requires MSVC, the PHP/Win >>> distribution(s) doesn't even contain php.h, etc., only the stub >>> library called php5ts.lib to make it possible to link with php5ts.dll. >>> Making a Zend extension under Windows starts with compiling >>> PHP from source, it seems... >>> >>> Best regards, >>> Zoltán Böszörményi >>> >>> ------------------------------------------------------------------------- >>> This SF.Net email is sponsored by the Moblin Your Move Developer's challenge >>> Build the coolest Linux based applications with Moblin SDK & win great prizes >>> Grand prize is a trip for two to an Open Source event anywhere in the world >>> http://moblin-contest.org/redirect.php?banner_id=100&url=/ >>> _______________________________________________ Rlib-devel mailing list Rli...@li... https://lists.sourceforge.net/lists/listinfo/rlib-devel >>> >>> >> ------------------------------------------------------------------------- >> This SF.Net email is sponsored by the Moblin Your Move Developer's challenge >> Build the coolest Linux based applications with Moblin SDK & win great prizes >> Grand prize is a trip for two to an Open Source event anywhere in the world >> http://moblin-contest.org/redirect.php?banner_id=100&url=/ >> _______________________________________________ >> Rlib-devel mailing list >> Rli...@li... >> https://lists.sourceforge.net/lists/listinfo/rlib-devel >> >> > > > ------------------------------------------------------------------------ > > ------------------------------------------------------------------------- > This SF.Net email is sponsored by the Moblin Your Move Developer's challenge > Build the coolest Linux based applications with Moblin SDK & win great prizes > Grand prize is a trip for two to an Open Source event anywhere in the world > http://moblin-contest.org/redirect.php?banner_id=100&url=/ > ------------------------------------------------------------------------ > > _______________________________________________ > Rlib-devel mailing list > Rli...@li... > https://lists.sourceforge.net/lists/listinfo/rlib-devel |
From: Zoltan B. <zb...@du...> - 2008-08-15 12:58:05
|
Hi, another one, now it's a bit more serious, not fixable by a one-liner. It started out with an observation: * rlib_set_output_format_from_text() matches the passed-in string and if the string doesn't match to any known format string, TXT is assumed and r->format is set accordingly. * rlib_set_output_format() accepts any number as format indicator. this seems to be a bug by itself. I think there is an unintentional mixup in the defines. #define RLIB_CONTENT_TYPE_ERROR -1 #define RLIB_CONTENT_TYPE_PDF 1 #define RLIB_CONTENT_TYPE_HTML 2 #define RLIB_CONTENT_TYPE_TXT 3 #define RLIB_CONTENT_TYPE_CSV 4 #define RLIB_FORMAT_PDF 1 #define RLIB_FORMAT_HTML 2 #define RLIB_FORMAT_TXT 3 #define RLIB_FORMAT_CSV 4 #define RLIB_FORMAT_XML 5 And look at the usage patterns of r->format: rlib_make_report() uses r->format in a multi-conditional if() where the following output formats are handled explicitely: HTML, TXT, CSV. The last else (if all else fails) assumes PDF output is given. r->format is matched against RLIB_FORMAT_* here. RLIB_FORMAT_XML is not handled, rlib_xml_new_output_filter() does not exist. rlib_get_content_type_as_text() matches r->format against RLIB_CONTENT_TYPE_*. Also, the matching order is different from rlib_make_report(). PDF, CSV and HTML is explicitely tested, if all else fails TXT is assumed. Now, consider someone uses: rlib_set_output_format(RLIB_FORMAT_XML); It's valid reading only the API headers. But the result is unexpected: - rlib_execute() generates a PDF report - rlib_get_content_type_as_text() returns the content of RLIB_WEB_CONTENT_TYPE_TEXT with the proper charset So, this part needs rethinking. I think you need to decide which part of the defines has to be deprecated deleted and use the other set of the defines exclusively in the sources. Also, were there any plans to introduce rlib_xml_new_output_filter()? Or only the input filter as it exists now? Best regards, Zoltán Böszörményi Zoltan Boszormenyi írta: > Hi, > > another question. There's two difference between > rlib_add_query_pointer_as() and rlib_add_query_as(): > > - The "sql" parameter string is strdup()ed by rlib_add_query_as() but > not by rlib_add_query_pointer_as(). > I guess it's intentional, that's why there's a distinction at all. > > - rlib_add_query_as() returns an error if "input_source" was not yet > defined as an input source by one of the rlib_add_datasource_*() calls. > But rlib_add_query_pointer_as() doesn't. And there's not a single C > source > under libsrc where this is rechecked later. This seems to be a bug, > fix is attached. > > Best regards, > Zoltán Böszörményi > > Zoltan Boszormenyi írta: > >> Hi, >> >> I was reviewing the function reference and crosschecking it >> with the source. Some notes: >> I think the source mixes up bitwise AND and logical AND. >> * && works on expressions of the same type: >> NUMBER && NUMBER (and performs logical AND) >> STRING && STRING returns TRUE if both STRINGs are non-NULL >> DATE && DATE would return TRUE always by intention >> but there's a missing "return TRUE;" in the code, causing >> double freeing. >> Fix is attached. >> * & works on NUMBERs only and performs bitwise or binary AND >> but the naming in the source labels it as "logical AND" >> I don't intend to change the naming in the source but it's good to know. >> The wiki documentation lacked bitwise AND up to now. >> Also, some others are also missing: >> * N^M, a.k.a. power(N, M) >> * chgdateof() >> * dtosf() >> >> Best regards, >> Zoltán Böszörményi >> >> Bob Doan írta: >> >> >>> Hi Zoltan, >>> >>> All patches have been applied. >>> >>> We're ready for the next round :) >>> >>> - Bob >>> >>> On Mon, 2008-08-11 at 15:30 +0200, Zoltan Boszormenyi wrote: >>> >>> >>> >>>> Hi, >>>> >>>> here are the patches that make RLIB compile on Windows. >>>> The patches are split up in a way to contain only one fix. >>>> >>>> There's one thing that's missing though, namely PHP. >>>> PHP on Windows absolutely requires MSVC, the PHP/Win >>>> distribution(s) doesn't even contain php.h, etc., only the stub >>>> library called php5ts.lib to make it possible to link with php5ts.dll. >>>> Making a Zend extension under Windows starts with compiling >>>> PHP from source, it seems... >>>> >>>> Best regards, >>>> Zoltán Böszörményi >>>> >>>> ------------------------------------------------------------------------- >>>> This SF.Net email is sponsored by the Moblin Your Move Developer's challenge >>>> Build the coolest Linux based applications with Moblin SDK & win great prizes >>>> Grand prize is a trip for two to an Open Source event anywhere in the world >>>> http://moblin-contest.org/redirect.php?banner_id=100&url=/ >>>> _______________________________________________ Rlib-devel mailing list Rli...@li... https://lists.sourceforge.net/lists/listinfo/rlib-devel >>>> >>>> >>>> >>> ------------------------------------------------------------------------- >>> This SF.Net email is sponsored by the Moblin Your Move Developer's challenge >>> Build the coolest Linux based applications with Moblin SDK & win great prizes >>> Grand prize is a trip for two to an Open Source event anywhere in the world >>> http://moblin-contest.org/redirect.php?banner_id=100&url=/ >>> _______________________________________________ >>> Rlib-devel mailing list >>> Rli...@li... >>> https://lists.sourceforge.net/lists/listinfo/rlib-devel >>> >>> >>> >> >> ------------------------------------------------------------------------ >> >> ------------------------------------------------------------------------- >> This SF.Net email is sponsored by the Moblin Your Move Developer's challenge >> Build the coolest Linux based applications with Moblin SDK & win great prizes >> Grand prize is a trip for two to an Open Source event anywhere in the world >> http://moblin-contest.org/redirect.php?banner_id=100&url=/ >> ------------------------------------------------------------------------ >> >> _______________________________________________ >> Rlib-devel mailing list >> Rli...@li... >> https://lists.sourceforge.net/lists/listinfo/rlib-devel >> > > > ------------------------------------------------------------------------ > > ------------------------------------------------------------------------- > This SF.Net email is sponsored by the Moblin Your Move Developer's challenge > Build the coolest Linux based applications with Moblin SDK & win great prizes > Grand prize is a trip for two to an Open Source event anywhere in the world > http://moblin-contest.org/redirect.php?banner_id=100&url=/ > ------------------------------------------------------------------------ > > _______________________________________________ > Rlib-devel mailing list > Rli...@li... > https://lists.sourceforge.net/lists/listinfo/rlib-devel |
From: Bob D. <bd...@si...> - 2008-08-15 20:08:21
|
We have plans to introduce an XML output, but we can take it out for now. We'll do it post 2.0 I removed it an did a commit. - Bob On Fri, 2008-08-15 at 14:57 +0200, Zoltan Boszormenyi wrote: > Hi, > > another one, now it's a bit more serious, not fixable by a one-liner. > It started out with an observation: > * rlib_set_output_format_from_text() matches the passed-in string and > if the string doesn't match to any known format string, > TXT is assumed and r->format is set accordingly. > * rlib_set_output_format() accepts any number as format indicator. > this seems to be a bug by itself. > > I think there is an unintentional mixup in the defines. > > #define RLIB_CONTENT_TYPE_ERROR -1 > #define RLIB_CONTENT_TYPE_PDF 1 > #define RLIB_CONTENT_TYPE_HTML 2 > #define RLIB_CONTENT_TYPE_TXT 3 > #define RLIB_CONTENT_TYPE_CSV 4 > > #define RLIB_FORMAT_PDF 1 > #define RLIB_FORMAT_HTML 2 > #define RLIB_FORMAT_TXT 3 > #define RLIB_FORMAT_CSV 4 > #define RLIB_FORMAT_XML 5 > > And look at the usage patterns of r->format: > > rlib_make_report() uses r->format in a multi-conditional if() where > the following output formats are handled explicitely: HTML, TXT, CSV. > The last else (if all else fails) assumes PDF output is given. > r->format is matched against RLIB_FORMAT_* here. > RLIB_FORMAT_XML is not handled, rlib_xml_new_output_filter() > does not exist. > > rlib_get_content_type_as_text() matches r->format against > RLIB_CONTENT_TYPE_*. Also, the matching order is different > from rlib_make_report(). PDF, CSV and HTML is explicitely tested, > if all else fails TXT is assumed. > > Now, consider someone uses: > > rlib_set_output_format(RLIB_FORMAT_XML); > > It's valid reading only the API headers. But the result is unexpected: > > - rlib_execute() generates a PDF report > - rlib_get_content_type_as_text() returns the content of > RLIB_WEB_CONTENT_TYPE_TEXT with the proper charset > > So, this part needs rethinking. I think you need to decide which > part of the defines has to be deprecated deleted and use the other > set of the defines exclusively in the sources. Also, were there any > plans to introduce rlib_xml_new_output_filter()? Or only the > input filter as it exists now? > > Best regards, > Zoltán Böszörményi > > Zoltan Boszormenyi írta: > > Hi, > > > > another question. There's two difference between > > rlib_add_query_pointer_as() and rlib_add_query_as(): > > > > - The "sql" parameter string is strdup()ed by rlib_add_query_as() but > > not by rlib_add_query_pointer_as(). > > I guess it's intentional, that's why there's a distinction at all. > > > > - rlib_add_query_as() returns an error if "input_source" was not yet > > defined as an input source by one of the rlib_add_datasource_*() calls. > > But rlib_add_query_pointer_as() doesn't. And there's not a single C > > source > > under libsrc where this is rechecked later. This seems to be a bug, > > fix is attached. > > > > Best regards, > > Zoltán Böszörményi > > > > Zoltan Boszormenyi írta: > > > >> Hi, > >> > >> I was reviewing the function reference and crosschecking it > >> with the source. Some notes: > >> I think the source mixes up bitwise AND and logical AND. > >> * && works on expressions of the same type: > >> NUMBER && NUMBER (and performs logical AND) > >> STRING && STRING returns TRUE if both STRINGs are non-NULL > >> DATE && DATE would return TRUE always by intention > >> but there's a missing "return TRUE;" in the code, causing > >> double freeing. > >> Fix is attached. > >> * & works on NUMBERs only and performs bitwise or binary AND > >> but the naming in the source labels it as "logical AND" > >> I don't intend to change the naming in the source but it's good to know. > >> The wiki documentation lacked bitwise AND up to now. > >> Also, some others are also missing: > >> * N^M, a.k.a. power(N, M) > >> * chgdateof() > >> * dtosf() > >> > >> Best regards, > >> Zoltán Böszörményi > >> > >> Bob Doan írta: > >> > >> > >>> Hi Zoltan, > >>> > >>> All patches have been applied. > >>> > >>> We're ready for the next round :) > >>> > >>> - Bob > >>> > >>> On Mon, 2008-08-11 at 15:30 +0200, Zoltan Boszormenyi wrote: > >>> > >>> > >>> > >>>> Hi, > >>>> > >>>> here are the patches that make RLIB compile on Windows. > >>>> The patches are split up in a way to contain only one fix. > >>>> > >>>> There's one thing that's missing though, namely PHP. > >>>> PHP on Windows absolutely requires MSVC, the PHP/Win > >>>> distribution(s) doesn't even contain php.h, etc., only the stub > >>>> library called php5ts.lib to make it possible to link with php5ts.dll. > >>>> Making a Zend extension under Windows starts with compiling > >>>> PHP from source, it seems... > >>>> > >>>> Best regards, > >>>> Zoltán Böszörményi > >>>> > >>>> ------------------------------------------------------------------------- > >>>> This SF.Net email is sponsored by the Moblin Your Move Developer's challenge > >>>> Build the coolest Linux based applications with Moblin SDK & win great prizes > >>>> Grand prize is a trip for two to an Open Source event anywhere in the world > >>>> http://moblin-contest.org/redirect.php?banner_id=100&url=/ > >>>> _______________________________________________ Rlib-devel mailing list Rli...@li... https://lists.sourceforge.net/lists/listinfo/rlib-devel > >>>> > >>>> > >>>> > >>> ------------------------------------------------------------------------- > >>> This SF.Net email is sponsored by the Moblin Your Move Developer's challenge > >>> Build the coolest Linux based applications with Moblin SDK & win great prizes > >>> Grand prize is a trip for two to an Open Source event anywhere in the world > >>> http://moblin-contest.org/redirect.php?banner_id=100&url=/ > >>> _______________________________________________ > >>> Rlib-devel mailing list > >>> Rli...@li... > >>> https://lists.sourceforge.net/lists/listinfo/rlib-devel > >>> > >>> > >>> > >> > >> ------------------------------------------------------------------------ > >> > >> ------------------------------------------------------------------------- > >> This SF.Net email is sponsored by the Moblin Your Move Developer's challenge > >> Build the coolest Linux based applications with Moblin SDK & win great prizes > >> Grand prize is a trip for two to an Open Source event anywhere in the world > >> http://moblin-contest.org/redirect.php?banner_id=100&url=/ > >> ------------------------------------------------------------------------ > >> > >> _______________________________________________ > >> Rlib-devel mailing list > >> Rli...@li... > >> https://lists.sourceforge.net/lists/listinfo/rlib-devel > >> > > > > > > ------------------------------------------------------------------------ > > > > ------------------------------------------------------------------------- > > This SF.Net email is sponsored by the Moblin Your Move Developer's challenge > > Build the coolest Linux based applications with Moblin SDK & win great prizes > > Grand prize is a trip for two to an Open Source event anywhere in the world > > http://moblin-contest.org/redirect.php?banner_id=100&url=/ > > ------------------------------------------------------------------------ > > > > _______________________________________________ > > Rlib-devel mailing list > > Rli...@li... > > https://lists.sourceforge.net/lists/listinfo/rlib-devel > > > ------------------------------------------------------------------------- > This SF.Net email is sponsored by the Moblin Your Move Developer's challenge > Build the coolest Linux based applications with Moblin SDK & win great prizes > Grand prize is a trip for two to an Open Source event anywhere in the world > http://moblin-contest.org/redirect.php?banner_id=100&url=/ > _______________________________________________ > Rlib-devel mailing list > Rli...@li... > https://lists.sourceforge.net/lists/listinfo/rlib-devel |
From: Zoltan B. <zb...@du...> - 2008-08-26 10:52:44
Attachments:
13-RLIB_FORMAT_XML-gone.diff
|
Hi, this change makes the Python binding uncompilable. Patch is attached. When the XML output format is introduced, this patch has to be reverted. Also, because of the rlib.i change the bindings has to be re-generated in the CVS. Best regards, Zoltán Böszörményi Bob Doan írta: > We have plans to introduce an XML output, but we can take it out for > now. We'll do it post 2.0 > > I removed it an did a commit. > > - Bob > > On Fri, 2008-08-15 at 14:57 +0200, Zoltan Boszormenyi wrote: > >> Hi, >> >> another one, now it's a bit more serious, not fixable by a one-liner. >> It started out with an observation: >> * rlib_set_output_format_from_text() matches the passed-in string and >> if the string doesn't match to any known format string, >> TXT is assumed and r->format is set accordingly. >> * rlib_set_output_format() accepts any number as format indicator. >> this seems to be a bug by itself. >> >> I think there is an unintentional mixup in the defines. >> >> #define RLIB_CONTENT_TYPE_ERROR -1 >> #define RLIB_CONTENT_TYPE_PDF 1 >> #define RLIB_CONTENT_TYPE_HTML 2 >> #define RLIB_CONTENT_TYPE_TXT 3 >> #define RLIB_CONTENT_TYPE_CSV 4 >> >> #define RLIB_FORMAT_PDF 1 >> #define RLIB_FORMAT_HTML 2 >> #define RLIB_FORMAT_TXT 3 >> #define RLIB_FORMAT_CSV 4 >> #define RLIB_FORMAT_XML 5 >> >> And look at the usage patterns of r->format: >> >> rlib_make_report() uses r->format in a multi-conditional if() where >> the following output formats are handled explicitely: HTML, TXT, CSV. >> The last else (if all else fails) assumes PDF output is given. >> r->format is matched against RLIB_FORMAT_* here. >> RLIB_FORMAT_XML is not handled, rlib_xml_new_output_filter() >> does not exist. >> >> rlib_get_content_type_as_text() matches r->format against >> RLIB_CONTENT_TYPE_*. Also, the matching order is different >> from rlib_make_report(). PDF, CSV and HTML is explicitely tested, >> if all else fails TXT is assumed. >> >> Now, consider someone uses: >> >> rlib_set_output_format(RLIB_FORMAT_XML); >> >> It's valid reading only the API headers. But the result is unexpected: >> >> - rlib_execute() generates a PDF report >> - rlib_get_content_type_as_text() returns the content of >> RLIB_WEB_CONTENT_TYPE_TEXT with the proper charset >> >> So, this part needs rethinking. I think you need to decide which >> part of the defines has to be deprecated deleted and use the other >> set of the defines exclusively in the sources. Also, were there any >> plans to introduce rlib_xml_new_output_filter()? Or only the >> input filter as it exists now? >> >> Best regards, >> Zoltán Böszörményi >> >> Zoltan Boszormenyi írta: >> >>> Hi, >>> >>> another question. There's two difference between >>> rlib_add_query_pointer_as() and rlib_add_query_as(): >>> >>> - The "sql" parameter string is strdup()ed by rlib_add_query_as() but >>> not by rlib_add_query_pointer_as(). >>> I guess it's intentional, that's why there's a distinction at all. >>> >>> - rlib_add_query_as() returns an error if "input_source" was not yet >>> defined as an input source by one of the rlib_add_datasource_*() calls. >>> But rlib_add_query_pointer_as() doesn't. And there's not a single C >>> source >>> under libsrc where this is rechecked later. This seems to be a bug, >>> fix is attached. >>> >>> Best regards, >>> Zoltán Böszörményi >>> >>> Zoltan Boszormenyi írta: >>> >>> >>>> Hi, >>>> >>>> I was reviewing the function reference and crosschecking it >>>> with the source. Some notes: >>>> I think the source mixes up bitwise AND and logical AND. >>>> * && works on expressions of the same type: >>>> NUMBER && NUMBER (and performs logical AND) >>>> STRING && STRING returns TRUE if both STRINGs are non-NULL >>>> DATE && DATE would return TRUE always by intention >>>> but there's a missing "return TRUE;" in the code, causing >>>> double freeing. >>>> Fix is attached. >>>> * & works on NUMBERs only and performs bitwise or binary AND >>>> but the naming in the source labels it as "logical AND" >>>> I don't intend to change the naming in the source but it's good to know. >>>> The wiki documentation lacked bitwise AND up to now. >>>> Also, some others are also missing: >>>> * N^M, a.k.a. power(N, M) >>>> * chgdateof() >>>> * dtosf() >>>> >>>> Best regards, >>>> Zoltán Böszörményi >>>> >>>> Bob Doan írta: >>>> >>>> >>>> >>>>> Hi Zoltan, >>>>> >>>>> All patches have been applied. >>>>> >>>>> We're ready for the next round :) >>>>> >>>>> - Bob >>>>> >>>>> On Mon, 2008-08-11 at 15:30 +0200, Zoltan Boszormenyi wrote: >>>>> >>>>> >>>>> >>>>> >>>>>> Hi, >>>>>> >>>>>> here are the patches that make RLIB compile on Windows. >>>>>> The patches are split up in a way to contain only one fix. >>>>>> >>>>>> There's one thing that's missing though, namely PHP. >>>>>> PHP on Windows absolutely requires MSVC, the PHP/Win >>>>>> distribution(s) doesn't even contain php.h, etc., only the stub >>>>>> library called php5ts.lib to make it possible to link with php5ts.dll. >>>>>> Making a Zend extension under Windows starts with compiling >>>>>> PHP from source, it seems... >>>>>> >>>>>> Best regards, >>>>>> Zoltán Böszörményi >>>>>> >>>>>> ------------------------------------------------------------------------- >>>>>> This SF.Net email is sponsored by the Moblin Your Move Developer's challenge >>>>>> Build the coolest Linux based applications with Moblin SDK & win great prizes >>>>>> Grand prize is a trip for two to an Open Source event anywhere in the world >>>>>> http://moblin-contest.org/redirect.php?banner_id=100&url=/ >>>>>> _______________________________________________ Rlib-devel mailing list Rli...@li... https://lists.sourceforge.net/lists/listinfo/rlib-devel >>>>>> >>>>>> >>>>>> >>>>>> >>>>> ------------------------------------------------------------------------- >>>>> This SF.Net email is sponsored by the Moblin Your Move Developer's challenge >>>>> Build the coolest Linux based applications with Moblin SDK & win great prizes >>>>> Grand prize is a trip for two to an Open Source event anywhere in the world >>>>> http://moblin-contest.org/redirect.php?banner_id=100&url=/ >>>>> _______________________________________________ >>>>> Rlib-devel mailing list >>>>> Rli...@li... >>>>> https://lists.sourceforge.net/lists/listinfo/rlib-devel >>>>> >>>>> >>>>> >>>>> >>>> >>>> ------------------------------------------------------------------------ >>>> >>>> ------------------------------------------------------------------------- >>>> This SF.Net email is sponsored by the Moblin Your Move Developer's challenge >>>> Build the coolest Linux based applications with Moblin SDK & win great prizes >>>> Grand prize is a trip for two to an Open Source event anywhere in the world >>>> http://moblin-contest.org/redirect.php?banner_id=100&url=/ >>>> ------------------------------------------------------------------------ >>>> >>>> _______________________________________________ >>>> Rlib-devel mailing list >>>> Rli...@li... >>>> https://lists.sourceforge.net/lists/listinfo/rlib-devel >>>> >>>> >>> >>> ------------------------------------------------------------------------ >>> >>> ------------------------------------------------------------------------- >>> This SF.Net email is sponsored by the Moblin Your Move Developer's challenge >>> Build the coolest Linux based applications with Moblin SDK & win great prizes >>> Grand prize is a trip for two to an Open Source event anywhere in the world >>> http://moblin-contest.org/redirect.php?banner_id=100&url=/ >>> ------------------------------------------------------------------------ >>> >>> _______________________________________________ >>> Rlib-devel mailing list >>> Rli...@li... >>> https://lists.sourceforge.net/lists/listinfo/rlib-devel >>> >> ------------------------------------------------------------------------- >> This SF.Net email is sponsored by the Moblin Your Move Developer's challenge >> Build the coolest Linux based applications with Moblin SDK & win great prizes >> Grand prize is a trip for two to an Open Source event anywhere in the world >> http://moblin-contest.org/redirect.php?banner_id=100&url=/ >> _______________________________________________ >> Rlib-devel mailing list >> Rli...@li... >> https://lists.sourceforge.net/lists/listinfo/rlib-devel >> > > > ------------------------------------------------------------------------- > This SF.Net email is sponsored by the Moblin Your Move Developer's challenge > Build the coolest Linux based applications with Moblin SDK & win great prizes > Grand prize is a trip for two to an Open Source event anywhere in the world > http://moblin-contest.org/redirect.php?banner_id=100&url=/ > _______________________________________________ > Rlib-devel mailing list > Rli...@li... > https://lists.sourceforge.net/lists/listinfo/rlib-devel > |
From: Bob D. <bd...@si...> - 2008-09-03 21:16:26
|
Applied! On Tue, 2008-08-26 at 12:52 +0200, Zoltan Boszormenyi wrote: > Hi, > > this change makes the Python binding uncompilable. > Patch is attached. When the XML output format is > introduced, this patch has to be reverted. > > Also, because of the rlib.i change the bindings has to be > re-generated in the CVS. > > Best regards, > Zoltán Böszörményi > > Bob Doan írta: > > We have plans to introduce an XML output, but we can take it out for > > now. We'll do it post 2.0 > > > > I removed it an did a commit. > > > > - Bob > > > > On Fri, 2008-08-15 at 14:57 +0200, Zoltan Boszormenyi wrote: > > > >> Hi, > >> > >> another one, now it's a bit more serious, not fixable by a one-liner. > >> It started out with an observation: > >> * rlib_set_output_format_from_text() matches the passed-in string and > >> if the string doesn't match to any known format string, > >> TXT is assumed and r->format is set accordingly. > >> * rlib_set_output_format() accepts any number as format indicator. > >> this seems to be a bug by itself. > >> > >> I think there is an unintentional mixup in the defines. > >> > >> #define RLIB_CONTENT_TYPE_ERROR -1 > >> #define RLIB_CONTENT_TYPE_PDF 1 > >> #define RLIB_CONTENT_TYPE_HTML 2 > >> #define RLIB_CONTENT_TYPE_TXT 3 > >> #define RLIB_CONTENT_TYPE_CSV 4 > >> > >> #define RLIB_FORMAT_PDF 1 > >> #define RLIB_FORMAT_HTML 2 > >> #define RLIB_FORMAT_TXT 3 > >> #define RLIB_FORMAT_CSV 4 > >> #define RLIB_FORMAT_XML 5 > >> > >> And look at the usage patterns of r->format: > >> > >> rlib_make_report() uses r->format in a multi-conditional if() where > >> the following output formats are handled explicitely: HTML, TXT, CSV. > >> The last else (if all else fails) assumes PDF output is given. > >> r->format is matched against RLIB_FORMAT_* here. > >> RLIB_FORMAT_XML is not handled, rlib_xml_new_output_filter() > >> does not exist. > >> > >> rlib_get_content_type_as_text() matches r->format against > >> RLIB_CONTENT_TYPE_*. Also, the matching order is different > >> from rlib_make_report(). PDF, CSV and HTML is explicitely tested, > >> if all else fails TXT is assumed. > >> > >> Now, consider someone uses: > >> > >> rlib_set_output_format(RLIB_FORMAT_XML); > >> > >> It's valid reading only the API headers. But the result is unexpected: > >> > >> - rlib_execute() generates a PDF report > >> - rlib_get_content_type_as_text() returns the content of > >> RLIB_WEB_CONTENT_TYPE_TEXT with the proper charset > >> > >> So, this part needs rethinking. I think you need to decide which > >> part of the defines has to be deprecated deleted and use the other > >> set of the defines exclusively in the sources. Also, were there any > >> plans to introduce rlib_xml_new_output_filter()? Or only the > >> input filter as it exists now? > >> > >> Best regards, > >> Zoltán Böszörményi > >> > >> Zoltan Boszormenyi írta: > >> > >>> Hi, > >>> > >>> another question. There's two difference between > >>> rlib_add_query_pointer_as() and rlib_add_query_as(): > >>> > >>> - The "sql" parameter string is strdup()ed by rlib_add_query_as() but > >>> not by rlib_add_query_pointer_as(). > >>> I guess it's intentional, that's why there's a distinction at all. > >>> > >>> - rlib_add_query_as() returns an error if "input_source" was not yet > >>> defined as an input source by one of the rlib_add_datasource_*() calls. > >>> But rlib_add_query_pointer_as() doesn't. And there's not a single C > >>> source > >>> under libsrc where this is rechecked later. This seems to be a bug, > >>> fix is attached. > >>> > >>> Best regards, > >>> Zoltán Böszörményi > >>> > >>> Zoltan Boszormenyi írta: > >>> > >>> > >>>> Hi, > >>>> > >>>> I was reviewing the function reference and crosschecking it > >>>> with the source. Some notes: > >>>> I think the source mixes up bitwise AND and logical AND. > >>>> * && works on expressions of the same type: > >>>> NUMBER && NUMBER (and performs logical AND) > >>>> STRING && STRING returns TRUE if both STRINGs are non-NULL > >>>> DATE && DATE would return TRUE always by intention > >>>> but there's a missing "return TRUE;" in the code, causing > >>>> double freeing. > >>>> Fix is attached. > >>>> * & works on NUMBERs only and performs bitwise or binary AND > >>>> but the naming in the source labels it as "logical AND" > >>>> I don't intend to change the naming in the source but it's good to know. > >>>> The wiki documentation lacked bitwise AND up to now. > >>>> Also, some others are also missing: > >>>> * N^M, a.k.a. power(N, M) > >>>> * chgdateof() > >>>> * dtosf() > >>>> > >>>> Best regards, > >>>> Zoltán Böszörményi > >>>> > >>>> Bob Doan írta: > >>>> > >>>> > >>>> > >>>>> Hi Zoltan, > >>>>> > >>>>> All patches have been applied. > >>>>> > >>>>> We're ready for the next round :) > >>>>> > >>>>> - Bob > >>>>> > >>>>> On Mon, 2008-08-11 at 15:30 +0200, Zoltan Boszormenyi wrote: > >>>>> > >>>>> > >>>>> > >>>>> > >>>>>> Hi, > >>>>>> > >>>>>> here are the patches that make RLIB compile on Windows. > >>>>>> The patches are split up in a way to contain only one fix. > >>>>>> > >>>>>> There's one thing that's missing though, namely PHP. > >>>>>> PHP on Windows absolutely requires MSVC, the PHP/Win > >>>>>> distribution(s) doesn't even contain php.h, etc., only the stub > >>>>>> library called php5ts.lib to make it possible to link with php5ts.dll. > >>>>>> Making a Zend extension under Windows starts with compiling > >>>>>> PHP from source, it seems... > >>>>>> > >>>>>> Best regards, > >>>>>> Zoltán Böszörményi > >>>>>> > >>>>>> ------------------------------------------------------------------------- > >>>>>> This SF.Net email is sponsored by the Moblin Your Move Developer's challenge > >>>>>> Build the coolest Linux based applications with Moblin SDK & win great prizes > >>>>>> Grand prize is a trip for two to an Open Source event anywhere in the world > >>>>>> http://moblin-contest.org/redirect.php?banner_id=100&url=/ > >>>>>> _______________________________________________ Rlib-devel mailing list Rli...@li... https://lists.sourceforge.net/lists/listinfo/rlib-devel > >>>>>> > >>>>>> > >>>>>> > >>>>>> > >>>>> ------------------------------------------------------------------------- > >>>>> This SF.Net email is sponsored by the Moblin Your Move Developer's challenge > >>>>> Build the coolest Linux based applications with Moblin SDK & win great prizes > >>>>> Grand prize is a trip for two to an Open Source event anywhere in the world > >>>>> http://moblin-contest.org/redirect.php?banner_id=100&url=/ > >>>>> _______________________________________________ > >>>>> Rlib-devel mailing list > >>>>> Rli...@li... > >>>>> https://lists.sourceforge.net/lists/listinfo/rlib-devel > >>>>> > >>>>> > >>>>> > >>>>> > >>>> > >>>> ------------------------------------------------------------------------ > >>>> > >>>> ------------------------------------------------------------------------- > >>>> This SF.Net email is sponsored by the Moblin Your Move Developer's challenge > >>>> Build the coolest Linux based applications with Moblin SDK & win great prizes > >>>> Grand prize is a trip for two to an Open Source event anywhere in the world > >>>> http://moblin-contest.org/redirect.php?banner_id=100&url=/ > >>>> ------------------------------------------------------------------------ > >>>> > >>>> _______________________________________________ > >>>> Rlib-devel mailing list > >>>> Rli...@li... > >>>> https://lists.sourceforge.net/lists/listinfo/rlib-devel > >>>> > >>>> > >>> > >>> ------------------------------------------------------------------------ > >>> > >>> ------------------------------------------------------------------------- > >>> This SF.Net email is sponsored by the Moblin Your Move Developer's challenge > >>> Build the coolest Linux based applications with Moblin SDK & win great prizes > >>> Grand prize is a trip for two to an Open Source event anywhere in the world > >>> http://moblin-contest.org/redirect.php?banner_id=100&url=/ > >>> ------------------------------------------------------------------------ > >>> > >>> _______________________________________________ > >>> Rlib-devel mailing list > >>> Rli...@li... > >>> https://lists.sourceforge.net/lists/listinfo/rlib-devel > >>> > >> ------------------------------------------------------------------------- > >> This SF.Net email is sponsored by the Moblin Your Move Developer's challenge > >> Build the coolest Linux based applications with Moblin SDK & win great prizes > >> Grand prize is a trip for two to an Open Source event anywhere in the world > >> http://moblin-contest.org/redirect.php?banner_id=100&url=/ > >> _______________________________________________ > >> Rlib-devel mailing list > >> Rli...@li... > >> https://lists.sourceforge.net/lists/listinfo/rlib-devel > >> > > > > > > ------------------------------------------------------------------------- > > This SF.Net email is sponsored by the Moblin Your Move Developer's challenge > > Build the coolest Linux based applications with Moblin SDK & win great prizes > > Grand prize is a trip for two to an Open Source event anywhere in the world > > http://moblin-contest.org/redirect.php?banner_id=100&url=/ > > _______________________________________________ > > Rlib-devel mailing list > > Rli...@li... > > https://lists.sourceforge.net/lists/listinfo/rlib-devel > > > |
From: Bob D. <bd...@si...> - 2008-09-03 21:18:30
|
Is there a way to install all of GLIB and friends? Or is this not necessary some how? On Tue, 2008-08-26 at 20:39 +0200, Zoltan Boszormenyi wrote: > Hi, > > I think one final patch is needed: NSIS installer bits. :-) > rlibsetup.exe created with the installer source file and out of the > with the current CVS plus my last fix will be sent in private. > To compile the installer successfully, php_rlib.dll must be copied > to bindings/php and also the manually created libr.lib (out of > libr.def, described in the PHP installation part in the Wiki) has to > be copied to libsrc. > > Best regards, > Zoltán Böszörményi > > ------------------------------------------------------------------------- > This SF.Net email is sponsored by the Moblin Your Move Developer's challenge > Build the coolest Linux based applications with Moblin SDK & win great prizes > Grand prize is a trip for two to an Open Source event anywhere in the world > http://moblin-contest.org/redirect.php?banner_id=100&url=/ > _______________________________________________ Rlib-devel mailing list Rli...@li... https://lists.sourceforge.net/lists/listinfo/rlib-devel |
From: Bob D. <bd...@si...> - 2008-09-03 21:20:52
|
Hi, At a glance it looks like just the data sources and examples are missing. On Mon, 2008-09-01 at 18:44 +0200, Zoltan Boszormenyi wrote: > Hi, > > I think I finalized the documentation. > The following documentation links are now obsolete > on the "Documentation" TOC page since they are documented > under the "Report XML Definition" page: > - Graphs > - Gantt charts > But I don't know how to delete a page in the wiki. > Also, some examples might also need to be added to the wiki. > > Best regards, > Zoltán > > > ------------------------------------------------------------------------- > This SF.Net email is sponsored by the Moblin Your Move Developer's challenge > Build the coolest Linux based applications with Moblin SDK & win great prizes > Grand prize is a trip for two to an Open Source event anywhere in the world > http://moblin-contest.org/redirect.php?banner_id=100&url=/ > _______________________________________________ > Rlib-devel mailing list > Rli...@li... > https://lists.sourceforge.net/lists/listinfo/rlib-devel |
From: Zoltan B. <zb...@du...> - 2008-09-14 09:34:52
|
Hi, fixed. :-) Best regards, Zoltán Bob Doan írta: > Hi, > > At a glance it looks like just the data sources and examples are > missing. > > On Mon, 2008-09-01 at 18:44 +0200, Zoltan Boszormenyi wrote: > >> Hi, >> >> I think I finalized the documentation. >> The following documentation links are now obsolete >> on the "Documentation" TOC page since they are documented >> under the "Report XML Definition" page: >> - Graphs >> - Gantt charts >> But I don't know how to delete a page in the wiki. >> Also, some examples might also need to be added to the wiki. >> >> Best regards, >> Zoltán >> >> >> ------------------------------------------------------------------------- >> This SF.Net email is sponsored by the Moblin Your Move Developer's challenge >> Build the coolest Linux based applications with Moblin SDK & win great prizes >> Grand prize is a trip for two to an Open Source event anywhere in the world >> http://moblin-contest.org/redirect.php?banner_id=100&url=/ >> _______________________________________________ >> Rlib-devel mailing list >> Rli...@li... >> https://lists.sourceforge.net/lists/listinfo/rlib-devel >> > > > ------------------------------------------------------------------------- > This SF.Net email is sponsored by the Moblin Your Move Developer's challenge > Build the coolest Linux based applications with Moblin SDK & win great prizes > Grand prize is a trip for two to an Open Source event anywhere in the world > http://moblin-contest.org/redirect.php?banner_id=100&url=/ > _______________________________________________ > Rlib-devel mailing list > Rli...@li... > https://lists.sourceforge.net/lists/listinfo/rlib-devel > |
From: Bob D. <bd...@si...> - 2008-08-15 20:04:15
|
Hi, Applied! This is the correct fix. We have this function because we have input sources that don't take queries, but rather pointers to data objects. Thanks - bob On Fri, 2008-08-15 at 13:37 +0200, Zoltan Boszormenyi wrote: > Hi, > > another question. There's two difference between > rlib_add_query_pointer_as() and rlib_add_query_as(): > > - The "sql" parameter string is strdup()ed by rlib_add_query_as() but > not by rlib_add_query_pointer_as(). > I guess it's intentional, that's why there's a distinction at all. > > - rlib_add_query_as() returns an error if "input_source" was not yet > defined as an input source by one of the rlib_add_datasource_*() calls. > But rlib_add_query_pointer_as() doesn't. And there's not a single C > source > under libsrc where this is rechecked later. This seems to be a bug, > fix is attached. > > Best regards, > Zoltán Böszörményi > > Zoltan Boszormenyi írta: > > Hi, > > > > I was reviewing the function reference and crosschecking it > > with the source. Some notes: > > I think the source mixes up bitwise AND and logical AND. > > * && works on expressions of the same type: > > NUMBER && NUMBER (and performs logical AND) > > STRING && STRING returns TRUE if both STRINGs are non-NULL > > DATE && DATE would return TRUE always by intention > > but there's a missing "return TRUE;" in the code, causing > > double freeing. > > Fix is attached. > > * & works on NUMBERs only and performs bitwise or binary AND > > but the naming in the source labels it as "logical AND" > > I don't intend to change the naming in the source but it's good to know. > > The wiki documentation lacked bitwise AND up to now. > > Also, some others are also missing: > > * N^M, a.k.a. power(N, M) > > * chgdateof() > > * dtosf() > > > > Best regards, > > Zoltán Böszörményi > > > > Bob Doan írta: > > > >> Hi Zoltan, > >> > >> All patches have been applied. > >> > >> We're ready for the next round :) > >> > >> - Bob > >> > >> On Mon, 2008-08-11 at 15:30 +0200, Zoltan Boszormenyi wrote: > >> > >> > >>> Hi, > >>> > >>> here are the patches that make RLIB compile on Windows. > >>> The patches are split up in a way to contain only one fix. > >>> > >>> There's one thing that's missing though, namely PHP. > >>> PHP on Windows absolutely requires MSVC, the PHP/Win > >>> distribution(s) doesn't even contain php.h, etc., only the stub > >>> library called php5ts.lib to make it possible to link with php5ts.dll. > >>> Making a Zend extension under Windows starts with compiling > >>> PHP from source, it seems... > >>> > >>> Best regards, > >>> Zoltán Böszörményi > >>> > >>> ------------------------------------------------------------------------- > >>> This SF.Net email is sponsored by the Moblin Your Move Developer's challenge > >>> Build the coolest Linux based applications with Moblin SDK & win great prizes > >>> Grand prize is a trip for two to an Open Source event anywhere in the world > >>> http://moblin-contest.org/redirect.php?banner_id=100&url=/ > >>> _______________________________________________ Rlib-devel mailing list Rli...@li... https://lists.sourceforge.net/lists/listinfo/rlib-devel > >>> > >>> > >> ------------------------------------------------------------------------- > >> This SF.Net email is sponsored by the Moblin Your Move Developer's challenge > >> Build the coolest Linux based applications with Moblin SDK & win great prizes > >> Grand prize is a trip for two to an Open Source event anywhere in the world > >> http://moblin-contest.org/redirect.php?banner_id=100&url=/ > >> _______________________________________________ > >> Rlib-devel mailing list > >> Rli...@li... > >> https://lists.sourceforge.net/lists/listinfo/rlib-devel > >> > >> > > > > > > ------------------------------------------------------------------------ > > > > ------------------------------------------------------------------------- > > This SF.Net email is sponsored by the Moblin Your Move Developer's challenge > > Build the coolest Linux based applications with Moblin SDK & win great prizes > > Grand prize is a trip for two to an Open Source event anywhere in the world > > http://moblin-contest.org/redirect.php?banner_id=100&url=/ > > ------------------------------------------------------------------------ > > > > _______________________________________________ > > Rlib-devel mailing list > > Rli...@li... > > https://lists.sourceforge.net/lists/listinfo/rlib-devel > |
From: Bob D. <bd...@si...> - 2008-08-15 19:57:42
|
Hi, I applied the patch. Paul (SICOM) -> Can you investigate the bitwise/logical AND mixup? Thanks! - Bob On Fri, 2008-08-15 at 10:45 +0200, Zoltan Boszormenyi wrote: > Hi, > > I was reviewing the function reference and crosschecking it > with the source. Some notes: > I think the source mixes up bitwise AND and logical AND. > * && works on expressions of the same type: > NUMBER && NUMBER (and performs logical AND) > STRING && STRING returns TRUE if both STRINGs are non-NULL > DATE && DATE would return TRUE always by intention > but there's a missing "return TRUE;" in the code, causing > double freeing. > Fix is attached. > * & works on NUMBERs only and performs bitwise or binary AND > but the naming in the source labels it as "logical AND" > I don't intend to change the naming in the source but it's good to know. > The wiki documentation lacked bitwise AND up to now. > Also, some others are also missing: > * N^M, a.k.a. power(N, M) > * chgdateof() > * dtosf() > > Best regards, > Zoltán Böszörményi > > Bob Doan írta: > > Hi Zoltan, > > > > All patches have been applied. > > > > We're ready for the next round :) > > > > - Bob > > > > On Mon, 2008-08-11 at 15:30 +0200, Zoltan Boszormenyi wrote: > > > >> Hi, > >> > >> here are the patches that make RLIB compile on Windows. > >> The patches are split up in a way to contain only one fix. > >> > >> There's one thing that's missing though, namely PHP. > >> PHP on Windows absolutely requires MSVC, the PHP/Win > >> distribution(s) doesn't even contain php.h, etc., only the stub > >> library called php5ts.lib to make it possible to link with php5ts.dll. > >> Making a Zend extension under Windows starts with compiling > >> PHP from source, it seems... > >> > >> Best regards, > >> Zoltán Böszörményi > >> > >> ------------------------------------------------------------------------- > >> This SF.Net email is sponsored by the Moblin Your Move Developer's challenge > >> Build the coolest Linux based applications with Moblin SDK & win great prizes > >> Grand prize is a trip for two to an Open Source event anywhere in the world > >> http://moblin-contest.org/redirect.php?banner_id=100&url=/ > >> _______________________________________________ Rlib-devel mailing list Rli...@li... https://lists.sourceforge.net/lists/listinfo/rlib-devel > >> > > > > > > ------------------------------------------------------------------------- > > This SF.Net email is sponsored by the Moblin Your Move Developer's challenge > > Build the coolest Linux based applications with Moblin SDK & win great prizes > > Grand prize is a trip for two to an Open Source event anywhere in the world > > http://moblin-contest.org/redirect.php?banner_id=100&url=/ > > _______________________________________________ > > Rlib-devel mailing list > > Rli...@li... > > https://lists.sourceforge.net/lists/listinfo/rlib-devel > > > |
From: Zoltan B. <zb...@du...> - 2008-08-15 20:27:53
|
Hi, also, there's a small asymmetricity with respect to logical/bitwise operators. There are &&, & and || but there's no | (bitwise OR). Best regards, Zoltán Böszörményi Bob Doan írta: > Hi, > > I applied the patch. > > Paul (SICOM) -> Can you investigate the bitwise/logical AND mixup? > > Thanks! > > - Bob > > On Fri, 2008-08-15 at 10:45 +0200, Zoltan Boszormenyi wrote: > >> Hi, >> >> I was reviewing the function reference and crosschecking it >> with the source. Some notes: >> I think the source mixes up bitwise AND and logical AND. >> * && works on expressions of the same type: >> NUMBER && NUMBER (and performs logical AND) >> STRING && STRING returns TRUE if both STRINGs are non-NULL >> DATE && DATE would return TRUE always by intention >> but there's a missing "return TRUE;" in the code, causing >> double freeing. >> Fix is attached. >> * & works on NUMBERs only and performs bitwise or binary AND >> but the naming in the source labels it as "logical AND" >> I don't intend to change the naming in the source but it's good to know. >> The wiki documentation lacked bitwise AND up to now. >> Also, some others are also missing: >> * N^M, a.k.a. power(N, M) >> * chgdateof() >> * dtosf() >> >> Best regards, >> Zoltán Böszörményi >> >> Bob Doan írta: >> >>> Hi Zoltan, >>> >>> All patches have been applied. >>> >>> We're ready for the next round :) >>> >>> - Bob >>> >>> On Mon, 2008-08-11 at 15:30 +0200, Zoltan Boszormenyi wrote: >>> >>> >>>> Hi, >>>> >>>> here are the patches that make RLIB compile on Windows. >>>> The patches are split up in a way to contain only one fix. >>>> >>>> There's one thing that's missing though, namely PHP. >>>> PHP on Windows absolutely requires MSVC, the PHP/Win >>>> distribution(s) doesn't even contain php.h, etc., only the stub >>>> library called php5ts.lib to make it possible to link with php5ts.dll. >>>> Making a Zend extension under Windows starts with compiling >>>> PHP from source, it seems... >>>> >>>> Best regards, >>>> Zoltán Böszörményi >>>> >>>> ------------------------------------------------------------------------- >>>> This SF.Net email is sponsored by the Moblin Your Move Developer's challenge >>>> Build the coolest Linux based applications with Moblin SDK & win great prizes >>>> Grand prize is a trip for two to an Open Source event anywhere in the world >>>> http://moblin-contest.org/redirect.php?banner_id=100&url=/ >>>> _______________________________________________ Rlib-devel mailing list Rli...@li... https://lists.sourceforge.net/lists/listinfo/rlib-devel >>>> >>>> >>> ------------------------------------------------------------------------- >>> This SF.Net email is sponsored by the Moblin Your Move Developer's challenge >>> Build the coolest Linux based applications with Moblin SDK & win great prizes >>> Grand prize is a trip for two to an Open Source event anywhere in the world >>> http://moblin-contest.org/redirect.php?banner_id=100&url=/ >>> _______________________________________________ >>> Rlib-devel mailing list >>> Rli...@li... >>> https://lists.sourceforge.net/lists/listinfo/rlib-devel >>> >>> > > > ------------------------------------------------------------------------- > This SF.Net email is sponsored by the Moblin Your Move Developer's challenge > Build the coolest Linux based applications with Moblin SDK & win great prizes > Grand prize is a trip for two to an Open Source event anywhere in the world > http://moblin-contest.org/redirect.php?banner_id=100&url=/ > _______________________________________________ > Rlib-devel mailing list > Rli...@li... > https://lists.sourceforge.net/lists/listinfo/rlib-devel > |
From: Zoltan B. <zb...@du...> - 2008-08-21 12:33:57
Attachments:
11-graphing-typo.diff
|
Hi, writing the documentation about the XML features, I came across this typo in the code in the graphing part. Best regards, Zoltán Böszörményi |
From: Zoltan B. <zb...@du...> - 2008-09-29 15:17:52
Attachments:
15-api-fix.diff
|
Hi, we came across a problem in the RLIB/ODBC interaction recently that turned out to be a bug in psqlODBC. When a query is not executable because of a malformed query or for some other reason (in my case a numeric conversion was overflowing for a record) then my app crashed calling rlib_execute() when I used an ODBC datasource. The last call that crashed according to GDB was SQLGetDiagRec() inside psqlODBC. This bug was apparently fixed in version 08.03.0300 and it let me test further. RLIB correctly reported on the console that it was unable to execute the query but then it crashed anyway in an strcmp() in line 607 of reportgen.c. The attached patch fixes this issue and now RLIB reports the erroneous query on the console and then all the missing fields for the report. It doesn't crash now. Best regards, Zoltán Böszörményi |
From: Bob D. <bd...@si...> - 2008-09-29 20:12:46
|
Applied Thanks! On Mon, 2008-09-29 at 17:00 +0200, Zoltan Boszormenyi wrote: > Hi, > > we came across a problem in the RLIB/ODBC interaction > recently that turned out to be a bug in psqlODBC. > When a query is not executable because of a malformed query > or for some other reason (in my case a numeric conversion > was overflowing for a record) then my app crashed calling > rlib_execute() when I used an ODBC datasource. The last call > that crashed according to GDB was SQLGetDiagRec() inside > psqlODBC. This bug was apparently fixed in version 08.03.0300 > and it let me test further. RLIB correctly reported on the console > that it was unable to execute the query but then it crashed anyway > in an strcmp() in line 607 of reportgen.c. The attached patch fixes > this issue and now RLIB reports the erroneous query on the > console and then all the missing fields for the report. > It doesn't crash now. > > Best regards, > Zoltán Böszörményi > |
From: Zoltan B. <zb...@du...> - 2009-02-03 17:21:56
Attachments:
rlib-1.3.8-printf-lld-win32.patch
|
Hi, this seems to be the last thing needed for Windows, so it not only compiles but also produces correct results. :-) While using a report that summed up large numbers and the result was larger than 2^31, I got negative results, but only if the app and RLIB was running on Windows. Under Linux, it worked correctly. It turned out the problem is that %lld is interpreted as %ld under Windows. Browsing through inttypes.h in MinGW revealed that the correct printf format is I64d for Windows. So, I fixed it by killing all "%lld" occurences and replaced them with the portable format string. I also killed the _64BIT_ definition in configure.in because it's not needed anymore. After recompiling RLIB with this patch I get correct results in Windows. Best regards, Zoltán Böszörményi Bob Doan írta: > Applied > > Thanks! > > On Mon, 2008-09-29 at 17:00 +0200, Zoltan Boszormenyi wrote: > >> Hi, >> >> we came across a problem in the RLIB/ODBC interaction >> recently that turned out to be a bug in psqlODBC. >> When a query is not executable because of a malformed query >> or for some other reason (in my case a numeric conversion >> was overflowing for a record) then my app crashed calling >> rlib_execute() when I used an ODBC datasource. The last call >> that crashed according to GDB was SQLGetDiagRec() inside >> psqlODBC. This bug was apparently fixed in version 08.03.0300 >> and it let me test further. RLIB correctly reported on the console >> that it was unable to execute the query but then it crashed anyway >> in an strcmp() in line 607 of reportgen.c. The attached patch fixes >> this issue and now RLIB reports the erroneous query on the >> console and then all the missing fields for the report. >> It doesn't crash now. >> >> Best regards, >> Zoltán Böszörményi >> >> > > > ------------------------------------------------------------------------- > This SF.Net email is sponsored by the Moblin Your Move Developer's challenge > Build the coolest Linux based applications with Moblin SDK & win great prizes > Grand prize is a trip for two to an Open Source event anywhere in the world > http://moblin-contest.org/redirect.php?banner_id=100&url=/ > _______________________________________________ > Rlib-devel mailing list > Rli...@li... > https://lists.sourceforge.net/lists/listinfo/rlib-devel > |
From: Zoltan B. <zb...@du...> - 2008-08-22 13:51:51
Attachments:
12-php-win32-fix.diff
|
Hi, I got around to find info about building the RLIB PHP binding in Windows. Here's a patch for correct compilation with ZTS=1 which is a requirement on PHP/Windows builds. The PHP extension building on Windows is a saga in itself, however I am not a PHP expert, so I cannot test it. The installation page contains the steps to reproduce the build. I send the compiled php_rlib.dll and the Visual Studio 2008 project in private. Best regards, Zoltán Böszörményi |
From: Bob D. <bd...@si...> - 2008-09-03 21:13:46
|
Applied On Fri, 2008-08-22 at 15:51 +0200, Zoltan Boszormenyi wrote: > Hi, > > I got around to find info about building the RLIB PHP binding > in Windows. Here's a patch for correct compilation with ZTS=1 > which is a requirement on PHP/Windows builds. The PHP extension > building on Windows is a saga in itself, however I am not a PHP expert, > so I cannot test it. The installation page contains the steps to reproduce > the build. > > I send the compiled php_rlib.dll and the Visual Studio 2008 project > in private. > > Best regards, > Zoltán Böszörményi > > ------------------------------------------------------------------------- > This SF.Net email is sponsored by the Moblin Your Move Developer's challenge > Build the coolest Linux based applications with Moblin SDK & win great prizes > Grand prize is a trip for two to an Open Source event anywhere in the world > http://moblin-contest.org/redirect.php?banner_id=100&url=/ > _______________________________________________ Rlib-devel mailing list Rli...@li... https://lists.sourceforge.net/lists/listinfo/rlib-devel |
From: Zoltan B. <zb...@du...> - 2008-08-26 18:40:01
Attachments:
14-installer.diff
|
Hi, I think one final patch is needed: NSIS installer bits. :-) rlibsetup.exe created with the installer source file and out of the with the current CVS plus my last fix will be sent in private. To compile the installer successfully, php_rlib.dll must be copied to bindings/php and also the manually created libr.lib (out of libr.def, described in the PHP installation part in the Wiki) has to be copied to libsrc. Best regards, Zoltán Böszörményi |
From: Zoltan B. <zb...@du...> - 2008-09-01 16:44:14
|
Hi, I think I finalized the documentation. The following documentation links are now obsolete on the "Documentation" TOC page since they are documented under the "Report XML Definition" page: - Graphs - Gantt charts But I don't know how to delete a page in the wiki. Also, some examples might also need to be added to the wiki. Best regards, Zoltán |
From: Zoltan B. <zb...@du...> - 2008-09-04 10:10:47
Attachments:
rlib.nsi
|
Hi, sorry, you are right. Here's the new rlib.nsi installer script. It now embeds the GD 2.0.33 and GTK+ 2.10.x installers and runs them in case they are not installed already. The installer got quite large (7+ MB) because of the embedded installers. I cannot send it in email, you can download it from here: http://www.cybertec.at/download/rlibsetup.exe The embedded GTK installer contains libxml2, too, and every needed dependencies. If you compile the script NSIS will look for the extra installers in ..\Prerequisites. Their download locations: http://gnuwin32.sourceforge.net/downlinks/gd.php http://sourceforge.net/project/showfiles.php?group_id=121075 Best regards, Zoltán Bob Doan írta: > Is there a way to install all of GLIB and friends? Or is this not > necessary some how? > > On Tue, 2008-08-26 at 20:39 +0200, Zoltan Boszormenyi wrote: > >> Hi, >> >> I think one final patch is needed: NSIS installer bits. :-) >> rlibsetup.exe created with the installer source file and out of the >> with the current CVS plus my last fix will be sent in private. >> To compile the installer successfully, php_rlib.dll must be copied >> to bindings/php and also the manually created libr.lib (out of >> libr.def, described in the PHP installation part in the Wiki) has to >> be copied to libsrc. >> >> Best regards, >> Zoltán Böszörményi >> >> ------------------------------------------------------------------------- >> This SF.Net email is sponsored by the Moblin Your Move Developer's challenge >> Build the coolest Linux based applications with Moblin SDK & win great prizes >> Grand prize is a trip for two to an Open Source event anywhere in the world >> http://moblin-contest.org/redirect.php?banner_id=100&url=/ >> _______________________________________________ Rlib-devel mailing list Rli...@li... https://lists.sourceforge.net/lists/listinfo/rlib-devel >> > > > ------------------------------------------------------------------------- > This SF.Net email is sponsored by the Moblin Your Move Developer's challenge > Build the coolest Linux based applications with Moblin SDK & win great prizes > Grand prize is a trip for two to an Open Source event anywhere in the world > http://moblin-contest.org/redirect.php?banner_id=100&url=/ > _______________________________________________ > Rlib-devel mailing list > Rli...@li... > https://lists.sourceforge.net/lists/listinfo/rlib-devel > |
From: Bob D. <bd...@si...> - 2008-09-04 18:37:37
|
Applied! On Thu, 2008-09-04 at 12:10 +0200, Zoltan Boszormenyi wrote: > Hi, > > sorry, you are right. Here's the new rlib.nsi installer script. > It now embeds the GD 2.0.33 and GTK+ 2.10.x installers > and runs them in case they are not installed already. > The installer got quite large (7+ MB) because of the > embedded installers. I cannot send it in email, you can download > it from here: http://www.cybertec.at/download/rlibsetup.exe > The embedded GTK installer contains libxml2, too, > and every needed dependencies. If you compile the script > NSIS will look for the extra installers in ..\Prerequisites. > Their download locations: > http://gnuwin32.sourceforge.net/downlinks/gd.php > http://sourceforge.net/project/showfiles.php?group_id=121075 > > Best regards, > Zoltán > > Bob Doan írta: > > Is there a way to install all of GLIB and friends? Or is this not > > necessary some how? > > > > On Tue, 2008-08-26 at 20:39 +0200, Zoltan Boszormenyi wrote: > > > >> Hi, > >> > >> I think one final patch is needed: NSIS installer bits. :-) > >> rlibsetup.exe created with the installer source file and out of the > >> with the current CVS plus my last fix will be sent in private. > >> To compile the installer successfully, php_rlib.dll must be copied > >> to bindings/php and also the manually created libr.lib (out of > >> libr.def, described in the PHP installation part in the Wiki) has to > >> be copied to libsrc. > >> > >> Best regards, > >> Zoltán Böszörményi > >> > >> ------------------------------------------------------------------------- > >> This SF.Net email is sponsored by the Moblin Your Move Developer's challenge > >> Build the coolest Linux based applications with Moblin SDK & win great prizes > >> Grand prize is a trip for two to an Open Source event anywhere in the world > >> http://moblin-contest.org/redirect.php?banner_id=100&url=/ > >> _______________________________________________ Rlib-devel mailing list Rli...@li... https://lists.sourceforge.net/lists/listinfo/rlib-devel > >> > > > > > > ------------------------------------------------------------------------- > > This SF.Net email is sponsored by the Moblin Your Move Developer's challenge > > Build the coolest Linux based applications with Moblin SDK & win great prizes > > Grand prize is a trip for two to an Open Source event anywhere in the world > > http://moblin-contest.org/redirect.php?banner_id=100&url=/ > > _______________________________________________ > > Rlib-devel mailing list > > Rli...@li... > > https://lists.sourceforge.net/lists/listinfo/rlib-devel > > > > plain text document attachment (rlib.nsi) > name "RLIB" > outFile "rlibsetup.exe" > > LicenseText "You must agree to this license before installing." > LicenseData "COPYING" > > InstallDir "$PROGRAMFILES\RLIB" > InstallDirRegKey HKEY_LOCAL_MACHINE "SOFTWARE\Sicom\RLIB" "" > DirText "Select the directory to install RLIB in:" > > InstType "Full" > InstType "Minimal" > > ComponentText "Select what you wish to install." > > Section "-Prerequisites" > > ReadRegStr $R1 HKLM Software\GnuWin32\Gd "InstallPath" > IfErrors nogd > goto gtk > nogd: > MessageBox MB_OK "Your system does not appear to have GD installed.$\n$\nPress OK to install it." > SetOutPath "$INSTDIR\Prerequisites" > File "..\Prerequisites\gd-2.0.33-1.exe" > ExecWait "$INSTDIR\Prerequisites\gd-2.0.33-1.exe" > > gtk: > ReadRegStr $R1 HKLM Software\GTK\2.0 "GLibVersion" > IfErrors nogtk > goto out > nogtk: > MessageBox MB_OK "Your system does not appear to have GTK+ 2.x installed.$\n$\nPress OK to install it." > SetOutPath "$INSTDIR\Prerequisites" > File "..\Prerequisites\gtk+-2.10.13-setup.exe" > ExecWait "$INSTDIR\Prerequisites\gtk+-2.10.13-setup.exe" > > out: > SectionEnd ; end of Prerequisites section > > Section "" ; (default, requried section) > SetOutPath "$INSTDIR" > file "rpdf\.libs\librpdf.dll" > file "libsrc\.libs\libr.dll" > file "inputs\odbc\.libs\libr-odbc.dll" > SectionEnd ; end of default section > > Section "Development files" > SectionIn 1 > SetOutPath "$INSTDIR\include" > file rpdf\rpdf.h > file libsrc\charencoder.h > file libsrc\datetime.h > file libsrc\pcode.h > file libsrc\rlib.h > file libsrc\rlib_input.h > file libsrc\util.h > file libsrc\value.h > SetOutPath "$INSTDIR\lib" > file libsrc\libr.def > file libsrc\libr.lib > SectionEnd > > section "Native MySQL input" > SectionIn 1 > setOutPath "$INSTDIR" > file inputs\mysql\.libs\libr-mysql.dll > sectionEnd > > section "Native PostgreSQL input" > SectionIn 1 > setOutPath "$INSTDIR" > file inputs\postgres\.libs\libr-postgres.dll > sectionEnd > > section "C# binding" > SectionIn 1 > setOutPath "$INSTDIR\csharp" > file bindings\csharp\.libs\librlibcsharp.dll > sectionEnd > > Section "Java binding" > SectionIn 1 > SetOutPath "$INSTDIR\java" > file bindings\java\.libs\librlibjava.dll > file src\examples\java\SWIGTYPE_p_f_p_rlib_p_void__int.java > file src\examples\java\SWIGTYPE_p_f_p_rlib_p_void__int.class > file src\examples\java\SWIGTYPE_p_rlib.java > file src\examples\java\SWIGTYPE_p_rlib.class > file src\examples\java\SWIGTYPE_p_void.java > file src\examples\java\SWIGTYPE_p_void.class > file src\examples\java\rlibJNI.java > file src\examples\java\rlibJNI.class > file src\examples\java\rlib.java > file src\examples\java\rlib.class > SectionEnd ; end of section 'java' > > Section "Perl binding" > SectionIn 1 > > ReadRegStr $R1 HKLM Software\Perl "BinDir" > IfErrors noperl > > DetailPrint "Found Perl at $R1" > > nsExec::ExecToStack '"$R1" "-e" "use Config; print $$Config{version};"' > Pop $R0 > Pop $R2 > > StrCpy $R3 "$R2" 5 > StrCmp "$R3" "5.10." getperllib noperl510 > > getperllib: > DetailPrint "Perl 5.10 found, good." > nsExec::ExecToStack '"$R1" "-e" "use Config; print $$Config{archlib};"' > Pop $R0 > Pop $R3 > StrCmp "$R0" "0" instperl noperl > DetailPrint "Perl 5.10 module directory is $R3" > > instperl: > Push "$R3" > goto out > > noperl510: > Push "$INSTDIR\perl" > DetailPrint "Perl 5.10.x not installed, found version $R2" > goto out > > noperl: > DetailPrint "Perl not installed" > Push "$INSTDIR\perl" > > out: > Pop $R3 > SetOutPath "$R3" > file bindings\interfaces\rlib.pm > SetOutPath "$R3\auto\rlib" > file bindings\perl\.libs\rlib.dll > WriteRegStr HKEY_LOCAL_MACHINE "SOFTWARE\Sicom\RLIB" "PerlDir" "$R3" > SectionEnd > > Section "PHP binding" > SectionIn 1 > ReadRegStr $R0 HKLM Software\PHP "InstallDir" > IfErrors nophp > > DetailPrint "PHP found in $R0" > Push "$R0\ext" > goto out > > nophp: > DetailPrint "PHP not found" > Push "$INSTDIR\php" > > out: > Pop $R1 > SetOutPath "$R1" > file bindings\php\php_rlib.dll > WriteRegStr HKEY_LOCAL_MACHINE "SOFTWARE\Sicom\RLIB" "PHPDir" "$R1" > SectionEnd > > Section "Python binding" > SectionIn 1 > nsExec::ExecToStack '"python" "--version"' > Pop $R0 > Pop $R1 > StrCmp "$R0" "0" checkpythonver nopython > > checkpythonver: > StrCpy $R2 "$R1" 11 > StrCmp "$R2" "Python 2.5." getsitepkgdir nopython25 > > getsitepkgdir: > DetailPrint "Python 2.5.x found, good" > SetOutPath "$INSTDIR" > file python.bat > nsExec::ExecToStack '"cmd" "/C" "$INSTDIR\python.bat"' > Pop $R0 > Pop $R3 > Delete "$INSTDIR\python.bat" > DetailPrint "Python module directory: $R3" > Push "$R3" > goto out > > nopython25: > DetailPrint "Python 2.5.x not found, found $R1" > Push "$INSTDIR\python" > goto out > > nopython: > DetailPrint "Python 2.5.x not found on $$PATH" > Push "$INSTDIR\python" > goto out > > out: > Pop $R3 > SetOutPath "$R3" > file bindings\python\.libs\rlibmodule.dll > file bindings\python\.libs\_rlib.dll > file bindings\interfaces\rlib.py > file bindings\interfaces\rlibcompat.py > WriteRegStr HKEY_LOCAL_MACHINE "SOFTWARE\Sicom\RLIB" "PythonDir" "$R3" > SectionEnd > > Section "-post" ; (post install section, happens last after any optional sections) > ; add any commands that need to happen after any optional sections here > WriteRegStr HKEY_LOCAL_MACHINE "SOFTWARE\Sicom\RLIB" "" "$INSTDIR" > WriteRegStr HKEY_LOCAL_MACHINE "Software\Microsoft\Windows\CurrentVersion\Uninstall\RLIB" "DisplayName" "RLIB (remove only)" > WriteRegStr HKEY_LOCAL_MACHINE "Software\Microsoft\Windows\CurrentVersion\Uninstall\RLIB" "UninstallString" '"$INSTDIR\uninst.exe"' > ; write out uninstaller > WriteUninstaller "$INSTDIR\uninst.exe" > SectionEnd ; end of -post section > > ; begin uninstall settings/section > UninstallText "This will uninstall RLIB from your system" > > Section Uninstall > ReadRegStr $R0 HKEY_LOCAL_MACHINE "SOFTWARE\Sicom\RLIB" "PerlDir" > Delete "$R0\auto\rlib\rlib.dll" > RMDir "$R0\auto\rlib" > Delete "$R0\rlib.pm" > RMDir "$R0" > > ReadRegStr $R0 HKEY_LOCAL_MACHINE "SOFTWARE\Sicom\RLIB" "PythonDir" > Delete "$R0\rlibmodule.dll" > Delete "$R0\rlibcompat.py" > Delete "$R0\_rlib.dll" > Delete "$R0\rlib.py" > RMDir "$R0" > > ReadRegStr $R0 HKEY_LOCAL_MACHINE "SOFTWARE\Sicom\RLIB" "PHPDir" > Delete "$R0\php_rlib.dll" > RMDir "$R0" > > Delete "$INSTDIR\Prerequisites\*.*" > RMDir "$INSTDIR\Prerequisites" > Delete "$INSTDIR\csharp\*.*" > RMDir "$INSTDIR\csharp" > Delete "$INSTDIR\java\*.*" > RMDir "$INSTDIR\java" > Delete "$INSTDIR\lib\*.*" > RMDir "$INSTDIR\lib" > Delete "$INSTDIR\include\*.*" > RMDir "$INSTDIR\include" > Delete "$INSTDIR\*.dll" > Delete "$INSTDIR\uninst.exe" > DeleteRegKey HKEY_LOCAL_MACHINE "SOFTWARE\Sicom\RLIB" > DeleteRegKey /ifempty HKEY_LOCAL_MACHINE "SOFTWARE\Sicom" > DeleteRegKey HKEY_LOCAL_MACHINE "SOFTWARE\Microsoft\Windows\CurrentVersion\Uninstall\RLIB" > RMDir "$INSTDIR" > SectionEnd ; end of uninstall section |