rlib-devel — RLIB Development Mailing List

Re: [Rlib-devel] Re: Crasher bug in RLIB

[Zoltan B. <zb...@du...>]

Hi!

Bob Doan =C3=ADrta:
> Can you send a stack trace or is it really nasty?
>=20
> On Mon, 2005-06-13 at 00:25 +0200, Zoltan Boszormenyi wrote:
>=20
>>Hi,
>>
>>I created a two-query report with <Part> tag.
>>There is a bug somewhere in RLIB that overwrites the stack
>>and I get a "** NUTS.. WE CRASHED" message.
>>If I filter the report's queries to return no rows,
>>it doesn't crash. But if I filter the queries to return
>>something and execute the report twice with the same
>>result sets, I get a crash. Executing the query the first
>>time I get the correct PDF. I try to track it down.
>>Finally, the developers put x86-64 support into valgrind,
>>maybe it will work for me, too.
>>
>>Best regards,
>>Zolt=C3=A1n B=C3=B6sz=C3=B6rm=C3=A9nyi

Finally here's the fix for the crash I was experienced. It was not a
64-bitness issue, it crashed because the number conversion
str(field,N,M) interpreted N and M backwards, e.g. str(field,18,2)
was actually converted as "%81.2f" and the space used for
converting both the integer and decimal parts of the number
were statically allocated as:

	gchar	left_holding[20];
	gchar	right_holding[20];

If one used two digit size for the integer part immediately
exceeded the allocated space and caused stack corruption.
I fixed rlib_number_sprintf() and rlib_pcode_operator_str()
to allocate their strings dinamically and rlib_number_sprintf()
to interpret the numbers correctly.

It was a tough one to find without valgrind. :-D

The patch also removes a bad cast, the macro changed isn't used
in RLIB yet, but it would cause a memory corruption, too, on 64-bit
systems. (long long) is 128 bits here and number_value member of
struct rlib_value is gint64. The compiler can at least warn us
this way.

Best regards,
Zolt=C3=A1n B=C3=B6sz=C3=B6rm=C3=A9nyi

[Rlib-devel] GCC4 warning fixes part2

[Zoltan B. <zb...@du...>]

Hi,

part 2, this time I fixed the following warnings to decrease the flood:

warning: passing argument N of 'func' discards qualifiers from pointer
target type
warning: initialization discards qualifiers from pointer target type

and every fallout that would cause incompatible pointers in assignment
warnings.

Reasoning: many functions that accept a "gchar *" parameter don't write
back to the string so they can be marked "const gchar *".
Indeed, most calls to them are done with constant strings.

Best regards,
Zolt=E1n B=F6sz=F6rm=E9nyi

[Rlib-devel] GCC4 warning fixes part1

[Zoltan B. <zb...@du...>]

Hi,

I tried to find why RLIB crashes on my FC3/x86-64 system.
Although valgrind for AMD64 found 1 error caused by a mis-sized malloc,
it is still in its infancy, today's valgrind subversion repo segfaults.
Instead, I tried to use GCC 4 to find the error.

I used this exaggerated warning level:

CFLAGS=3D"-g -O -pedantic -Wcomment -Wformat -Wimplicit -Wmultichar \
-Wparentheses -Wreturn-type -Wswitch -Wunused -Wuninitialized -Wall \
-W -Wshadow -Wpointer-arith -Wcast-align -Wwrite-strings -Wconversion \
-Wstrict-prototypes -Wlong-long

In this first patch, I corrected the following (most annoying) warning
types, some of which are actual coding bugs:

warning: function declaration isn't a prototype
warning: ISO C90 forbids mixed declarations and code
warning: ISO C forbids conversion of function pointer to object pointer t=
ype
warning: ISO C forbids initialization between function pointer and 'void =
*'
warning: ISO C forbids assignment between function pointer and 'void *'
warning: declaration of 'var/func' shadows a previous local
warning: declaration of 'var/func' shadows a global declaration
warning: ISO C does not allow extra ';' outside of a function
warning: empty body in an if-statement

Please, review the patch, especially the two fixes in graphing.c,
that fixes this construct, note the ';' after the if():

	if (condition);
		do_something();

and the changes in layout.c from line 836 so the changes follow
the original intention. All the other changes in the attached patch
are trivial changes.

Best regards,
Zolt=E1n B=F6sz=F6rm=E9nyi

[Rlib-devel] Fixes crash if user fails to check error return

[William K. V. <wk...@us...>]

Calling get_output if the report execution failed (I.E.
the XML was poorly formed) can access violate.  Be more
defensive in the interface.

Re: [Rlib-devel] Re: Buglet in detail layout on first page

[William K. V. <wk...@us...>]

Hello Bob,
	I continued to use the patch I had made to get_output_size
which took into account the size of horizontal lines, I added to
that to have it also account for Images.  The reason I continued
with my patch was it fixes my reports for now.  The implication
from your response below was there was another way to solve
the problem.  Since you are the architect you best would know
how to implement a fix (which I'm eagerly waiting to test :-).
One thing that I wanted to point out with my update was that
somewhere there appears to be a double accounting of the space
taken for the page footer.  This showed up with the Image being
outside of a Line object.

Does that clarify things?

Cheers,
William.
 
On Mon, 2005-06-13 at 11:26, Bob Doan wrote:
> Did you fix the problem with the Image?  I'm kinda confused here ;)
> 
> - bob
> 
> On Sun, 2005-06-12 at 13:32 -0600, William K. Volkman wrote:
> > Hello,
> > Just an update. I added the check for the size of an image to the
> > get_output_size routine, added a logo to the page footer, and now
> > am seeing a double compensation for the size of the footer.
> > 
> > On Sun, 2005-06-12 at 11:51, William K. Volkman wrote:
> > <snip>
> > > 
> > > On Sun, 2005-06-12 at 09:17, Bob Doan wrote:
> > > > As of this moment things like this just won't work (And overwrites will
> > > > occur)
> > > > 
> > > > Perhaps the more correct thing to do execute hight changing properties
> > > > before we check to see if "it will fit"
> > > 
> > > Which is one reason why I put made the change to get_output_size,
> > > it is called as part of the "will fit" check (see second stack
> > > trace from GDB below).
> > > 
> > > > I could tackle this one if you don't feel comfortable doing it.  Let me
> > > > know.
> > > 
> > > I don't think that I'm familiar enough with the architecture to be in
> > > a position to judge the "best" way to handle this.  If you want to
> > > tackle it that is fine by me.  The change I made basically works in
> > > the static case albeit not in the most efficient manner and didn't
> > > add support for images (which is one change that I would make, logo
> > > goes in the page footer).
> > 
> > Take care,
> > William.
> > 
> > 
> > 
> > 
> > -------------------------------------------------------
> > This SF.Net email is sponsored by: NEC IT Guy Games.  How far can you shotput
> > a projector? How fast can you ride your desk chair down the office luge track?
> > If you want to score the big prize, get to know the little guy.  
> > Play to win an NEC 61" plasma display: http://www.necitguy.com/?r=20
> > _______________________________________________
> > Rlib-devel mailing list
> > Rli...@li...
> > https://lists.sourceforge.net/lists/listinfo/rlib-devel

Re: [Rlib-devel] Re: Buglet in detail layout on first page

[Bob D. <bd...@si...>]

Did you fix the problem with the Image?  I'm kinda confused here ;)

- bob

On Sun, 2005-06-12 at 13:32 -0600, William K. Volkman wrote:
> Hello,
> Just an update. I added the check for the size of an image to the
> get_output_size routine, added a logo to the page footer, and now
> am seeing a double compensation for the size of the footer.
> 
> On Sun, 2005-06-12 at 11:51, William K. Volkman wrote:
> <snip>
> > 
> > On Sun, 2005-06-12 at 09:17, Bob Doan wrote:
> > > As of this moment things like this just won't work (And overwrites will
> > > occur)
> > > 
> > > Perhaps the more correct thing to do execute hight changing properties
> > > before we check to see if "it will fit"
> > 
> > Which is one reason why I put made the change to get_output_size,
> > it is called as part of the "will fit" check (see second stack
> > trace from GDB below).
> > 
> > > I could tackle this one if you don't feel comfortable doing it.  Let me
> > > know.
> > 
> > I don't think that I'm familiar enough with the architecture to be in
> > a position to judge the "best" way to handle this.  If you want to
> > tackle it that is fine by me.  The change I made basically works in
> > the static case albeit not in the most efficient manner and didn't
> > add support for images (which is one change that I would make, logo
> > goes in the page footer).
> 
> Take care,
> William.
> 
> 
> 
> 
> -------------------------------------------------------
> This SF.Net email is sponsored by: NEC IT Guy Games.  How far can you shotput
> a projector? How fast can you ride your desk chair down the office luge track?
> If you want to score the big prize, get to know the little guy.  
> Play to win an NEC 61" plasma display: http://www.necitguy.com/?r=20
> _______________________________________________
> Rlib-devel mailing list
> Rli...@li...
> https://lists.sourceforge.net/lists/listinfo/rlib-devel

Re: [Rlib-devel] Trivial patch to enable environment variable access

[Bob D. <bd...@si...>]

Applied!

Ty!

On Sun, 2005-06-12 at 18:02 -0600, William K. Volkman wrote:
> Attached is a trivial patch to allow access to environment
> variables, I.E. "m.SHELL" fills in /bin/bash2
> 
> Returns UTF-8 strings on Windows which I'm not certain if
> they should be converted or not.
> 
> Cheers,
> William.
> 
> 

Re: [Rlib-devel] Multiple images in a PDF don't seem to work

[Bob D. <bd...@si...>]

Applied.

Ty!


On Mon, 2005-06-13 at 02:50 -0600, William K. Volkman wrote:
> OK, found the problem, the reference count wasn't taking
> into account the image->number. Patch attached.
> 
> Cheers,
> William.
> 
> On Mon, 2005-06-13 at 01:49, William K. Volkman wrote:
> > Hello,
> > 	There seems to be a problem with rpdf and images, it only
> > displays the first one seen.  I can see that the image data is
> > copied into the PDF file, and I can see that it thinks it is
> > naming them /IMrpdf%d I'm not familiar enough with PDF to be
> > able to debug the problem though.
> > 
> > I've attached my simple test program and XML file.
> > 
> > Thanks for any assistance,
> > William.
> 

Re: [Rlib-devel] MetaData in report?

[Bob D. <bd...@si...>]

Changing it to MetaDataItem would be fine.

I believe there is a crasher in using MetaData.  I threw support for
meta data in there when I was bored visiting the Inlaws and never got
back around to it.

- bob


On Sun, 2005-06-12 at 18:50 -0600, William K. Volkman wrote:
> OK, figured it out, I think the inner node was supposed to
> be MetaDataItem, thoughts?
> 
> <MetaData>
>   <MetaData name="myfoo" value="'arglebargle'"/>
> </MetaData>
> 
> On Sun, 2005-06-12 at 17:46, William K. Volkman wrote:
> > Hello,
> > 	I can see that there is parsing for a MetaData tag,
> > however I can't tell how these name value pairs can be accessed.
> > I'll continue to look however I thought I'd ask.
> 
> 
> 
> 
> -------------------------------------------------------
> This SF.Net email is sponsored by: NEC IT Guy Games.  How far can you shotput
> a projector? How fast can you ride your desk chair down the office luge track?
> If you want to score the big prize, get to know the little guy.  
> Play to win an NEC 61" plasma display: http://www.necitguy.com/?r=20
> _______________________________________________
> Rlib-devel mailing list
> Rli...@li...
> https://lists.sourceforge.net/lists/listinfo/rlib-devel

Re: [Rlib-devel] rlib, Rlib, RLib or RLIB?

[Bob D. <bd...@si...>]

I think I prefer "RLIB"

On Sun, 2005-06-12 at 20:58 -0600, William K. Volkman wrote:
> I think I've seen all forms used, any preferences?  I'm tweaking the
> documentation.
> 
> Cheers,
> William.
> 
> 
> 
> 
> -------------------------------------------------------
> This SF.Net email is sponsored by: NEC IT Guy Games.  How far can you shotput
> a projector? How fast can you ride your desk chair down the office luge track?
> If you want to score the big prize, get to know the little guy.  
> Play to win an NEC 61" plasma display: http://www.necitguy.com/?r=20
> _______________________________________________
> Rlib-devel mailing list
> Rli...@li...
> https://lists.sourceforge.net/lists/listinfo/rlib-devel

Re: [Rlib-devel] Some documentation tweaks

[Bob D. <bd...@si...>]

Hey Thanks!

I have been moving the documentation to the WIKI to it will be easier to
maintain by contributers

I have the function reference done

see http://newrlib.sicom.com



On Sun, 2005-06-12 at 21:47 -0600, William K. Volkman wrote:
> I made some additions to the attributes, fixed some spelling, and
> tried to clarify rlib_add_parameter usage.
> 
> HTH,
> William.
> 

Re: [Rlib-devel] Multiple images in a PDF don't seem to work

[William K. V. <wk...@us...>]

OK, found the problem, the reference count wasn't taking
into account the image->number. Patch attached.

Cheers,
William.

On Mon, 2005-06-13 at 01:49, William K. Volkman wrote:
> Hello,
> 	There seems to be a problem with rpdf and images, it only
> displays the first one seen.  I can see that the image data is
> copied into the PDF file, and I can see that it thinks it is
> naming them /IMrpdf%d I'm not familiar enough with PDF to be
> able to debug the problem though.
> 
> I've attached my simple test program and XML file.
> 
> Thanks for any assistance,
> William.

[Rlib-devel] Multiple images in a PDF don't seem to work

[William K. V. <wk...@us...>]

Hello,
	There seems to be a problem with rpdf and images, it only
displays the first one seen.  I can see that the image data is
copied into the PDF file, and I can see that it thinks it is
naming them /IMrpdf%d I'm not familiar enough with PDF to be
able to debug the problem though.

I've attached my simple test program and XML file.

Thanks for any assistance,
William.

[Rlib-devel] Some documentation tweaks

[William K. V. <wk...@us...>]

I made some additions to the attributes, fixed some spelling, and
tried to clarify rlib_add_parameter usage.

HTH,
William.

[Rlib-devel] rlib, Rlib, RLib or RLIB?

[William K. V. <wk...@us...>]

I think I've seen all forms used, any preferences?  I'm tweaking the
documentation.

Cheers,
William.

Re: [Rlib-devel] MetaData in report?

[William K. V. <wk...@us...>]

OK, figured it out, I think the inner node was supposed to
be MetaDataItem, thoughts?

<MetaData>
  <MetaData name="myfoo" value="'arglebargle'"/>
</MetaData>

On Sun, 2005-06-12 at 17:46, William K. Volkman wrote:
> Hello,
> 	I can see that there is parsing for a MetaData tag,
> however I can't tell how these name value pairs can be accessed.
> I'll continue to look however I thought I'd ask.

[Rlib-devel] Trivial patch to enable environment variable access

[William K. V. <wk...@us...>]

Attached is a trivial patch to allow access to environment
variables, I.E. "m.SHELL" fills in /bin/bash2

Returns UTF-8 strings on Windows which I'm not certain if
they should be converted or not.

Cheers,
William.

[Rlib-devel] MetaData in report?

[William K. V. <wk...@us...>]

Hello,
	I can see that there is parsing for a MetaData tag,
however I can't tell how these name value pairs can be accessed.
I'll continue to look however I thought I'd ask.

Thanks,
William.

Re: [Rlib-devel] Re: Buglet in detail layout on first page

[William K. V. <wk...@us...>]

Hello,
On Sun, 2005-06-12 at 16:16, Bob Doan wrote:
> An image on a line or an Image outside of a line?

Humm.. an image on the line causes an under compensation, the
detail rows land in the page footer.  An image outside the line
shows the overcompensation.  Note this is not plain CVS,
in reportgen.c get_output_size I added:
              } else if(rd->type == RLIB_REPORT_PRESENTATION_DATA_IMAGE)
{
                      struct rlib_report_image *ri = rd->data;
                      struct rlib_value rval4, *rval_height=&rval4;
                      rlib_execute_pcode(r, &rval4, ri->height_code,
NULL);
                      if(!RLIB_VALUE_IS_NUMBER(rval_height)) {
                              r_error("RLIB ENCOUNTERED AN ERROR
OBTAINING THE HEIGHT FOR A IMAGE\n");
                      } else {
                              gfloat height =
RLIB_FXP_TO_NORMAL_LONG_LONG(RLIB_VALUE_GET_AS_NUMBER(rval_height));
                              rlib_value_free(rval_height);
                              total += RLIB_GET_LINE(height);
                      }
                }


> One of the "features" in rlib is to have an IMAGE outside of a line, but
> the catch is it doesn't account for Horizontal space.
> 
> On Sun, 2005-06-12 at 13:32 -0600, William K. Volkman wrote:
> > Hello,
> > Just an update. I added the check for the size of an image to the
> > get_output_size routine, added a logo to the page footer, and now
> > am seeing a double compensation for the size of the footer.
> > 
> > On Sun, 2005-06-12 at 11:51, William K. Volkman wrote:
> > <snip>
> > > 
> > > On Sun, 2005-06-12 at 09:17, Bob Doan wrote:
> > > > As of this moment things like this just won't work (And overwrites will
> > > > occur)
> > > > 
> > > > Perhaps the more correct thing to do execute hight changing properties
> > > > before we check to see if "it will fit"
> > > 
> > > Which is one reason why I put made the change to get_output_size,
> > > it is called as part of the "will fit" check (see second stack
> > > trace from GDB below).
> > > 
> > > > I could tackle this one if you don't feel comfortable doing it.  Let me
> > > > know.
> > > 
> > > I don't think that I'm familiar enough with the architecture to be in
> > > a position to judge the "best" way to handle this.  If you want to
> > > tackle it that is fine by me.  The change I made basically works in
> > > the static case albeit not in the most efficient manner and didn't
> > > add support for images (which is one change that I would make, logo
> > > goes in the page footer).

Re: [Rlib-devel] Re: Patch to mysql.c input filter

[William K. V. <wk...@us...>]

On Sun, 2005-06-12 at 16:18, Bob Doan wrote:
> FYI, Any chance you want to make the ChangeLog Entries with you
> patches? ;)

Sure, I can do that, I just assumed that the ChangeLog was managed
as part of the CVS commit process.

Cheers,
William.

Re: [Rlib-devel] Re: Patch to mysql.c input filter

[Bob D. <bd...@si...>]

Applied!

Ty!

FYI, Any chance you want to make the ChangeLog Entries with you
patches? ;)

- bob

On Fri, 2005-06-10 at 19:35 -0600, William K. Volkman wrote:
> Clicked too fast, now you'll find the patch.  Sorry :-(
> 
> On Fri, 2005-06-10 at 19:31, William K. Volkman wrote:
> > Hello,
> >       Attached find a patch to the mysql.c input filter
> > which should cure the occasional "** NUTS.. WE CRASHED" message
> > if a query fails.  Similar to the previous patch for
> > postgres.c
> > 
> > Comments and criticism welcome.
> 
-- 
Bob Doan <bd...@si...>

Re: [Rlib-devel] Re: Buglet in detail layout on first page

[Bob D. <bd...@si...>]

An image on a line or an Image outside of a line?

One of the "features" in rlib is to have an IMAGE outside of a line, but
the catch is it doesn't account for Horizontal space.

On Sun, 2005-06-12 at 13:32 -0600, William K. Volkman wrote:
> Hello,
> Just an update. I added the check for the size of an image to the
> get_output_size routine, added a logo to the page footer, and now
> am seeing a double compensation for the size of the footer.
> 
> On Sun, 2005-06-12 at 11:51, William K. Volkman wrote:
> <snip>
> > 
> > On Sun, 2005-06-12 at 09:17, Bob Doan wrote:
> > > As of this moment things like this just won't work (And overwrites will
> > > occur)
> > > 
> > > Perhaps the more correct thing to do execute hight changing properties
> > > before we check to see if "it will fit"
> > 
> > Which is one reason why I put made the change to get_output_size,
> > it is called as part of the "will fit" check (see second stack
> > trace from GDB below).
> > 
> > > I could tackle this one if you don't feel comfortable doing it.  Let me
> > > know.
> > 
> > I don't think that I'm familiar enough with the architecture to be in
> > a position to judge the "best" way to handle this.  If you want to
> > tackle it that is fine by me.  The change I made basically works in
> > the static case albeit not in the most efficient manner and didn't
> > add support for images (which is one change that I would make, logo
> > goes in the page footer).
> 
> Take care,
> William.
> 
-- 
Bob Doan <bd...@si...>

[Rlib-devel] Re: Crasher bug in RLIB

[Bob D. <bd...@si...>]

Can you send a stack trace or is it really nasty?

On Mon, 2005-06-13 at 00:25 +0200, Zoltan Boszormenyi wrote:
> Hi,
> 
> I created a two-query report with <Part> tag.
> There is a bug somewhere in RLIB that overwrites the stack
> and I get a "** NUTS.. WE CRASHED" message.
> If I filter the report's queries to return no rows,
> it doesn't crash. But if I filter the queries to return
> something and execute the report twice with the same
> result sets, I get a crash. Executing the query the first
> time I get the correct PDF. I try to track it down.
> Finally, the developers put x86-64 support into valgrind,
> maybe it will work for me, too.
> 
> Best regards,
> Zoltán Böszörményi
-- 
Bob Doan <bd...@si...>

Re: [Rlib-devel] Report attribute naming

[Bob D. <bd...@si...>]

I was planing on doing that in the 3.x release cycle.

But thanks anyway!

I was going to use "_" instead of capitalization.



On Sun, 2005-06-12 at 14:11 -0600, William K. Volkman wrote:
> Hello,
> 	Just was observing that for most attributes the caps word
> convention was followed, i.e.:
> fontSize
> topMargin
> leftMargin
> paperType
> 
> These two exceptions crept in however:
> detail_columns
> column_pad
> 
> Is it worth making them consistent?  I'll do it and update the docs
> if that is desired.
> 
> Cheers,
> William.
> 
> 
> 
> -------------------------------------------------------
> This SF.Net email is sponsored by: NEC IT Guy Games.  How far can you shotput
> a projector? How fast can you ride your desk chair down the office luge track?
> If you want to score the big prize, get to know the little guy.  
> Play to win an NEC 61" plasma display: http://www.necitguy.com/?r=20
> _______________________________________________
> Rlib-devel mailing list
> Rli...@li...
> https://lists.sourceforge.net/lists/listinfo/rlib-devel
-- 
Bob Doan <bd...@si...>

[Rlib-devel] Crasher bug in RLIB

[Zoltan B. <zb...@du...>]

Hi,

I created a two-query report with <Part> tag.
There is a bug somewhere in RLIB that overwrites the stack
and I get a "** NUTS.. WE CRASHED" message.
If I filter the report's queries to return no rows,
it doesn't crash. But if I filter the queries to return
something and execute the report twice with the same
result sets, I get a crash. Executing the query the first
time I get the correct PDF. I try to track it down.
Finally, the developers put x86-64 support into valgrind,
maybe it will work for me, too.

Best regards,
Zolt=E1n B=F6sz=F6rm=E9nyi