rlib-devel — RLIB Development Mailing List

Re: [Rlib-devel] Patches for compiling on Windows

[Bob D. <bd...@si...>]

Applied!

On Tue, 2008-08-26 at 12:52 +0200, Zoltan Boszormenyi wrote:
> Hi,
> 
> this change makes the Python binding uncompilable.
> Patch is attached. When the XML output format is
> introduced, this patch has to be reverted.
> 
> Also, because of the rlib.i change the bindings has to be
> re-generated in the CVS.
> 
> Best regards,
> Zoltán Böszörményi
> 
> Bob Doan írta:
> > We have plans to introduce an XML output, but we can take it out for
> > now.  We'll do it post 2.0
> >
> > I removed it an did a commit.
> >
> > - Bob
> >
> > On Fri, 2008-08-15 at 14:57 +0200, Zoltan Boszormenyi wrote:
> >   
> >> Hi,
> >>
> >> another one, now it's a bit more serious, not fixable by a one-liner.
> >> It started out with an observation:
> >> * rlib_set_output_format_from_text() matches the passed-in string and
> >>    if the string doesn't match to any known format string,
> >>    TXT is assumed and r->format is set accordingly.
> >> * rlib_set_output_format() accepts any number as format indicator.
> >>   this seems to be a bug by itself.
> >>
> >> I think there is an unintentional mixup in the defines.
> >>
> >> #define RLIB_CONTENT_TYPE_ERROR -1
> >> #define RLIB_CONTENT_TYPE_PDF   1
> >> #define RLIB_CONTENT_TYPE_HTML  2
> >> #define RLIB_CONTENT_TYPE_TXT           3
> >> #define RLIB_CONTENT_TYPE_CSV           4
> >>
> >> #define RLIB_FORMAT_PDF         1
> >> #define RLIB_FORMAT_HTML        2
> >> #define RLIB_FORMAT_TXT         3
> >> #define RLIB_FORMAT_CSV         4
> >> #define RLIB_FORMAT_XML         5
> >>
> >> And look at the usage patterns of r->format:
> >>
> >> rlib_make_report() uses r->format in a multi-conditional if() where
> >> the following output formats are handled explicitely: HTML, TXT, CSV.
> >> The last else (if all else fails) assumes PDF output is given.
> >> r->format is matched against RLIB_FORMAT_* here.
> >> RLIB_FORMAT_XML is not handled, rlib_xml_new_output_filter()
> >> does not exist.
> >>
> >> rlib_get_content_type_as_text() matches r->format against
> >> RLIB_CONTENT_TYPE_*. Also, the matching order is different
> >> from rlib_make_report(). PDF, CSV and HTML is explicitely tested,
> >> if all else fails TXT is assumed.
> >>
> >> Now, consider someone uses:
> >>
> >>     rlib_set_output_format(RLIB_FORMAT_XML);
> >>
> >> It's valid reading only the API headers. But the result is unexpected:
> >>
> >> - rlib_execute() generates a PDF report
> >> - rlib_get_content_type_as_text() returns the content of
> >>   RLIB_WEB_CONTENT_TYPE_TEXT with the proper charset
> >>
> >> So, this part needs rethinking. I think you need to decide which
> >> part of the defines has to be deprecated deleted and use the other
> >> set of the defines exclusively in the sources. Also, were there any
> >> plans to introduce rlib_xml_new_output_filter()? Or only the
> >> input filter as it exists now?
> >>
> >> Best regards,
> >> Zoltán Böszörményi
> >>
> >> Zoltan Boszormenyi írta:
> >>     
> >>> Hi,
> >>>
> >>> another question. There's two difference between
> >>> rlib_add_query_pointer_as() and rlib_add_query_as():
> >>>
> >>> - The "sql" parameter string is strdup()ed by rlib_add_query_as() but
> >>> not by rlib_add_query_pointer_as().
> >>>   I guess it's intentional, that's why there's a distinction at all.
> >>>
> >>> - rlib_add_query_as() returns an error if "input_source" was not yet
> >>>    defined as an input source by one of the rlib_add_datasource_*() calls.
> >>>    But rlib_add_query_pointer_as() doesn't. And there's not a single C
> >>> source
> >>>    under libsrc where this is rechecked later. This seems to be a bug,
> >>> fix is attached.
> >>>
> >>> Best regards,
> >>> Zoltán Böszörményi
> >>>
> >>> Zoltan Boszormenyi írta:
> >>>   
> >>>       
> >>>> Hi,
> >>>>
> >>>> I was reviewing the function reference and crosschecking it
> >>>> with the source. Some notes:
> >>>> I think the source mixes up bitwise AND and logical AND.
> >>>> * && works on expressions of the same type:
> >>>>         NUMBER && NUMBER (and performs logical AND)
> >>>>         STRING && STRING returns TRUE if both STRINGs are non-NULL
> >>>>         DATE && DATE would return TRUE always by intention
> >>>>             but there's a missing "return TRUE;" in the code, causing
> >>>> double freeing.
> >>>>             Fix is attached.
> >>>> * & works on NUMBERs only and performs bitwise or binary AND
> >>>>        but the naming in the source labels it as "logical AND"
> >>>> I don't intend to change the naming in the source but it's good to know.
> >>>> The wiki documentation lacked bitwise AND up to now.
> >>>> Also, some others are also missing:
> >>>> * N^M, a.k.a. power(N, M)
> >>>> * chgdateof()
> >>>> * dtosf()
> >>>>
> >>>> Best regards,
> >>>> Zoltán Böszörményi
> >>>>
> >>>> Bob Doan írta:
> >>>>   
> >>>>     
> >>>>         
> >>>>> Hi Zoltan,
> >>>>>
> >>>>> All patches have been applied.
> >>>>>
> >>>>> We're ready for the next round :)
> >>>>>
> >>>>> - Bob
> >>>>>
> >>>>> On Mon, 2008-08-11 at 15:30 +0200, Zoltan Boszormenyi wrote:
> >>>>>   
> >>>>>     
> >>>>>       
> >>>>>           
> >>>>>> Hi,
> >>>>>>
> >>>>>> here are the patches that make RLIB compile on Windows.
> >>>>>> The patches are split up in a way to contain only one fix.
> >>>>>>
> >>>>>> There's one thing that's missing though, namely PHP.
> >>>>>> PHP on Windows absolutely requires MSVC, the PHP/Win
> >>>>>> distribution(s) doesn't even contain php.h, etc., only the stub
> >>>>>> library called php5ts.lib to make it possible to link with php5ts.dll.
> >>>>>> Making a Zend extension under Windows starts with compiling
> >>>>>> PHP from source, it seems...
> >>>>>>
> >>>>>> Best regards,
> >>>>>> Zoltán Böszörményi
> >>>>>>
> >>>>>> -------------------------------------------------------------------------
> >>>>>> This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
> >>>>>> Build the coolest Linux based applications with Moblin SDK & win great prizes
> >>>>>> Grand prize is a trip for two to an Open Source event anywhere in the world
> >>>>>> http://moblin-contest.org/redirect.php?banner_id=100&url=/
> >>>>>> _______________________________________________ Rlib-devel mailing list Rli...@li... https://lists.sourceforge.net/lists/listinfo/rlib-devel
> >>>>>>     
> >>>>>>       
> >>>>>>         
> >>>>>>             
> >>>>> -------------------------------------------------------------------------
> >>>>> This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
> >>>>> Build the coolest Linux based applications with Moblin SDK & win great prizes
> >>>>> Grand prize is a trip for two to an Open Source event anywhere in the world
> >>>>> http://moblin-contest.org/redirect.php?banner_id=100&url=/
> >>>>> _______________________________________________
> >>>>> Rlib-devel mailing list
> >>>>> Rli...@li...
> >>>>> https://lists.sourceforge.net/lists/listinfo/rlib-devel
> >>>>>   
> >>>>>     
> >>>>>       
> >>>>>           
> >>>>   
> >>>> ------------------------------------------------------------------------
> >>>>
> >>>> -------------------------------------------------------------------------
> >>>> This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
> >>>> Build the coolest Linux based applications with Moblin SDK & win great prizes
> >>>> Grand prize is a trip for two to an Open Source event anywhere in the world
> >>>> http://moblin-contest.org/redirect.php?banner_id=100&url=/
> >>>> ------------------------------------------------------------------------
> >>>>
> >>>> _______________________________________________
> >>>> Rlib-devel mailing list
> >>>> Rli...@li...
> >>>> https://lists.sourceforge.net/lists/listinfo/rlib-devel
> >>>>     
> >>>>         
> >>>   
> >>> ------------------------------------------------------------------------
> >>>
> >>> -------------------------------------------------------------------------
> >>> This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
> >>> Build the coolest Linux based applications with Moblin SDK & win great prizes
> >>> Grand prize is a trip for two to an Open Source event anywhere in the world
> >>> http://moblin-contest.org/redirect.php?banner_id=100&url=/
> >>> ------------------------------------------------------------------------
> >>>
> >>> _______________________________________________
> >>> Rlib-devel mailing list
> >>> Rli...@li...
> >>> https://lists.sourceforge.net/lists/listinfo/rlib-devel
> >>>       
> >> -------------------------------------------------------------------------
> >> This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
> >> Build the coolest Linux based applications with Moblin SDK & win great prizes
> >> Grand prize is a trip for two to an Open Source event anywhere in the world
> >> http://moblin-contest.org/redirect.php?banner_id=100&url=/
> >> _______________________________________________
> >> Rlib-devel mailing list
> >> Rli...@li...
> >> https://lists.sourceforge.net/lists/listinfo/rlib-devel
> >>     
> >
> >
> > -------------------------------------------------------------------------
> > This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
> > Build the coolest Linux based applications with Moblin SDK & win great prizes
> > Grand prize is a trip for two to an Open Source event anywhere in the world
> > http://moblin-contest.org/redirect.php?banner_id=100&url=/
> > _______________________________________________
> > Rlib-devel mailing list
> > Rli...@li...
> > https://lists.sourceforge.net/lists/listinfo/rlib-devel
> >   
> 

Re: [Rlib-devel] Patches for compiling on Windows

[Bob D. <bd...@si...>]

Applied

On Fri, 2008-08-22 at 15:51 +0200, Zoltan Boszormenyi wrote:
> Hi,
> 
> I got around to find info about building the RLIB PHP binding
> in Windows. Here's a patch for correct compilation with ZTS=1
> which is a requirement on PHP/Windows builds. The PHP extension
> building on Windows is a saga in itself, however I am not a PHP expert,
> so I cannot test it. The installation page contains the steps to reproduce
> the build.
> 
> I send the compiled php_rlib.dll and the Visual Studio 2008 project
> in private.
> 
> Best regards,
> Zoltán Böszörményi
> 
> -------------------------------------------------------------------------
> This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
> Build the coolest Linux based applications with Moblin SDK & win great prizes
> Grand prize is a trip for two to an Open Source event anywhere in the world
> http://moblin-contest.org/redirect.php?banner_id=100&url=/
> _______________________________________________ Rlib-devel mailing list Rli...@li... https://lists.sourceforge.net/lists/listinfo/rlib-devel

Re: [Rlib-devel] Patches for compiling on Windows

[Zoltan B. <zb...@du...>]

Hi,

I think I finalized the documentation.
The following documentation links are now obsolete
on the "Documentation" TOC page since they are documented
under the "Report XML Definition" page:
- Graphs
- Gantt charts
But I don't know how to delete a page in the wiki.
Also, some examples might also need to be added to the wiki.

Best regards,
Zoltán

Re: [Rlib-devel] Patches for compiling on Windows

[Zoltan B. <zb...@du...>]

Hi,

I think one final patch is needed: NSIS installer bits. :-)
rlibsetup.exe created with the installer source file and out of the
with the current CVS plus my last fix will be sent in private.
To compile the installer successfully, php_rlib.dll must be copied
to bindings/php and also the manually created libr.lib (out of
libr.def, described in the PHP installation part in the Wiki) has to
be copied to libsrc.

Best regards,
Zoltán Böszörményi

Re: [Rlib-devel] Patches for compiling on Windows

[Zoltan B. <zb...@du...>]

Hi,

this change makes the Python binding uncompilable.
Patch is attached. When the XML output format is
introduced, this patch has to be reverted.

Also, because of the rlib.i change the bindings has to be
re-generated in the CVS.

Best regards,
Zoltán Böszörményi

Bob Doan írta:
> We have plans to introduce an XML output, but we can take it out for
> now.  We'll do it post 2.0
>
> I removed it an did a commit.
>
> - Bob
>
> On Fri, 2008-08-15 at 14:57 +0200, Zoltan Boszormenyi wrote:
>   
>> Hi,
>>
>> another one, now it's a bit more serious, not fixable by a one-liner.
>> It started out with an observation:
>> * rlib_set_output_format_from_text() matches the passed-in string and
>>    if the string doesn't match to any known format string,
>>    TXT is assumed and r->format is set accordingly.
>> * rlib_set_output_format() accepts any number as format indicator.
>>   this seems to be a bug by itself.
>>
>> I think there is an unintentional mixup in the defines.
>>
>> #define RLIB_CONTENT_TYPE_ERROR -1
>> #define RLIB_CONTENT_TYPE_PDF   1
>> #define RLIB_CONTENT_TYPE_HTML  2
>> #define RLIB_CONTENT_TYPE_TXT           3
>> #define RLIB_CONTENT_TYPE_CSV           4
>>
>> #define RLIB_FORMAT_PDF         1
>> #define RLIB_FORMAT_HTML        2
>> #define RLIB_FORMAT_TXT         3
>> #define RLIB_FORMAT_CSV         4
>> #define RLIB_FORMAT_XML         5
>>
>> And look at the usage patterns of r->format:
>>
>> rlib_make_report() uses r->format in a multi-conditional if() where
>> the following output formats are handled explicitely: HTML, TXT, CSV.
>> The last else (if all else fails) assumes PDF output is given.
>> r->format is matched against RLIB_FORMAT_* here.
>> RLIB_FORMAT_XML is not handled, rlib_xml_new_output_filter()
>> does not exist.
>>
>> rlib_get_content_type_as_text() matches r->format against
>> RLIB_CONTENT_TYPE_*. Also, the matching order is different
>> from rlib_make_report(). PDF, CSV and HTML is explicitely tested,
>> if all else fails TXT is assumed.
>>
>> Now, consider someone uses:
>>
>>     rlib_set_output_format(RLIB_FORMAT_XML);
>>
>> It's valid reading only the API headers. But the result is unexpected:
>>
>> - rlib_execute() generates a PDF report
>> - rlib_get_content_type_as_text() returns the content of
>>   RLIB_WEB_CONTENT_TYPE_TEXT with the proper charset
>>
>> So, this part needs rethinking. I think you need to decide which
>> part of the defines has to be deprecated deleted and use the other
>> set of the defines exclusively in the sources. Also, were there any
>> plans to introduce rlib_xml_new_output_filter()? Or only the
>> input filter as it exists now?
>>
>> Best regards,
>> Zoltán Böszörményi
>>
>> Zoltan Boszormenyi írta:
>>     
>>> Hi,
>>>
>>> another question. There's two difference between
>>> rlib_add_query_pointer_as() and rlib_add_query_as():
>>>
>>> - The "sql" parameter string is strdup()ed by rlib_add_query_as() but
>>> not by rlib_add_query_pointer_as().
>>>   I guess it's intentional, that's why there's a distinction at all.
>>>
>>> - rlib_add_query_as() returns an error if "input_source" was not yet
>>>    defined as an input source by one of the rlib_add_datasource_*() calls.
>>>    But rlib_add_query_pointer_as() doesn't. And there's not a single C
>>> source
>>>    under libsrc where this is rechecked later. This seems to be a bug,
>>> fix is attached.
>>>
>>> Best regards,
>>> Zoltán Böszörményi
>>>
>>> Zoltan Boszormenyi írta:
>>>   
>>>       
>>>> Hi,
>>>>
>>>> I was reviewing the function reference and crosschecking it
>>>> with the source. Some notes:
>>>> I think the source mixes up bitwise AND and logical AND.
>>>> * && works on expressions of the same type:
>>>>         NUMBER && NUMBER (and performs logical AND)
>>>>         STRING && STRING returns TRUE if both STRINGs are non-NULL
>>>>         DATE && DATE would return TRUE always by intention
>>>>             but there's a missing "return TRUE;" in the code, causing
>>>> double freeing.
>>>>             Fix is attached.
>>>> * & works on NUMBERs only and performs bitwise or binary AND
>>>>        but the naming in the source labels it as "logical AND"
>>>> I don't intend to change the naming in the source but it's good to know.
>>>> The wiki documentation lacked bitwise AND up to now.
>>>> Also, some others are also missing:
>>>> * N^M, a.k.a. power(N, M)
>>>> * chgdateof()
>>>> * dtosf()
>>>>
>>>> Best regards,
>>>> Zoltán Böszörményi
>>>>
>>>> Bob Doan írta:
>>>>   
>>>>     
>>>>         
>>>>> Hi Zoltan,
>>>>>
>>>>> All patches have been applied.
>>>>>
>>>>> We're ready for the next round :)
>>>>>
>>>>> - Bob
>>>>>
>>>>> On Mon, 2008-08-11 at 15:30 +0200, Zoltan Boszormenyi wrote:
>>>>>   
>>>>>     
>>>>>       
>>>>>           
>>>>>> Hi,
>>>>>>
>>>>>> here are the patches that make RLIB compile on Windows.
>>>>>> The patches are split up in a way to contain only one fix.
>>>>>>
>>>>>> There's one thing that's missing though, namely PHP.
>>>>>> PHP on Windows absolutely requires MSVC, the PHP/Win
>>>>>> distribution(s) doesn't even contain php.h, etc., only the stub
>>>>>> library called php5ts.lib to make it possible to link with php5ts.dll.
>>>>>> Making a Zend extension under Windows starts with compiling
>>>>>> PHP from source, it seems...
>>>>>>
>>>>>> Best regards,
>>>>>> Zoltán Böszörményi
>>>>>>
>>>>>> -------------------------------------------------------------------------
>>>>>> This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
>>>>>> Build the coolest Linux based applications with Moblin SDK & win great prizes
>>>>>> Grand prize is a trip for two to an Open Source event anywhere in the world
>>>>>> http://moblin-contest.org/redirect.php?banner_id=100&url=/
>>>>>> _______________________________________________ Rlib-devel mailing list Rli...@li... https://lists.sourceforge.net/lists/listinfo/rlib-devel
>>>>>>     
>>>>>>       
>>>>>>         
>>>>>>             
>>>>> -------------------------------------------------------------------------
>>>>> This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
>>>>> Build the coolest Linux based applications with Moblin SDK & win great prizes
>>>>> Grand prize is a trip for two to an Open Source event anywhere in the world
>>>>> http://moblin-contest.org/redirect.php?banner_id=100&url=/
>>>>> _______________________________________________
>>>>> Rlib-devel mailing list
>>>>> Rli...@li...
>>>>> https://lists.sourceforge.net/lists/listinfo/rlib-devel
>>>>>   
>>>>>     
>>>>>       
>>>>>           
>>>>   
>>>> ------------------------------------------------------------------------
>>>>
>>>> -------------------------------------------------------------------------
>>>> This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
>>>> Build the coolest Linux based applications with Moblin SDK & win great prizes
>>>> Grand prize is a trip for two to an Open Source event anywhere in the world
>>>> http://moblin-contest.org/redirect.php?banner_id=100&url=/
>>>> ------------------------------------------------------------------------
>>>>
>>>> _______________________________________________
>>>> Rlib-devel mailing list
>>>> Rli...@li...
>>>> https://lists.sourceforge.net/lists/listinfo/rlib-devel
>>>>     
>>>>         
>>>   
>>> ------------------------------------------------------------------------
>>>
>>> -------------------------------------------------------------------------
>>> This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
>>> Build the coolest Linux based applications with Moblin SDK & win great prizes
>>> Grand prize is a trip for two to an Open Source event anywhere in the world
>>> http://moblin-contest.org/redirect.php?banner_id=100&url=/
>>> ------------------------------------------------------------------------
>>>
>>> _______________________________________________
>>> Rlib-devel mailing list
>>> Rli...@li...
>>> https://lists.sourceforge.net/lists/listinfo/rlib-devel
>>>       
>> -------------------------------------------------------------------------
>> This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
>> Build the coolest Linux based applications with Moblin SDK & win great prizes
>> Grand prize is a trip for two to an Open Source event anywhere in the world
>> http://moblin-contest.org/redirect.php?banner_id=100&url=/
>> _______________________________________________
>> Rlib-devel mailing list
>> Rli...@li...
>> https://lists.sourceforge.net/lists/listinfo/rlib-devel
>>     
>
>
> -------------------------------------------------------------------------
> This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
> Build the coolest Linux based applications with Moblin SDK & win great prizes
> Grand prize is a trip for two to an Open Source event anywhere in the world
> http://moblin-contest.org/redirect.php?banner_id=100&url=/
> _______________________________________________
> Rlib-devel mailing list
> Rli...@li...
> https://lists.sourceforge.net/lists/listinfo/rlib-devel
>   

Re: [Rlib-devel] Patches for compiling on Windows

[Zoltan B. <zb...@du...>]

Hi,

I got around to find info about building the RLIB PHP binding
in Windows. Here's a patch for correct compilation with ZTS=1
which is a requirement on PHP/Windows builds. The PHP extension
building on Windows is a saga in itself, however I am not a PHP expert,
so I cannot test it. The installation page contains the steps to reproduce
the build.

I send the compiled php_rlib.dll and the Visual Studio 2008 project
in private.

Best regards,
Zoltán Böszörményi

Re: [Rlib-devel] Patches for compiling on Windows

[Zoltan B. <zb...@du...>]

Hi,

writing the documentation about the XML features, I came across this
typo in the code
in the graphing part.

Best regards,
Zoltán Böszörményi

Re: [Rlib-devel] Patches for compiling on Windows

[Zoltan B. <zb...@du...>]

Hi,

also, there's a small asymmetricity with respect to logical/bitwise
operators. There are &&, & and || but there's no | (bitwise OR).

Best regards,
Zoltán Böszörményi

Bob Doan írta:
> Hi,
>
> I applied the patch.
>
> Paul (SICOM) -> Can you investigate the bitwise/logical AND mixup?
>
> Thanks!
>
> - Bob
>
> On Fri, 2008-08-15 at 10:45 +0200, Zoltan Boszormenyi wrote:
>   
>> Hi,
>>
>> I was reviewing the function reference and crosschecking it
>> with the source. Some notes:
>> I think the source mixes up bitwise AND and logical AND.
>> * && works on expressions of the same type:
>>         NUMBER && NUMBER (and performs logical AND)
>>         STRING && STRING returns TRUE if both STRINGs are non-NULL
>>         DATE && DATE would return TRUE always by intention
>>             but there's a missing "return TRUE;" in the code, causing
>> double freeing.
>>             Fix is attached.
>> * & works on NUMBERs only and performs bitwise or binary AND
>>        but the naming in the source labels it as "logical AND"
>> I don't intend to change the naming in the source but it's good to know.
>> The wiki documentation lacked bitwise AND up to now.
>> Also, some others are also missing:
>> * N^M, a.k.a. power(N, M)
>> * chgdateof()
>> * dtosf()
>>
>> Best regards,
>> Zoltán Böszörményi
>>
>> Bob Doan írta:
>>     
>>> Hi Zoltan,
>>>
>>> All patches have been applied.
>>>
>>> We're ready for the next round :)
>>>
>>> - Bob
>>>
>>> On Mon, 2008-08-11 at 15:30 +0200, Zoltan Boszormenyi wrote:
>>>   
>>>       
>>>> Hi,
>>>>
>>>> here are the patches that make RLIB compile on Windows.
>>>> The patches are split up in a way to contain only one fix.
>>>>
>>>> There's one thing that's missing though, namely PHP.
>>>> PHP on Windows absolutely requires MSVC, the PHP/Win
>>>> distribution(s) doesn't even contain php.h, etc., only the stub
>>>> library called php5ts.lib to make it possible to link with php5ts.dll.
>>>> Making a Zend extension under Windows starts with compiling
>>>> PHP from source, it seems...
>>>>
>>>> Best regards,
>>>> Zoltán Böszörményi
>>>>
>>>> -------------------------------------------------------------------------
>>>> This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
>>>> Build the coolest Linux based applications with Moblin SDK & win great prizes
>>>> Grand prize is a trip for two to an Open Source event anywhere in the world
>>>> http://moblin-contest.org/redirect.php?banner_id=100&url=/
>>>> _______________________________________________ Rlib-devel mailing list Rli...@li... https://lists.sourceforge.net/lists/listinfo/rlib-devel
>>>>     
>>>>         
>>> -------------------------------------------------------------------------
>>> This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
>>> Build the coolest Linux based applications with Moblin SDK & win great prizes
>>> Grand prize is a trip for two to an Open Source event anywhere in the world
>>> http://moblin-contest.org/redirect.php?banner_id=100&url=/
>>> _______________________________________________
>>> Rlib-devel mailing list
>>> Rli...@li...
>>> https://lists.sourceforge.net/lists/listinfo/rlib-devel
>>>   
>>>       
>
>
> -------------------------------------------------------------------------
> This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
> Build the coolest Linux based applications with Moblin SDK & win great prizes
> Grand prize is a trip for two to an Open Source event anywhere in the world
> http://moblin-contest.org/redirect.php?banner_id=100&url=/
> _______________________________________________
> Rlib-devel mailing list
> Rli...@li...
> https://lists.sourceforge.net/lists/listinfo/rlib-devel
>   

Re: [Rlib-devel] Patches for compiling on Windows

[Bob D. <bd...@si...>]

We have plans to introduce an XML output, but we can take it out for
now.  We'll do it post 2.0

I removed it an did a commit.

- Bob

On Fri, 2008-08-15 at 14:57 +0200, Zoltan Boszormenyi wrote:
> Hi,
> 
> another one, now it's a bit more serious, not fixable by a one-liner.
> It started out with an observation:
> * rlib_set_output_format_from_text() matches the passed-in string and
>    if the string doesn't match to any known format string,
>    TXT is assumed and r->format is set accordingly.
> * rlib_set_output_format() accepts any number as format indicator.
>   this seems to be a bug by itself.
> 
> I think there is an unintentional mixup in the defines.
> 
> #define RLIB_CONTENT_TYPE_ERROR -1
> #define RLIB_CONTENT_TYPE_PDF   1
> #define RLIB_CONTENT_TYPE_HTML  2
> #define RLIB_CONTENT_TYPE_TXT           3
> #define RLIB_CONTENT_TYPE_CSV           4
> 
> #define RLIB_FORMAT_PDF         1
> #define RLIB_FORMAT_HTML        2
> #define RLIB_FORMAT_TXT         3
> #define RLIB_FORMAT_CSV         4
> #define RLIB_FORMAT_XML         5
> 
> And look at the usage patterns of r->format:
> 
> rlib_make_report() uses r->format in a multi-conditional if() where
> the following output formats are handled explicitely: HTML, TXT, CSV.
> The last else (if all else fails) assumes PDF output is given.
> r->format is matched against RLIB_FORMAT_* here.
> RLIB_FORMAT_XML is not handled, rlib_xml_new_output_filter()
> does not exist.
> 
> rlib_get_content_type_as_text() matches r->format against
> RLIB_CONTENT_TYPE_*. Also, the matching order is different
> from rlib_make_report(). PDF, CSV and HTML is explicitely tested,
> if all else fails TXT is assumed.
> 
> Now, consider someone uses:
> 
>     rlib_set_output_format(RLIB_FORMAT_XML);
> 
> It's valid reading only the API headers. But the result is unexpected:
> 
> - rlib_execute() generates a PDF report
> - rlib_get_content_type_as_text() returns the content of
>   RLIB_WEB_CONTENT_TYPE_TEXT with the proper charset
> 
> So, this part needs rethinking. I think you need to decide which
> part of the defines has to be deprecated deleted and use the other
> set of the defines exclusively in the sources. Also, were there any
> plans to introduce rlib_xml_new_output_filter()? Or only the
> input filter as it exists now?
> 
> Best regards,
> Zoltán Böszörményi
> 
> Zoltan Boszormenyi írta:
> > Hi,
> >
> > another question. There's two difference between
> > rlib_add_query_pointer_as() and rlib_add_query_as():
> >
> > - The "sql" parameter string is strdup()ed by rlib_add_query_as() but
> > not by rlib_add_query_pointer_as().
> >   I guess it's intentional, that's why there's a distinction at all.
> >
> > - rlib_add_query_as() returns an error if "input_source" was not yet
> >    defined as an input source by one of the rlib_add_datasource_*() calls.
> >    But rlib_add_query_pointer_as() doesn't. And there's not a single C
> > source
> >    under libsrc where this is rechecked later. This seems to be a bug,
> > fix is attached.
> >
> > Best regards,
> > Zoltán Böszörményi
> >
> > Zoltan Boszormenyi írta:
> >   
> >> Hi,
> >>
> >> I was reviewing the function reference and crosschecking it
> >> with the source. Some notes:
> >> I think the source mixes up bitwise AND and logical AND.
> >> * && works on expressions of the same type:
> >>         NUMBER && NUMBER (and performs logical AND)
> >>         STRING && STRING returns TRUE if both STRINGs are non-NULL
> >>         DATE && DATE would return TRUE always by intention
> >>             but there's a missing "return TRUE;" in the code, causing
> >> double freeing.
> >>             Fix is attached.
> >> * & works on NUMBERs only and performs bitwise or binary AND
> >>        but the naming in the source labels it as "logical AND"
> >> I don't intend to change the naming in the source but it's good to know.
> >> The wiki documentation lacked bitwise AND up to now.
> >> Also, some others are also missing:
> >> * N^M, a.k.a. power(N, M)
> >> * chgdateof()
> >> * dtosf()
> >>
> >> Best regards,
> >> Zoltán Böszörményi
> >>
> >> Bob Doan írta:
> >>   
> >>     
> >>> Hi Zoltan,
> >>>
> >>> All patches have been applied.
> >>>
> >>> We're ready for the next round :)
> >>>
> >>> - Bob
> >>>
> >>> On Mon, 2008-08-11 at 15:30 +0200, Zoltan Boszormenyi wrote:
> >>>   
> >>>     
> >>>       
> >>>> Hi,
> >>>>
> >>>> here are the patches that make RLIB compile on Windows.
> >>>> The patches are split up in a way to contain only one fix.
> >>>>
> >>>> There's one thing that's missing though, namely PHP.
> >>>> PHP on Windows absolutely requires MSVC, the PHP/Win
> >>>> distribution(s) doesn't even contain php.h, etc., only the stub
> >>>> library called php5ts.lib to make it possible to link with php5ts.dll.
> >>>> Making a Zend extension under Windows starts with compiling
> >>>> PHP from source, it seems...
> >>>>
> >>>> Best regards,
> >>>> Zoltán Böszörményi
> >>>>
> >>>> -------------------------------------------------------------------------
> >>>> This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
> >>>> Build the coolest Linux based applications with Moblin SDK & win great prizes
> >>>> Grand prize is a trip for two to an Open Source event anywhere in the world
> >>>> http://moblin-contest.org/redirect.php?banner_id=100&url=/
> >>>> _______________________________________________ Rlib-devel mailing list Rli...@li... https://lists.sourceforge.net/lists/listinfo/rlib-devel
> >>>>     
> >>>>       
> >>>>         
> >>> -------------------------------------------------------------------------
> >>> This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
> >>> Build the coolest Linux based applications with Moblin SDK & win great prizes
> >>> Grand prize is a trip for two to an Open Source event anywhere in the world
> >>> http://moblin-contest.org/redirect.php?banner_id=100&url=/
> >>> _______________________________________________
> >>> Rlib-devel mailing list
> >>> Rli...@li...
> >>> https://lists.sourceforge.net/lists/listinfo/rlib-devel
> >>>   
> >>>     
> >>>       
> >>   
> >> ------------------------------------------------------------------------
> >>
> >> -------------------------------------------------------------------------
> >> This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
> >> Build the coolest Linux based applications with Moblin SDK & win great prizes
> >> Grand prize is a trip for two to an Open Source event anywhere in the world
> >> http://moblin-contest.org/redirect.php?banner_id=100&url=/
> >> ------------------------------------------------------------------------
> >>
> >> _______________________________________________
> >> Rlib-devel mailing list
> >> Rli...@li...
> >> https://lists.sourceforge.net/lists/listinfo/rlib-devel
> >>     
> >
> >   
> > ------------------------------------------------------------------------
> >
> > -------------------------------------------------------------------------
> > This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
> > Build the coolest Linux based applications with Moblin SDK & win great prizes
> > Grand prize is a trip for two to an Open Source event anywhere in the world
> > http://moblin-contest.org/redirect.php?banner_id=100&url=/
> > ------------------------------------------------------------------------
> >
> > _______________________________________________
> > Rlib-devel mailing list
> > Rli...@li...
> > https://lists.sourceforge.net/lists/listinfo/rlib-devel
> 
> 
> -------------------------------------------------------------------------
> This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
> Build the coolest Linux based applications with Moblin SDK & win great prizes
> Grand prize is a trip for two to an Open Source event anywhere in the world
> http://moblin-contest.org/redirect.php?banner_id=100&url=/
> _______________________________________________
> Rlib-devel mailing list
> Rli...@li...
> https://lists.sourceforge.net/lists/listinfo/rlib-devel

Re: [Rlib-devel] Patches for compiling on Windows

[Bob D. <bd...@si...>]

Hi,

Applied!

This is the correct fix.  We have this function because we have input
sources that don't take queries, but rather pointers to data objects.

Thanks

- bob

On Fri, 2008-08-15 at 13:37 +0200, Zoltan Boszormenyi wrote:
> Hi,
> 
> another question. There's two difference between
> rlib_add_query_pointer_as() and rlib_add_query_as():
> 
> - The "sql" parameter string is strdup()ed by rlib_add_query_as() but
> not by rlib_add_query_pointer_as().
>   I guess it's intentional, that's why there's a distinction at all.
> 
> - rlib_add_query_as() returns an error if "input_source" was not yet
>    defined as an input source by one of the rlib_add_datasource_*() calls.
>    But rlib_add_query_pointer_as() doesn't. And there's not a single C
> source
>    under libsrc where this is rechecked later. This seems to be a bug,
> fix is attached.
> 
> Best regards,
> Zoltán Böszörményi
> 
> Zoltan Boszormenyi írta:
> > Hi,
> >
> > I was reviewing the function reference and crosschecking it
> > with the source. Some notes:
> > I think the source mixes up bitwise AND and logical AND.
> > * && works on expressions of the same type:
> >         NUMBER && NUMBER (and performs logical AND)
> >         STRING && STRING returns TRUE if both STRINGs are non-NULL
> >         DATE && DATE would return TRUE always by intention
> >             but there's a missing "return TRUE;" in the code, causing
> > double freeing.
> >             Fix is attached.
> > * & works on NUMBERs only and performs bitwise or binary AND
> >        but the naming in the source labels it as "logical AND"
> > I don't intend to change the naming in the source but it's good to know.
> > The wiki documentation lacked bitwise AND up to now.
> > Also, some others are also missing:
> > * N^M, a.k.a. power(N, M)
> > * chgdateof()
> > * dtosf()
> >
> > Best regards,
> > Zoltán Böszörményi
> >
> > Bob Doan írta:
> >   
> >> Hi Zoltan,
> >>
> >> All patches have been applied.
> >>
> >> We're ready for the next round :)
> >>
> >> - Bob
> >>
> >> On Mon, 2008-08-11 at 15:30 +0200, Zoltan Boszormenyi wrote:
> >>   
> >>     
> >>> Hi,
> >>>
> >>> here are the patches that make RLIB compile on Windows.
> >>> The patches are split up in a way to contain only one fix.
> >>>
> >>> There's one thing that's missing though, namely PHP.
> >>> PHP on Windows absolutely requires MSVC, the PHP/Win
> >>> distribution(s) doesn't even contain php.h, etc., only the stub
> >>> library called php5ts.lib to make it possible to link with php5ts.dll.
> >>> Making a Zend extension under Windows starts with compiling
> >>> PHP from source, it seems...
> >>>
> >>> Best regards,
> >>> Zoltán Böszörményi
> >>>
> >>> -------------------------------------------------------------------------
> >>> This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
> >>> Build the coolest Linux based applications with Moblin SDK & win great prizes
> >>> Grand prize is a trip for two to an Open Source event anywhere in the world
> >>> http://moblin-contest.org/redirect.php?banner_id=100&url=/
> >>> _______________________________________________ Rlib-devel mailing list Rli...@li... https://lists.sourceforge.net/lists/listinfo/rlib-devel
> >>>     
> >>>       
> >> -------------------------------------------------------------------------
> >> This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
> >> Build the coolest Linux based applications with Moblin SDK & win great prizes
> >> Grand prize is a trip for two to an Open Source event anywhere in the world
> >> http://moblin-contest.org/redirect.php?banner_id=100&url=/
> >> _______________________________________________
> >> Rlib-devel mailing list
> >> Rli...@li...
> >> https://lists.sourceforge.net/lists/listinfo/rlib-devel
> >>   
> >>     
> >
> >   
> > ------------------------------------------------------------------------
> >
> > -------------------------------------------------------------------------
> > This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
> > Build the coolest Linux based applications with Moblin SDK & win great prizes
> > Grand prize is a trip for two to an Open Source event anywhere in the world
> > http://moblin-contest.org/redirect.php?banner_id=100&url=/
> > ------------------------------------------------------------------------
> >
> > _______________________________________________
> > Rlib-devel mailing list
> > Rli...@li...
> > https://lists.sourceforge.net/lists/listinfo/rlib-devel
> 

Re: [Rlib-devel] Patches for compiling on Windows

[Bob D. <bd...@si...>]

Hi,

I applied the patch.

Paul (SICOM) -> Can you investigate the bitwise/logical AND mixup?

Thanks!

- Bob

On Fri, 2008-08-15 at 10:45 +0200, Zoltan Boszormenyi wrote:
> Hi,
> 
> I was reviewing the function reference and crosschecking it
> with the source. Some notes:
> I think the source mixes up bitwise AND and logical AND.
> * && works on expressions of the same type:
>         NUMBER && NUMBER (and performs logical AND)
>         STRING && STRING returns TRUE if both STRINGs are non-NULL
>         DATE && DATE would return TRUE always by intention
>             but there's a missing "return TRUE;" in the code, causing
> double freeing.
>             Fix is attached.
> * & works on NUMBERs only and performs bitwise or binary AND
>        but the naming in the source labels it as "logical AND"
> I don't intend to change the naming in the source but it's good to know.
> The wiki documentation lacked bitwise AND up to now.
> Also, some others are also missing:
> * N^M, a.k.a. power(N, M)
> * chgdateof()
> * dtosf()
> 
> Best regards,
> Zoltán Böszörményi
> 
> Bob Doan írta:
> > Hi Zoltan,
> >
> > All patches have been applied.
> >
> > We're ready for the next round :)
> >
> > - Bob
> >
> > On Mon, 2008-08-11 at 15:30 +0200, Zoltan Boszormenyi wrote:
> >   
> >> Hi,
> >>
> >> here are the patches that make RLIB compile on Windows.
> >> The patches are split up in a way to contain only one fix.
> >>
> >> There's one thing that's missing though, namely PHP.
> >> PHP on Windows absolutely requires MSVC, the PHP/Win
> >> distribution(s) doesn't even contain php.h, etc., only the stub
> >> library called php5ts.lib to make it possible to link with php5ts.dll.
> >> Making a Zend extension under Windows starts with compiling
> >> PHP from source, it seems...
> >>
> >> Best regards,
> >> Zoltán Böszörményi
> >>
> >> -------------------------------------------------------------------------
> >> This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
> >> Build the coolest Linux based applications with Moblin SDK & win great prizes
> >> Grand prize is a trip for two to an Open Source event anywhere in the world
> >> http://moblin-contest.org/redirect.php?banner_id=100&url=/
> >> _______________________________________________ Rlib-devel mailing list Rli...@li... https://lists.sourceforge.net/lists/listinfo/rlib-devel
> >>     
> >
> >
> > -------------------------------------------------------------------------
> > This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
> > Build the coolest Linux based applications with Moblin SDK & win great prizes
> > Grand prize is a trip for two to an Open Source event anywhere in the world
> > http://moblin-contest.org/redirect.php?banner_id=100&url=/
> > _______________________________________________
> > Rlib-devel mailing list
> > Rli...@li...
> > https://lists.sourceforge.net/lists/listinfo/rlib-devel
> >   
> 

Re: [Rlib-devel] Patches for compiling on Windows

[Zoltan B. <zb...@du...>]

Hi,

another one, now it's a bit more serious, not fixable by a one-liner.
It started out with an observation:
* rlib_set_output_format_from_text() matches the passed-in string and
   if the string doesn't match to any known format string,
   TXT is assumed and r->format is set accordingly.
* rlib_set_output_format() accepts any number as format indicator.
  this seems to be a bug by itself.

I think there is an unintentional mixup in the defines.

#define RLIB_CONTENT_TYPE_ERROR -1
#define RLIB_CONTENT_TYPE_PDF   1
#define RLIB_CONTENT_TYPE_HTML  2
#define RLIB_CONTENT_TYPE_TXT           3
#define RLIB_CONTENT_TYPE_CSV           4

#define RLIB_FORMAT_PDF         1
#define RLIB_FORMAT_HTML        2
#define RLIB_FORMAT_TXT         3
#define RLIB_FORMAT_CSV         4
#define RLIB_FORMAT_XML         5

And look at the usage patterns of r->format:

rlib_make_report() uses r->format in a multi-conditional if() where
the following output formats are handled explicitely: HTML, TXT, CSV.
The last else (if all else fails) assumes PDF output is given.
r->format is matched against RLIB_FORMAT_* here.
RLIB_FORMAT_XML is not handled, rlib_xml_new_output_filter()
does not exist.

rlib_get_content_type_as_text() matches r->format against
RLIB_CONTENT_TYPE_*. Also, the matching order is different
from rlib_make_report(). PDF, CSV and HTML is explicitely tested,
if all else fails TXT is assumed.

Now, consider someone uses:

    rlib_set_output_format(RLIB_FORMAT_XML);

It's valid reading only the API headers. But the result is unexpected:

- rlib_execute() generates a PDF report
- rlib_get_content_type_as_text() returns the content of
  RLIB_WEB_CONTENT_TYPE_TEXT with the proper charset

So, this part needs rethinking. I think you need to decide which
part of the defines has to be deprecated deleted and use the other
set of the defines exclusively in the sources. Also, were there any
plans to introduce rlib_xml_new_output_filter()? Or only the
input filter as it exists now?

Best regards,
Zoltán Böszörményi

Zoltan Boszormenyi írta:
> Hi,
>
> another question. There's two difference between
> rlib_add_query_pointer_as() and rlib_add_query_as():
>
> - The "sql" parameter string is strdup()ed by rlib_add_query_as() but
> not by rlib_add_query_pointer_as().
>   I guess it's intentional, that's why there's a distinction at all.
>
> - rlib_add_query_as() returns an error if "input_source" was not yet
>    defined as an input source by one of the rlib_add_datasource_*() calls.
>    But rlib_add_query_pointer_as() doesn't. And there's not a single C
> source
>    under libsrc where this is rechecked later. This seems to be a bug,
> fix is attached.
>
> Best regards,
> Zoltán Böszörményi
>
> Zoltan Boszormenyi írta:
>   
>> Hi,
>>
>> I was reviewing the function reference and crosschecking it
>> with the source. Some notes:
>> I think the source mixes up bitwise AND and logical AND.
>> * && works on expressions of the same type:
>>         NUMBER && NUMBER (and performs logical AND)
>>         STRING && STRING returns TRUE if both STRINGs are non-NULL
>>         DATE && DATE would return TRUE always by intention
>>             but there's a missing "return TRUE;" in the code, causing
>> double freeing.
>>             Fix is attached.
>> * & works on NUMBERs only and performs bitwise or binary AND
>>        but the naming in the source labels it as "logical AND"
>> I don't intend to change the naming in the source but it's good to know.
>> The wiki documentation lacked bitwise AND up to now.
>> Also, some others are also missing:
>> * N^M, a.k.a. power(N, M)
>> * chgdateof()
>> * dtosf()
>>
>> Best regards,
>> Zoltán Böszörményi
>>
>> Bob Doan írta:
>>   
>>     
>>> Hi Zoltan,
>>>
>>> All patches have been applied.
>>>
>>> We're ready for the next round :)
>>>
>>> - Bob
>>>
>>> On Mon, 2008-08-11 at 15:30 +0200, Zoltan Boszormenyi wrote:
>>>   
>>>     
>>>       
>>>> Hi,
>>>>
>>>> here are the patches that make RLIB compile on Windows.
>>>> The patches are split up in a way to contain only one fix.
>>>>
>>>> There's one thing that's missing though, namely PHP.
>>>> PHP on Windows absolutely requires MSVC, the PHP/Win
>>>> distribution(s) doesn't even contain php.h, etc., only the stub
>>>> library called php5ts.lib to make it possible to link with php5ts.dll.
>>>> Making a Zend extension under Windows starts with compiling
>>>> PHP from source, it seems...
>>>>
>>>> Best regards,
>>>> Zoltán Böszörményi
>>>>
>>>> -------------------------------------------------------------------------
>>>> This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
>>>> Build the coolest Linux based applications with Moblin SDK & win great prizes
>>>> Grand prize is a trip for two to an Open Source event anywhere in the world
>>>> http://moblin-contest.org/redirect.php?banner_id=100&url=/
>>>> _______________________________________________ Rlib-devel mailing list Rli...@li... https://lists.sourceforge.net/lists/listinfo/rlib-devel
>>>>     
>>>>       
>>>>         
>>> -------------------------------------------------------------------------
>>> This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
>>> Build the coolest Linux based applications with Moblin SDK & win great prizes
>>> Grand prize is a trip for two to an Open Source event anywhere in the world
>>> http://moblin-contest.org/redirect.php?banner_id=100&url=/
>>> _______________________________________________
>>> Rlib-devel mailing list
>>> Rli...@li...
>>> https://lists.sourceforge.net/lists/listinfo/rlib-devel
>>>   
>>>     
>>>       
>>   
>> ------------------------------------------------------------------------
>>
>> -------------------------------------------------------------------------
>> This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
>> Build the coolest Linux based applications with Moblin SDK & win great prizes
>> Grand prize is a trip for two to an Open Source event anywhere in the world
>> http://moblin-contest.org/redirect.php?banner_id=100&url=/
>> ------------------------------------------------------------------------
>>
>> _______________________________________________
>> Rlib-devel mailing list
>> Rli...@li...
>> https://lists.sourceforge.net/lists/listinfo/rlib-devel
>>     
>
>   
> ------------------------------------------------------------------------
>
> -------------------------------------------------------------------------
> This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
> Build the coolest Linux based applications with Moblin SDK & win great prizes
> Grand prize is a trip for two to an Open Source event anywhere in the world
> http://moblin-contest.org/redirect.php?banner_id=100&url=/
> ------------------------------------------------------------------------
>
> _______________________________________________
> Rlib-devel mailing list
> Rli...@li...
> https://lists.sourceforge.net/lists/listinfo/rlib-devel

Re: [Rlib-devel] Patches for compiling on Windows

[Zoltan B. <zb...@du...>]

Hi,

another question. There's two difference between
rlib_add_query_pointer_as() and rlib_add_query_as():

- The "sql" parameter string is strdup()ed by rlib_add_query_as() but
not by rlib_add_query_pointer_as().
  I guess it's intentional, that's why there's a distinction at all.

- rlib_add_query_as() returns an error if "input_source" was not yet
   defined as an input source by one of the rlib_add_datasource_*() calls.
   But rlib_add_query_pointer_as() doesn't. And there's not a single C
source
   under libsrc where this is rechecked later. This seems to be a bug,
fix is attached.

Best regards,
Zoltán Böszörményi

Zoltan Boszormenyi írta:
> Hi,
>
> I was reviewing the function reference and crosschecking it
> with the source. Some notes:
> I think the source mixes up bitwise AND and logical AND.
> * && works on expressions of the same type:
>         NUMBER && NUMBER (and performs logical AND)
>         STRING && STRING returns TRUE if both STRINGs are non-NULL
>         DATE && DATE would return TRUE always by intention
>             but there's a missing "return TRUE;" in the code, causing
> double freeing.
>             Fix is attached.
> * & works on NUMBERs only and performs bitwise or binary AND
>        but the naming in the source labels it as "logical AND"
> I don't intend to change the naming in the source but it's good to know.
> The wiki documentation lacked bitwise AND up to now.
> Also, some others are also missing:
> * N^M, a.k.a. power(N, M)
> * chgdateof()
> * dtosf()
>
> Best regards,
> Zoltán Böszörményi
>
> Bob Doan írta:
>   
>> Hi Zoltan,
>>
>> All patches have been applied.
>>
>> We're ready for the next round :)
>>
>> - Bob
>>
>> On Mon, 2008-08-11 at 15:30 +0200, Zoltan Boszormenyi wrote:
>>   
>>     
>>> Hi,
>>>
>>> here are the patches that make RLIB compile on Windows.
>>> The patches are split up in a way to contain only one fix.
>>>
>>> There's one thing that's missing though, namely PHP.
>>> PHP on Windows absolutely requires MSVC, the PHP/Win
>>> distribution(s) doesn't even contain php.h, etc., only the stub
>>> library called php5ts.lib to make it possible to link with php5ts.dll.
>>> Making a Zend extension under Windows starts with compiling
>>> PHP from source, it seems...
>>>
>>> Best regards,
>>> Zoltán Böszörményi
>>>
>>> -------------------------------------------------------------------------
>>> This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
>>> Build the coolest Linux based applications with Moblin SDK & win great prizes
>>> Grand prize is a trip for two to an Open Source event anywhere in the world
>>> http://moblin-contest.org/redirect.php?banner_id=100&url=/
>>> _______________________________________________ Rlib-devel mailing list Rli...@li... https://lists.sourceforge.net/lists/listinfo/rlib-devel
>>>     
>>>       
>> -------------------------------------------------------------------------
>> This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
>> Build the coolest Linux based applications with Moblin SDK & win great prizes
>> Grand prize is a trip for two to an Open Source event anywhere in the world
>> http://moblin-contest.org/redirect.php?banner_id=100&url=/
>> _______________________________________________
>> Rlib-devel mailing list
>> Rli...@li...
>> https://lists.sourceforge.net/lists/listinfo/rlib-devel
>>   
>>     
>
>   
> ------------------------------------------------------------------------
>
> -------------------------------------------------------------------------
> This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
> Build the coolest Linux based applications with Moblin SDK & win great prizes
> Grand prize is a trip for two to an Open Source event anywhere in the world
> http://moblin-contest.org/redirect.php?banner_id=100&url=/
> ------------------------------------------------------------------------
>
> _______________________________________________
> Rlib-devel mailing list
> Rli...@li...
> https://lists.sourceforge.net/lists/listinfo/rlib-devel

Re: [Rlib-devel] Patches for compiling on Windows

[Zoltan B. <zb...@du...>]

Hi,

I was reviewing the function reference and crosschecking it
with the source. Some notes:
I think the source mixes up bitwise AND and logical AND.
* && works on expressions of the same type:
        NUMBER && NUMBER (and performs logical AND)
        STRING && STRING returns TRUE if both STRINGs are non-NULL
        DATE && DATE would return TRUE always by intention
            but there's a missing "return TRUE;" in the code, causing
double freeing.
            Fix is attached.
* & works on NUMBERs only and performs bitwise or binary AND
       but the naming in the source labels it as "logical AND"
I don't intend to change the naming in the source but it's good to know.
The wiki documentation lacked bitwise AND up to now.
Also, some others are also missing:
* N^M, a.k.a. power(N, M)
* chgdateof()
* dtosf()

Best regards,
Zoltán Böszörményi

Bob Doan írta:
> Hi Zoltan,
>
> All patches have been applied.
>
> We're ready for the next round :)
>
> - Bob
>
> On Mon, 2008-08-11 at 15:30 +0200, Zoltan Boszormenyi wrote:
>   
>> Hi,
>>
>> here are the patches that make RLIB compile on Windows.
>> The patches are split up in a way to contain only one fix.
>>
>> There's one thing that's missing though, namely PHP.
>> PHP on Windows absolutely requires MSVC, the PHP/Win
>> distribution(s) doesn't even contain php.h, etc., only the stub
>> library called php5ts.lib to make it possible to link with php5ts.dll.
>> Making a Zend extension under Windows starts with compiling
>> PHP from source, it seems...
>>
>> Best regards,
>> Zoltán Böszörményi
>>
>> -------------------------------------------------------------------------
>> This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
>> Build the coolest Linux based applications with Moblin SDK & win great prizes
>> Grand prize is a trip for two to an Open Source event anywhere in the world
>> http://moblin-contest.org/redirect.php?banner_id=100&url=/
>> _______________________________________________ Rlib-devel mailing list Rli...@li... https://lists.sourceforge.net/lists/listinfo/rlib-devel
>>     
>
>
> -------------------------------------------------------------------------
> This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
> Build the coolest Linux based applications with Moblin SDK & win great prizes
> Grand prize is a trip for two to an Open Source event anywhere in the world
> http://moblin-contest.org/redirect.php?banner_id=100&url=/
> _______________________________________________
> Rlib-devel mailing list
> Rli...@li...
> https://lists.sourceforge.net/lists/listinfo/rlib-devel
>   

Re: [Rlib-devel] Patches for compiling on Windows

[Bob D. <bd...@si...>]

We have already.  :)

Looks good.  Keep going.

On Tue, 2008-08-12 at 16:46 +0200, Zoltan Boszormenyi wrote:
> Hi,
> 
> look at http://newrlib.sicom.com/index.php?title=Documentation_Install
> 
> Best regards,
> Zoltán
> 
> Bob Doan írta:
> > Hi Zoltan,
> >
> > All patches have been applied.
> >
> > We're ready for the next round :)
> >
> > - Bob
> >
> > On Mon, 2008-08-11 at 15:30 +0200, Zoltan Boszormenyi wrote:
> >   
> >> Hi,
> >>
> >> here are the patches that make RLIB compile on Windows.
> >> The patches are split up in a way to contain only one fix.
> >>
> >> There's one thing that's missing though, namely PHP.
> >> PHP on Windows absolutely requires MSVC, the PHP/Win
> >> distribution(s) doesn't even contain php.h, etc., only the stub
> >> library called php5ts.lib to make it possible to link with php5ts.dll.
> >> Making a Zend extension under Windows starts with compiling
> >> PHP from source, it seems...
> >>
> >> Best regards,
> >> Zoltán Böszörményi
> >>
> >> -------------------------------------------------------------------------
> >> This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
> >> Build the coolest Linux based applications with Moblin SDK & win great prizes
> >> Grand prize is a trip for two to an Open Source event anywhere in the world
> >> http://moblin-contest.org/redirect.php?banner_id=100&url=/
> >> _______________________________________________ Rlib-devel mailing list Rli...@li... https://lists.sourceforge.net/lists/listinfo/rlib-devel
> >>     
> >
> >
> >   
> 
> 

Re: [Rlib-devel] Patches for compiling on Windows

[Bob D. <bd...@si...>]

Hi Zoltan,

All patches have been applied.

We're ready for the next round :)

- Bob

On Mon, 2008-08-11 at 15:30 +0200, Zoltan Boszormenyi wrote:
> Hi,
> 
> here are the patches that make RLIB compile on Windows.
> The patches are split up in a way to contain only one fix.
> 
> There's one thing that's missing though, namely PHP.
> PHP on Windows absolutely requires MSVC, the PHP/Win
> distribution(s) doesn't even contain php.h, etc., only the stub
> library called php5ts.lib to make it possible to link with php5ts.dll.
> Making a Zend extension under Windows starts with compiling
> PHP from source, it seems...
> 
> Best regards,
> Zoltán Böszörményi
> 
> -------------------------------------------------------------------------
> This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
> Build the coolest Linux based applications with Moblin SDK & win great prizes
> Grand prize is a trip for two to an Open Source event anywhere in the world
> http://moblin-contest.org/redirect.php?banner_id=100&url=/
> _______________________________________________ Rlib-devel mailing list Rli...@li... https://lists.sourceforge.net/lists/listinfo/rlib-devel

[Rlib-devel] Patches for compiling on Windows

[Zoltan B. <zb...@du...>]

Hi,

here are the patches that make RLIB compile on Windows.
The patches are split up in a way to contain only one fix.

There's one thing that's missing though, namely PHP.
PHP on Windows absolutely requires MSVC, the PHP/Win
distribution(s) doesn't even contain php.h, etc., only the stub
library called php5ts.lib to make it possible to link with php5ts.dll.
Making a Zend extension under Windows starts with compiling
PHP from source, it seems...

Best regards,
Zoltán Böszörményi

Re: [Rlib-devel] patch for reporting error when the 'value' attribute of <field> isn't specified

[Bob D. <bd...@si...>]

Applied!

Thanks!


On Tue, 2007-12-04 at 16:36 -0500, Steve Mokris wrote:
> > Sorry for the long delay.  I had some computer problems.  Would you be
> > able to send the patches as attachments?
> 
> No problem.  Attached.
> 
> Steve
> 

Re: [Rlib-devel] patch for reporting error when the 'value' attribute of <field> isn't specified

[Steve M. <sm...@so...>]

> Sorry for the long delay.  I had some computer problems.  Would you be
> able to send the patches as attachments?

No problem.  Attached.

Steve

Re: [Rlib-devel] patch for reporting error when the 'value' attribute of <field> isn't specified

[Bob D. <bd...@si...>]

Hey,

Sorry for the long delay.  I had some computer problems.  Would you be
able to send the patches as attachments?

Thanks!

- Bob


On Wed, 2007-11-28 at 13:44 -0500, Steve Mokris wrote:
> [re-sending this since it didn't seem to go through the first time.]
> 
> Hi.
> 
> First, thanks for rlib.  I've been doing some tests with it and have  
> been impressed that you've already almost exactly implemented the  
> reporting system I'd just designed :^) .  I wrote a little PHP wrapper  
> for it, allowing users to easily generate parameterized SQL reports..   
> Planning to release it once it's matured a little.
> 
> Anyway..  I spent most of the morning trying to track down what I  
> eventually discovered was a segfault in parse_line_array.  And it  
> turned out this segfault was caused by a typo in my report.  I typed:
> 	<field width="1" />
> when I meant to type:
> 	<literal width="1" />
> ...which crashed because the parser code was assuming there was a  
> 'value' present for <field>.
> 
> This could easily be avoided with an r_error and graceful quit, I  
> think.  Below is a patch.
> 
> Hope this helps.
> 
> Steve
> 
> ===========
> 
> --- parsexml.c	(revision 3084)
> +++ parsexml.c	(working copy)
> @@ -98,6 +98,10 @@
> 			struct rlib_report_field *f = g_new0(struct rlib_report_field, 1);
> 			current = (void *)g_new0(struct rlib_element, 1);
> 			sp = xmlGetProp(cur, (const xmlChar *) "value");
> +			if(!sp) {
> +				r_error(r, "Line: %d - <field> is missing 'value' attribute. \n",  
> xmlGetLineNo (cur),cur->name);
> +				return NULL;
> +			}
> #if DISABLE_UTF8
> 			utf8_to_8813(r, f->value, (gchar *)sp);
> #else
> 
> 
> -------------------------------------------------------------------------
> SF.Net email is sponsored by: The Future of Linux Business White Paper
> from Novell.  From the desktop to the data center, Linux is going
> mainstream.  Let it simplify your IT future.
> http://altfarm.mediaplex.com/ad/ck/8857-50307-18918-4
> _______________________________________________
> Rlib-devel mailing list
> Rli...@li...
> https://lists.sourceforge.net/lists/listinfo/rlib-devel

[Rlib-devel] patch for reporting error when the 'value' attribute of <field> isn't specified

[Steve M. <sm...@so...>]

Hi.

First, thanks for rlib.  I've been doing some tests with it and have  
been impressed that you've already almost exactly implemented the  
reporting system I'd just designed :^) .  I wrote a little PHP wrapper  
for it, allowing users to easily generate parameterized SQL reports..   
Planning to release it once it's matured a little.

Anyway..  I spent most of the morning trying to track down what I  
eventually discovered was a segfault in parse_line_array.  And it  
turned out this segfault was caused by a typo in my report.  I typed:
	<field width="1" />
when I meant to type:
	<literal width="1" />
...which crashed because the parser code was assuming there was a  
'value' present for <field>.

This could easily be avoided with an r_error and graceful quit, I  
think.  Below is a patch.

Hope this helps.

Steve

===========

--- parsexml.c	(revision 3084)
+++ parsexml.c	(working copy)
@@ -98,6 +98,10 @@
  			struct rlib_report_field *f = g_new0(struct rlib_report_field, 1);
  			current = (void *)g_new0(struct rlib_element, 1);
  			sp = xmlGetProp(cur, (const xmlChar *) "value");
+			if(!sp) {
+				r_error(r, "Line: %d - <field> is missing 'value' attribute. \n",  
xmlGetLineNo (cur),cur->name);
+				return NULL;
+			}
  #if DISABLE_UTF8
  			utf8_to_8813(r, f->value, (gchar *)sp);
  #else

[Rlib-devel] html_debugging mode: HTML character entity encoding

[Steve M. <sm...@so...>]

Another patch --- This one escapes '&', '<', and '>' when outputting  
HTML, so that these characters render visibly rather than get parsed  
by the browser.

Steve

=========

--- util.c	(revision 3084)
+++ util.c	(working copy)
@@ -172,9 +172,42 @@

  static void local_rlogit(rlib *r, const gchar *message) {
  	if(r != NULL && r->html_debugging) {
-		ENVIRONMENT(r)->rlib_write_output("<br><b>RLIB: ",  
strlen("<br><b>RLIB: "));
-		ENVIRONMENT(r)->rlib_write_output((char *)message, strlen(message));
-		ENVIRONMENT(r)->rlib_write_output("</br></b>", strlen("</br></b>"));
+		ENVIRONMENT(r)->rlib_write_output("<p><b>RLIB Error:</b> ",  
strlen("<p><b>RLIB Error:</b> "));
+
+		/* escape '&','<','>' as HTML character entities */
+		char *htmlEncoded=(char *)malloc(strlen(message)*5); /* 5 times the  
original length is the worst-case-scenario: replacing '&' with "&amp;"  
*/
+		int i,h=0;
+		for(i=0;i<strlen(message);++i) {
+			switch(message[i]) {
+				case '&':
+					htmlEncoded[h++]='&';
+					htmlEncoded[h++]='a';
+					htmlEncoded[h++]='m';
+					htmlEncoded[h++]='p';
+					htmlEncoded[h++]=';';
+					break;
+				case '<':
+					htmlEncoded[h++]='&';
+					htmlEncoded[h++]='l';
+					htmlEncoded[h++]='t';
+					htmlEncoded[h++]=';';
+					break;
+				case '>':
+					htmlEncoded[h++]='&';
+					htmlEncoded[h++]='g';
+					htmlEncoded[h++]='t';
+					htmlEncoded[h++]=';';
+					break;
+				default:
+					htmlEncoded[h++]=message[i];
+			}
+		}
+		htmlEncoded[h]=0;
+
+		ENVIRONMENT(r)->rlib_write_output((char *)htmlEncoded,  
strlen(htmlEncoded));
+		free(htmlEncoded);
+
+		ENVIRONMENT(r)->rlib_write_output("</p>", strlen("</p>"));
  	}
  	fputs(message, stderr);
  	return;

Re: [Rlib-devel] RPDF fix for Windows

[Bob D. <bd...@si...>]

Hi,

Applied!  Thanks!

- Bob

On Thu, 2007-10-04 at 20:40 +0200, Zoltan Boszormenyi wrote:
> Hi,
> 
> there's a problem in RPDF when embedding images.
> It's because open() defaults to LF->CRLF translation
> without O_BINARY flag. This makes interpreting
> PNG and JPG chunk difficult, and actually skips
> embedding the file stream into the resulting PDF file.
> The fix is to use O_BINARY in the open() flags,
> but define it to 0 on sane systems to avoid compilation error.
> 
> Best regards,
> Zoltán Böszörményi
> 
-- 
Bob Doan
Vice President of Information Technology
SICOM Systems
bd...@si...
800-547-4266 x217

[Rlib-devel] RPDF fix for Windows

[Zoltan B. <zb...@du...>]

Hi,

there's a problem in RPDF when embedding images.
It's because open() defaults to LF->CRLF translation
without O_BINARY flag. This makes interpreting
PNG and JPG chunk difficult, and actually skips
embedding the file stream into the resulting PDF file.
The fix is to use O_BINARY in the open() flags,
but define it to 0 on sane systems to avoid compilation error.

Best regards,
Zolt=E1n B=F6sz=F6rm=E9nyi

Re: [Rlib-devel] Fixes for Windows compilation

[Bob D. <bd...@si...>]

Applied

Thanks!

- Bob

On Tue, 2007-09-04 at 15:09 +0200, Zoltan Boszormenyi wrote:
> Hi,
> 
> there are two problems in the current CVS version
> that prevents successful compilation in Windows
> with current MinGW: neither localtime_r() nor
> strcasestr() exist. Patch is attached.
> 
> Best regards,
> Zoltán Böszörményi
> 
> -------------------------------------------------------------------------
> This SF.net email is sponsored by: Splunk Inc.
> Still grepping through log files to find problems?  Stop.
> Now Search log events and configuration files using AJAX and a browser.
> Download your FREE copy of Splunk now >>  http://get.splunk.com/
> _______________________________________________ Rlib-devel mailing list Rli...@li... https://lists.sourceforge.net/lists/listinfo/rlib-devel
-- 
Bob Doan
Vice President of Information Technology
SICOM Systems
bd...@si...
800-547-4266 x217