From: Shannon W. <we...@ro...> - 2005-05-14 15:41:00
|
Greets, I worked on tracking the HTML problems down more. I found where the problem is, but couldn't muster the skill to eradicate it. The first problem was the one I mentioned in the last email - if trim_links is turned on, it's not closing <span> tags for bgcolor in some cases. The fix I had for that is attached. The next problem is related and again specific to trim_links and bgcolor. The problem appears to be in rlib_layout_find_common_properties_in_a_line(), which also gets my nomination for Longest Function name. The second part of the function loops through extra_data looking for where to start and stop link flags. But if trim links is on there is a bgcolor for that Line then in some situations it gets out of sync and again ends up with mismatched <span> tags. This all happens around lines 637-662 in layout.c I've attached a sample php script and xml report file that demonstrates the problem in various ways (including a work around). Also it demonstrates the fact that trim_links only works if the link text is left aligned and doesn't work if it's center or right aligned. Bob, regarding the new Doc Wiki - I think it's a great idea. I'd love to contribute but unfortunately I'm one of the one's in the dark about most of the functionality that's not documented in the current docs :) Thanks, Shannon |