Re: [Rlib-devel] [PATCH] Use ZLIB to compress page contents

[Bob D. <bd...@si...>]

Nice!!!!!

I applied it.. It works great!

On Thu, 2006-03-16 at 23:41 +0100, Zoltan Boszormenyi wrote:
> Hi,
>=20
> finally here's the change you requested. I also attached the dynamic
> object numbering patch as as it may enable some future improvements
> and the compression was made on top of that.
>=20
> The compression is a global setting, basically it is used in
> rpdf_finalize()
> when the PDF pages are written out.
>=20
> I am sorry that it took so long, I was occupied elsewhere.
>=20
> Best regards,
> Zolt=C3=A1n B=C3=B6sz=C3=B6rm=C3=A9nyi
>=20
> Bob Doan =C3=ADrta:=20
> > Hi,
> >=20
> > Patch looks good except I would prefer compression be optional at run
> > time as well.  If we had something like:
> >=20
> > rpdf_enable_compression(struct rpdf *pdf, gboolean setting)
> >=20
> > And have a flag in the rpdf struct. =20
> > We could then have an output parameter in rlib to set it on.
> >=20
> > Thanks!
> >=20
> > - Bob
> >=20
> > On Sun, 2006-01-22 at 15:26 +0100, Zoltan Boszormenyi wrote:
> >  =20
> > > Hi,
> > >=20
> > > Zoltan Boszormenyi =C3=ADrta:
> > >=20
> > >    =20
> > > > Now it's getting embarrassing... Fix again. Use this patch instea=
d of=20
> > > > the previous.
> > > >=20
> > > > Zoltan Boszormenyi =C3=ADrta:
> > > >=20
> > > >      =20
> > > > > Another fix. :-( This time incremental against the previous one.
> > > > > - Don't free something I didn't allocated.
> > > > > - Some white space fixes.
> > > > >        =20
> > > >=20
> > > > Also check the return value of deflateEnd(), too.
> > > >=20
> > > > Best regards,
> > > > Zolt=C3=A1n B=C3=B6sz=C3=B6rm=C3=A9nyi
> > > >      =20
> > > here's a slightly cheaper version of the patch, as deflateInit()
> > > is done only in rpdf_new() and deflateEnd() is done in rpdf_free().
> > > Instead, deflateReset() is used in rpdf_add_page_content_compressed=
().
> > >=20
> > > $ time for i in `seq 1 1000` ; do ./test >test1.pdf ; done
> > >=20
> > > real    0m2.359s
> > > user    0m1.041s
> > > sys     0m1.311s
> > >=20
> > > Now the 1000 iterations took only 201 msecs more than without compr=
ession.
> > > Also, should any error happen during compression, the next content =
won't be
> > > compressed. It should only happen under OOM condition and I guess i=
t's=20
> > > very unlikely.
> > >=20
> > > Best regards,
> > > Zolt=C3=A1n B=C3=B6sz=C3=B6rm=C3=A9nyi
> > >=20
> > >    =20
> >=20
> >=20
> >=20
> > -------------------------------------------------------
> > This SF.net email is sponsored by: Splunk Inc. Do you grep through lo=
g files
> > for problems?  Stop!  Download the new AJAX search engine that makes
> > searching your log files as easy as surfing the  web.  DOWNLOAD SPLUN=
K!
> > http://sel.as-us.falkag.net/sel?cmd=3Dk&kid=103432&bid#0486&dat=12164=
2
> > _______________________________________________
> > Rlib-devel mailing list
> > Rli...@li...
> > https://lists.sourceforge.net/lists/listinfo/rlib-devel
> >=20
> >  =20
>=20