Re: [Rlib-devel] Design purpose of rlib_value_dup_contents?

[Bob D. <bd...@si...>]

It's only used in rlib_layout_execute_pcodes_for_line

It's used for things on a line (image, literal, text) that don't have a
specific property that a line done.  Like if a line had a bgcolor of
'red' but the field did not specify the bgcolor so the field would
inherit the value of the line

It's duped because the value is manipulated later in the code, then
freed.  

Most of the time it is kinda untouched and this is the one place in the
RLIB code ref counting RVALS would be more efficient instead of
duplicating.  However moving to this would be a little work and odds are
things would break.  It might be a little late in the release cycle to
tackle this one.  

But it you want to fix this and not break anything go for it ;)

- bob

On Sun, 2005-06-05 at 14:13 -0600, William K. Volkman wrote:
> On the surface this code looks like it's designed to leak,
> I can however imagine a use case so I thought I better ask.
> 
> struct rlib_value * rlib_value_dup_contents(struct rlib_value *rval) {
> 	if(rval->type == RLIB_VALUE_STRING)
> 		rval->string_value = g_strdup(rval->string_value);
> 	return rval;
> }
> 
> I'm going to comment it out and see what happens.
> 
> Thanks for any insight.
> 
> Cheers,
> William.
> 
> 
> 
> -------------------------------------------------------
> This SF.Net email is sponsored by: NEC IT Guy Games.  How far can you shotput
> a projector? How fast can you ride your desk chair down the office luge track?
> If you want to score the big prize, get to know the little guy.  
> Play to win an NEC 61" plasma display: http://www.necitguy.com/?r=20
> _______________________________________________
> Rlib-devel mailing list
> Rli...@li...
> https://lists.sourceforge.net/lists/listinfo/rlib-devel
-- 
Bob Doan <bd...@si...>