Re: My latest megapatch, was Re: [Rlib-devel] RLIB-1.3.2 questions, problems and an ODBC fix

[Zoltan B. <zb...@du...>]

Bob Doan =EDrta:
> Thanks!!!

BTW most of the GCC4 warnings were harmless, i.e.
variable assignments between (pointers to/array of)
chars of different signedness.

Three of the fixes may have cured my crash.
Look at the changes of layout.c:rlib_encode_text() ,
formatstring.c:rlib_format_string_default() and
pcode_op_functions.c:rlib_pcode_operator_str().

These fixed int/long size differences on my 64-bit machine.
Any of these may have caused silent (most probably) stack or
(less likely) heap corruption that made RLIB crash at very
distant and unrelated functions.

>>One thing, though. Are you sure about your change in
>>rlib_set_datasource_encoding()?
>>As it stands in the CVS, line 407 of libsrc/api.c is
>>
>>	tif->info.encoder =3D rlib_charencoder_new(encoding, "UTF-8");
>>
>>rlib_charencoder_new() takes the parameters in (to, from) order.
>>
>>I changed it in my patch to the order I originally proposed:
>>
>>	tif->info.encoder =3D rlib_charencoder_new("UTF-8", encoding);
>>
>>So when the datasource is read, the strings are converted from the set
>>encoding to UTF-8 and it's paired with rlib_set_output_encoding() so
>>when outputting the internally UTF-8 strings are converted from UTF-8
>>to the set output encoding.
>=20
>=20
> Thats probably correct :)
>=20
> It's Friday ;)

I understand that. :-)

> I'll review the patch over the weekend.

Thanks.

Best regards,
Zolt=E1n B=F6sz=F6rm=E9nyi