Re: My latest megapatch, was Re: [Rlib-devel] RLIB-1.3.2 questions, problems and an ODBC fix

[Bob D. <bd...@si...>]

Thanks!!!

> One thing, though. Are you sure about your change in
> rlib_set_datasource_encoding()?
> As it stands in the CVS, line 407 of libsrc/api.c is
> 
> 	tif->info.encoder = rlib_charencoder_new(encoding, "UTF-8");
> 
> rlib_charencoder_new() takes the parameters in (to, from) order.
> 
> I changed it in my patch to the order I originally proposed:
> 
> 	tif->info.encoder = rlib_charencoder_new("UTF-8", encoding);
> 
> So when the datasource is read, the strings are converted from the set
> encoding to UTF-8 and it's paired with rlib_set_output_encoding() so
> when outputting the internally UTF-8 strings are converted from UTF-8
> to the set output encoding.

Thats probably correct :)

It's Friday ;)

I'll review the patch over the weekend.

- bob