[Revisionmanager-devel] Re: RevisionManager and ZopeTree on sourceforge now
Brought to you by:
philikon
|
From: Arthur C. C. C. <ar...@so...> - 2003-10-28 03:27:27
|
Cool, I will fix it in the RevisionManager.py and put it in the changes.txt later. And I will keep the list comprehension. On Mon, 27 Oct 2003 08:56:45 +0100, Philipp von Weitershausen wrote > Arthur, > > (I'm CC-ing the developing list) > > > btw, I have a quick question about RM.py > > ***************************************** > > In addChildPaths(self, paths): > > I changed the following: > > > > for module_path in module_paths: > > if module_path.startswith(path+'/') and module_path not in all_paths: > > sub_paths.append( module_path) > > > > #sub_paths = [module_path for module_path in module_paths > > # if module_path.startswith(path+'/')] > > If your code fixes a problem, it should go in. However, I recommend > keeping the list comprehension. List comprehensions on large lists > are much faster than for loops. > > Philipp -- Open WebMail Project (http://openwebmail.org) |