You can subscribe to this list here.
2007 |
Jan
|
Feb
|
Mar
|
Apr
|
May
|
Jun
|
Jul
(3) |
Aug
(3) |
Sep
(4) |
Oct
(1) |
Nov
|
Dec
|
---|
From: <bil...@us...> - 2007-10-07 19:06:32
|
Revision: 14 http://reviewmonk.svn.sourceforge.net/reviewmonk/?rev=14&view=rev Author: billmonkscott Date: 2007-10-07 12:05:49 -0700 (Sun, 07 Oct 2007) Log Message: ----------- Adding session id to base application controller for tracker #1797533. Modified Paths: -------------- trunk/app/controllers/application.rb Modified: trunk/app/controllers/application.rb =================================================================== --- trunk/app/controllers/application.rb 2007-09-24 05:53:07 UTC (rev 13) +++ trunk/app/controllers/application.rb 2007-10-07 19:05:49 UTC (rev 14) @@ -2,7 +2,7 @@ # Likewise, all the methods added will be available for all controllers. class ApplicationController < ActionController::Base # Don't expire the session any time soon - session :session_expires => 1.year.from_now + session :session_expires => 1.year.from_now, :session_key => 'ReviewMonk_session_id' helper_method :hostname, :appname This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site. |
From: <bil...@us...> - 2007-09-24 05:53:10
|
Revision: 13 http://reviewmonk.svn.sourceforge.net/reviewmonk/?rev=13&view=rev Author: billmonkscott Date: 2007-09-23 22:53:07 -0700 (Sun, 23 Sep 2007) Log Message: ----------- Removing deprecated end_form_tag to fix tracker issue #1797559. Modified Paths: -------------- trunk/app/views/codereview/diff.rhtml Modified: trunk/app/views/codereview/diff.rhtml =================================================================== --- trunk/app/views/codereview/diff.rhtml 2007-09-23 20:26:48 UTC (rev 12) +++ trunk/app/views/codereview/diff.rhtml 2007-09-24 05:53:07 UTC (rev 13) @@ -2,15 +2,15 @@ <h3>File: <%= link_to @relative_file, :action=> 'file', :id => @relative_file %></h3> <% if @from_revisions and @to_revisions %> -<%= form_tag :action => 'diff' %> +<% form_tag :action => 'diff' do %> Compare: <%= select_tag('from', options_for_select( @from_revisions, @from ) ) %> to <%= select_tag('to', options_for_select( @to_revisions, @to ) ) %> <%= submit_tag('Diff') %><br> <br> -<%= end_form_tag %> <% end %> +<% end %> <% url = url_for(:params => {:full_file => !@full_file, :from => @from, :to => @to}) %> Show full file <%= check_box_tag('full_file', '1', @full_file, :onchange => "document.location.href='#{url}';") %> This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site. |
From: <bil...@us...> - 2007-09-23 20:26:50
|
Revision: 12 http://reviewmonk.svn.sourceforge.net/reviewmonk/?rev=12&view=rev Author: billmonkscott Date: 2007-09-23 13:26:48 -0700 (Sun, 23 Sep 2007) Log Message: ----------- Fixing REAME documentation for the settings.yaml path. This fixes defect #1797532. Modified Paths: -------------- trunk/README Modified: trunk/README =================================================================== --- trunk/README 2007-09-23 20:24:12 UTC (rev 11) +++ trunk/README 2007-09-23 20:26:48 UTC (rev 12) @@ -26,7 +26,7 @@ Configuration: ------------- If you open up the settings file in your favorite editor... - lib/settings.yaml + config/settings.yml You can see that there are a number of options you may wish to change based on your environment. This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site. |
From: <bil...@us...> - 2007-09-23 20:24:13
|
Revision: 11 http://reviewmonk.svn.sourceforge.net/reviewmonk/?rev=11&view=rev Author: billmonkscott Date: 2007-09-23 13:24:12 -0700 (Sun, 23 Sep 2007) Log Message: ----------- Checking if the project root directory exists, and if all other executables exists when loading them from the YamlSettings. This fixes tracker #1797534. Modified Paths: -------------- trunk/app/controllers/codereview_controller.rb Modified: trunk/app/controllers/codereview_controller.rb =================================================================== --- trunk/app/controllers/codereview_controller.rb 2007-09-23 18:50:32 UTC (rev 10) +++ trunk/app/controllers/codereview_controller.rb 2007-09-23 20:24:12 UTC (rev 11) @@ -8,19 +8,35 @@ class CodereviewController < ApplicationController def projects_home - YamlSettingsSingleton.instance['subversion']['project_root'] + projects_home = YamlSettingsSingleton.instance['subversion']['project_root'] + unless File.directory? projects_home + raise "project_root '#{projects_home}' is not a directory. Check your settings.yml and try again." + end + projects_home end def svn_cmd - YamlSettingsSingleton.instance['subversion']['svn'] + svn = YamlSettingsSingleton.instance['subversion']['svn'] + unless File.executable? svn + raise "svn '#{svn}' is not an executable. Check your settings.yml and try again." + end + svn end def diff_cmd - YamlSettingsSingleton.instance['subversion']['diff'] + diff = YamlSettingsSingleton.instance['subversion']['diff'] + unless File.executable? diff + raise "diff '#{diff}' is not an executable. Check your settings.yml and try again." + end + diff end def cat_cmd - YamlSettingsSingleton.instance['subversion']['cat'] + cat = YamlSettingsSingleton.instance['subversion']['cat'] + unless File.executable? cat + raise "cat '#{cat}' is not an executable. Check your settings.yml and try again." + end + cat end def get_revisions(file) This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site. |
From: <bil...@us...> - 2007-09-23 18:50:34
|
Revision: 10 http://reviewmonk.svn.sourceforge.net/reviewmonk/?rev=10&view=rev Author: billmonkscott Date: 2007-09-23 11:50:32 -0700 (Sun, 23 Sep 2007) Log Message: ----------- Changing shebang lines from "#!/usr/bin/ruby1.8" to "#!/usr/bin/env ruby" for portability. This fixes tracker #1797545. Modified Paths: -------------- trunk/script/about trunk/script/breakpointer trunk/script/console trunk/script/destroy trunk/script/generate trunk/script/performance/benchmarker trunk/script/performance/profiler trunk/script/plugin trunk/script/process/reaper trunk/script/process/spawner trunk/script/process/spinner trunk/script/runner trunk/script/server Modified: trunk/script/about =================================================================== --- trunk/script/about 2007-08-09 23:49:12 UTC (rev 9) +++ trunk/script/about 2007-09-23 18:50:32 UTC (rev 10) @@ -1,3 +1,3 @@ -#!/usr/bin/ruby1.8 +#!/usr/bin/env ruby require File.dirname(__FILE__) + '/../config/boot' -require 'commands/about' \ No newline at end of file +require 'commands/about' Modified: trunk/script/breakpointer =================================================================== --- trunk/script/breakpointer 2007-08-09 23:49:12 UTC (rev 9) +++ trunk/script/breakpointer 2007-09-23 18:50:32 UTC (rev 10) @@ -1,3 +1,3 @@ -#!/usr/bin/ruby1.8 +#!/usr/bin/env ruby require File.dirname(__FILE__) + '/../config/boot' -require 'commands/breakpointer' \ No newline at end of file +require 'commands/breakpointer' Modified: trunk/script/console =================================================================== --- trunk/script/console 2007-08-09 23:49:12 UTC (rev 9) +++ trunk/script/console 2007-09-23 18:50:32 UTC (rev 10) @@ -1,3 +1,3 @@ -#!/usr/bin/ruby1.8 +#!/usr/bin/env ruby require File.dirname(__FILE__) + '/../config/boot' -require 'commands/console' \ No newline at end of file +require 'commands/console' Modified: trunk/script/destroy =================================================================== --- trunk/script/destroy 2007-08-09 23:49:12 UTC (rev 9) +++ trunk/script/destroy 2007-09-23 18:50:32 UTC (rev 10) @@ -1,3 +1,3 @@ -#!/usr/bin/ruby1.8 +#!/usr/bin/env ruby require File.dirname(__FILE__) + '/../config/boot' -require 'commands/destroy' \ No newline at end of file +require 'commands/destroy' Modified: trunk/script/generate =================================================================== --- trunk/script/generate 2007-08-09 23:49:12 UTC (rev 9) +++ trunk/script/generate 2007-09-23 18:50:32 UTC (rev 10) @@ -1,3 +1,3 @@ -#!/usr/bin/ruby1.8 +#!/usr/bin/env ruby require File.dirname(__FILE__) + '/../config/boot' -require 'commands/generate' \ No newline at end of file +require 'commands/generate' Modified: trunk/script/performance/benchmarker =================================================================== --- trunk/script/performance/benchmarker 2007-08-09 23:49:12 UTC (rev 9) +++ trunk/script/performance/benchmarker 2007-09-23 18:50:32 UTC (rev 10) @@ -1,3 +1,3 @@ -#!/usr/bin/ruby1.8 +#!/usr/bin/env ruby require File.dirname(__FILE__) + '/../../config/boot' require 'commands/performance/benchmarker' Modified: trunk/script/performance/profiler =================================================================== --- trunk/script/performance/profiler 2007-08-09 23:49:12 UTC (rev 9) +++ trunk/script/performance/profiler 2007-09-23 18:50:32 UTC (rev 10) @@ -1,3 +1,3 @@ -#!/usr/bin/ruby1.8 +#!/usr/bin/env ruby require File.dirname(__FILE__) + '/../../config/boot' require 'commands/performance/profiler' Modified: trunk/script/plugin =================================================================== --- trunk/script/plugin 2007-08-09 23:49:12 UTC (rev 9) +++ trunk/script/plugin 2007-09-23 18:50:32 UTC (rev 10) @@ -1,3 +1,3 @@ -#!/usr/bin/ruby1.8 +#!/usr/bin/env ruby require File.dirname(__FILE__) + '/../config/boot' -require 'commands/plugin' \ No newline at end of file +require 'commands/plugin' Modified: trunk/script/process/reaper =================================================================== --- trunk/script/process/reaper 2007-08-09 23:49:12 UTC (rev 9) +++ trunk/script/process/reaper 2007-09-23 18:50:32 UTC (rev 10) @@ -1,3 +1,3 @@ -#!/usr/bin/ruby1.8 +#!/usr/bin/env ruby require File.dirname(__FILE__) + '/../../config/boot' require 'commands/process/reaper' Modified: trunk/script/process/spawner =================================================================== --- trunk/script/process/spawner 2007-08-09 23:49:12 UTC (rev 9) +++ trunk/script/process/spawner 2007-09-23 18:50:32 UTC (rev 10) @@ -1,3 +1,3 @@ -#!/usr/bin/ruby1.8 +#!/usr/bin/env ruby require File.dirname(__FILE__) + '/../../config/boot' require 'commands/process/spawner' Modified: trunk/script/process/spinner =================================================================== --- trunk/script/process/spinner 2007-08-09 23:49:12 UTC (rev 9) +++ trunk/script/process/spinner 2007-09-23 18:50:32 UTC (rev 10) @@ -1,3 +1,3 @@ -#!/usr/bin/ruby1.8 +#!/usr/bin/env ruby require File.dirname(__FILE__) + '/../../config/boot' require 'commands/process/spinner' Modified: trunk/script/runner =================================================================== --- trunk/script/runner 2007-08-09 23:49:12 UTC (rev 9) +++ trunk/script/runner 2007-09-23 18:50:32 UTC (rev 10) @@ -1,3 +1,3 @@ -#!/usr/bin/ruby1.8 +#!/usr/bin/env ruby require File.dirname(__FILE__) + '/../config/boot' -require 'commands/runner' \ No newline at end of file +require 'commands/runner' Modified: trunk/script/server =================================================================== --- trunk/script/server 2007-08-09 23:49:12 UTC (rev 9) +++ trunk/script/server 2007-09-23 18:50:32 UTC (rev 10) @@ -1,3 +1,3 @@ -#!/usr/bin/ruby1.8 +#!/usr/bin/env ruby require File.dirname(__FILE__) + '/../config/boot' -require 'commands/server' \ No newline at end of file +require 'commands/server' This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site. |
From: <bil...@us...> - 2007-08-09 23:49:13
|
Revision: 9 http://reviewmonk.svn.sourceforge.net/reviewmonk/?rev=9&view=rev Author: billmonkscott Date: 2007-08-09 16:49:12 -0700 (Thu, 09 Aug 2007) Log Message: ----------- Making file page look better with added project heading similar to diff page Modified Paths: -------------- branches/windows/app/views/codereview/file.rhtml Modified: branches/windows/app/views/codereview/file.rhtml =================================================================== --- branches/windows/app/views/codereview/file.rhtml 2007-08-09 23:48:20 UTC (rev 8) +++ branches/windows/app/views/codereview/file.rhtml 2007-08-09 23:49:12 UTC (rev 9) @@ -1,6 +1,7 @@ -<h3 style="margin-bottom: 0px; padding-bottom: 0px;">File: <%= @file_name %></h3> -<p style="font-size: small; margin-top: 0px;"><%=@file_path%></p> +<h2>Project: <%= link_to @project, :action => 'stat', :params => {:id => @project} %></h2> +<h3>File: <%= link_to @file_path, :action=> 'file', :id => @file_path %></h3> + <p><b>Revision:</b> <%= @revision %> <%=link_to '(Diff)', :action => 'diff', :id => @file_path %></p> <div class="box"> This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site. |
From: <bil...@us...> - 2007-08-09 23:48:33
|
Revision: 8 http://reviewmonk.svn.sourceforge.net/reviewmonk/?rev=8&view=rev Author: billmonkscott Date: 2007-08-09 16:48:20 -0700 (Thu, 09 Aug 2007) Log Message: ----------- Moving to using pathname in a number of places for cross-platform fixes Modified Paths: -------------- branches/windows/app/controllers/codereview_controller.rb Modified: branches/windows/app/controllers/codereview_controller.rb =================================================================== --- branches/windows/app/controllers/codereview_controller.rb 2007-08-09 23:47:10 UTC (rev 7) +++ branches/windows/app/controllers/codereview_controller.rb 2007-08-09 23:48:20 UTC (rev 8) @@ -4,6 +4,7 @@ require 'escape' require 'escape_extensions' require 'yaml_settings' +require 'pathname' class CodereviewController < ApplicationController @@ -56,12 +57,17 @@ end def get_directory_root( cwd ) - cwd.split('/').flatten.at(0) + # HACK - there seems to be no really good get_directory_root or split for File or Pathname, + # so we're left with this ugly mess. + if Kernel.is_windows? + cwd.split('\\').flatten.at(1) + else + cwd.split('/').flatten.at(0) + end end def get_directory_parent( cwd ) - path = cwd.split('/').flatten - File.join(path[0, path.length-1]) + Pathname.new( cwd ).parent end def line_count( filename ) @@ -89,7 +95,7 @@ @show_all = session[:show_all] @show_diff = session[:show_diff] @recursive = session[:recursive] - @cwd = params[:id] + @cwd = File.join(params[:id]) @files = Array.new @projects_home = projects_home() @@ -136,7 +142,7 @@ def diff if params[:id] - @relative_file = params[:id].join('/') + @relative_file = File.join( params[:id] ) end if @relative_file.nil? @@ -185,7 +191,7 @@ def file if params[:id] @file_path = File.join(params[:id]) - @relative_file = @file_path[projects_home().length..-1] + @project = get_directory_root( @file_path ) end if @file_path.nil? @@ -193,7 +199,7 @@ return end - @file_name = @file_path.split('/').flatten[-1] + @file_name = Pathname.new(@file_path).basename if params[:rev] and params[:rev] != '0' @revision = params[:rev] @@ -208,11 +214,11 @@ command = [svn_cmd, 'cat', '-r', @revision ] end - @projects_home = projects_home() - command.push( projects_home + @file_path ) + @projects_home = projects_home() + command.push( File.join(projects_home, @file_path) ) logger.debug "command = #{Escape.shell_command( command )} 2>&1" @file = `#{Escape.shell_command( command )}` - @language = Syntax::Convertors::HTML.detect_syntax( File.extname(@relative_file).sub(/\./, '') ) + @language = Syntax::Convertors::HTML.detect_syntax( File.extname(@file_path).sub(/\./, '') ) convertor = Syntax::Convertors::HTML.for_syntax @language @file_html = convertor.convert(@file, false) end This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site. |
From: <bil...@us...> - 2007-08-09 23:47:16
|
Revision: 7 http://reviewmonk.svn.sourceforge.net/reviewmonk/?rev=7&view=rev Author: billmonkscott Date: 2007-08-09 16:47:10 -0700 (Thu, 09 Aug 2007) Log Message: ----------- ugly hack for windows - subversion flips the directory slashes - so we flip them back Modified Paths: -------------- branches/windows/app/helpers/application_helper.rb Modified: branches/windows/app/helpers/application_helper.rb =================================================================== --- branches/windows/app/helpers/application_helper.rb 2007-07-31 21:35:36 UTC (rev 6) +++ branches/windows/app/helpers/application_helper.rb 2007-08-09 23:47:10 UTC (rev 7) @@ -1,4 +1,6 @@ # Methods added to this helper will be available to all templates in the application. +require 'platform' + module ApplicationHelper def pretty_diff(diff, root_directory) return unless diff @@ -28,11 +30,13 @@ if line =~ /^\+\+\+/ revision = line[/[0-9]+/] file = line[/^\+\+\+ *([^ ]*) *\(/, 1].chop + file.gsub!('/', '\\') if Kernel.is_windows? file.gsub!(root_directory, '') line_output << content_tag( 'div', link_to( line, { :action => :file, :id => file, :params => {:rev => revision} }, { :class => diff_class }), :class => diff_class ) elsif line =~ /^\-\-\-/ revision = line[/[0-9]+/] file = line[/^\-\-\- *([^ ]*) *\(/, 1].chop + file.gsub!('/', '\\') if Kernel.is_windows? file.gsub!(root_directory, '') line_output << content_tag( 'div', link_to( line, { :action => :file, :id => file, :params => {:rev => revision} }, { :class => diff_class }), :class => diff_class ) else This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site. |
From: <bil...@us...> - 2007-07-31 21:35:37
|
Revision: 6 http://reviewmonk.svn.sourceforge.net/reviewmonk/?rev=6&view=rev Author: billmonkscott Date: 2007-07-31 14:35:36 -0700 (Tue, 31 Jul 2007) Log Message: ----------- Requiring escape extensions to handle windows shell commands, and moving to always using File.join rather than join('/') for path joins. Modified Paths: -------------- branches/windows/app/controllers/codereview_controller.rb Modified: branches/windows/app/controllers/codereview_controller.rb =================================================================== --- branches/windows/app/controllers/codereview_controller.rb 2007-07-31 21:32:26 UTC (rev 5) +++ branches/windows/app/controllers/codereview_controller.rb 2007-07-31 21:35:36 UTC (rev 6) @@ -1,8 +1,8 @@ - require 'syntax' require 'syntax/convertors/html' require 'syntax_extensions' require 'escape' +require 'escape_extensions' require 'yaml_settings' class CodereviewController < ApplicationController @@ -61,7 +61,7 @@ def get_directory_parent( cwd ) path = cwd.split('/').flatten - path[0, path.length-1].join('/') + File.join(path[0, path.length-1]) end def line_count( filename ) @@ -105,17 +105,23 @@ end command << project_dir + logger.debug "command = #{Escape.shell_command( command )}" stat = `#{Escape.shell_command( command )}` - stat.split("\n").each do |line| - next if line == '' or line["Performing"] + logger.debug "stat = #{stat}" + if not stat.nil? + stat.split("\n").each do |line| + next if line == '' or line["Performing"] - anArray = line.split(' ') - file = Hash.new - file['stat'] = anArray[0] - filename = anArray[anArray.length-1] - file['filename'] = filename.sub( @projects_home, '') - - @files << file if @show_all || (!@show_all && file['stat'] != "?") + anArray = line.split(' ') + file = Hash.new + file['stat'] = anArray[0] + filename = anArray[anArray.length-1] + logger.debug "filename = #{filename}" + logger.debug "projects_home = #{@projects_home}" + file['filename'] = filename.sub( @projects_home.gsub('/', '\\'), '') + logger.debug "filename = #{filename}" + @files << file if @show_all || (!@show_all && file['stat'] != "?") + end end if @show_diff command = [svn_cmd, 'diff'] @@ -167,6 +173,7 @@ end command << @file + logger.debug "command = #{Escape.shell_command( command )}" @diff = `#{Escape.shell_command( command )}` @to_revisions = ['working copy'] @from_revisions = ['HEAD', 'BASE'] @@ -177,7 +184,7 @@ def file if params[:id] - @file_path = params[:id].join('/') + @file_path = File.join(params[:id]) @relative_file = @file_path[projects_home().length..-1] end @@ -185,9 +192,9 @@ @file_name = "No filename specified" return end + + @file_name = @file_path.split('/').flatten[-1] - @file_name = @file_path.split('/').flatten[-1] - if params[:rev] and params[:rev] != '0' @revision = params[:rev] else @@ -203,7 +210,8 @@ @projects_home = projects_home() command.push( projects_home + @file_path ) - @file = `#{Escape.shell_command( command )} 2>&1` + logger.debug "command = #{Escape.shell_command( command )} 2>&1" + @file = `#{Escape.shell_command( command )}` @language = Syntax::Convertors::HTML.detect_syntax( File.extname(@relative_file).sub(/\./, '') ) convertor = Syntax::Convertors::HTML.for_syntax @language @file_html = convertor.convert(@file, false) This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site. |
From: <bil...@us...> - 2007-07-31 21:32:28
|
Revision: 5 http://reviewmonk.svn.sourceforge.net/reviewmonk/?rev=5&view=rev Author: billmonkscott Date: 2007-07-31 14:32:26 -0700 (Tue, 31 Jul 2007) Log Message: ----------- Adding class to determine platform, as well as extension to the escape gem to properly escape windows shell commands. Added Paths: ----------- branches/windows/lib/escape_extensions.rb branches/windows/lib/platform.rb Added: branches/windows/lib/escape_extensions.rb =================================================================== --- branches/windows/lib/escape_extensions.rb (rev 0) +++ branches/windows/lib/escape_extensions.rb 2007-07-31 21:32:26 UTC (rev 5) @@ -0,0 +1,28 @@ +require 'escape' +require 'platform' # for is_windows? + +module Escape + module_function + + def shell_single_word(str) + if str.empty? + "''" + elsif %r{\A[0-9A-Za-z+,./:=@_-]+\z} =~ str + str + else + result = '' + str.scan(/('+)|[^']+/) { + if $1 + result << %q{\'} * $1.length + else + if Kernel.is_windows? + result << "\"#{$&}\"" + else + result << "'#{$&}'" + end + end + } + result + end + end +end Added: branches/windows/lib/platform.rb =================================================================== --- branches/windows/lib/platform.rb (rev 0) +++ branches/windows/lib/platform.rb 2007-07-31 21:32:26 UTC (rev 5) @@ -0,0 +1,7 @@ +# Returns true if we are running on a MS windows platform, false otherwise. +# from http://snippets.dzone.com/posts/show/2112 + +def Kernel.is_windows? + processor, platform, *rest = RUBY_PLATFORM.split("-") + platform == 'mswin32' +end This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site. |
From: <bil...@us...> - 2007-07-31 21:12:18
|
Revision: 4 http://reviewmonk.svn.sourceforge.net/reviewmonk/?rev=4&view=rev Author: billmonkscott Date: 2007-07-31 14:12:16 -0700 (Tue, 31 Jul 2007) Log Message: ----------- creating branch for adding windows support Added Paths: ----------- branches/windows/ Copied: branches/windows (from rev 3, trunk) This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site. |