Re: [Resteasy-developers] NettyHttpAsyncResponse & HTTP Keep-Alive

[Weinan Li <we...@re...>]

Hi Jamie,

Please feel free to submit PR and please create a JIRA issue relate with the PR: https://issues.jboss.org/projects/RESTEASY

--
Weinan Li / JBoss



> On Oct 26, 2015, at 8:54 PM, Jamie Astin <jam...@gm...> wrote:
> 
> All,
> 
> I write in reference to the Asynchronous HTTP capability of RestEasy. Specifically the NettyHttpAsyncResponse implementation.
> 
> There are numerous ways to complete the NettyHttpAsyncResponse, by calling one of the two overridden resume(...) implementations, or via the cancel() method. Regardless of which of these methods are invoked, they all (in turn) invoke nettyFlush() from their finally blocks.
> 
> The implementation of NettyHttpAsyncResponse.nettyFlush(), within it's own finally block, includes a call to ChannelHandlerContext.close(). This does not check for the presence of a HTTP keep-alive header.
> 
> Thus, I believe that any asynchronous response will result in the HTTP connection being discarded, regardless of requested keep-alive. 
> 
> Is there something I'm missing? Or would it be sensible to send over a pull request with a fix?
> 
> Any thoughts / pointers would be greatly appreciated.
> 
> Jamie.
> 
> ------------------------------------------------------------------------------
> _______________________________________________
> Resteasy-developers mailing list
> Res...@li...
> https://lists.sourceforge.net/lists/listinfo/resteasy-developers