[Resteasy-developers] Jsonp support

SourceForge Headquarters 1320 Columbia Street Suite 310 San Diego, CA 92101 +1 (858) 422-6466

Hi all,

Finally I've implemented the changes requested by Bill and submitted two pull requests. One for Master and one for Branch_2_3.
Please apologize that it took so long.

Kind regards,
Holger

-----Original Message-----
From: Morch Holger (Nokia-LC/Schwalbach)
Sent: Dienstag, 25. September 2012 16:33
To: 'ext Bill Burke'
Subject: RE: jsonp commit

Hi Bill,

Sadly I'm a bit busy at the moment but I'll implement the requested changes, unit test and documentation as soon as possible. For the unit test I'll have to look how you're running tests without an server. But I think I'll find examples.

> * Are you sure it should be registered as a built-in interceptor?  Maybe it should be something enabled by the user?
I think it can be a built-in interceptor. The interceptor is part of the Jackson package. So it is only loaded if Jackson is active. It respects the @NoJackson annotation and it is only activated if the callback query parameter is present. So I think it is a nice feature which works out of the box.

Kind regards,
Holger

-----Original Message-----
From: ext Bill Burke [mailto:bb...@re...]
Sent: Donnerstag, 20. September 2012 00:36
To: Morch Holger (Nokia-LC/Schwalbach)
Subject: jsonp commit

Very Nice commit, but...a few things before I can accept it:

* Can you rewrite it as a new JAX-RS 2.0 WriterInterceptor?

* I do not see a unit test for it.

* Are you sure it should be registered as a built-in interceptor?  Maybe it should be something enabled by the user?

* Finally, you need to add a description of this feature to our documentation (docbook). Otherwise, nobody will know it exists.

Thanks for contributing!  If you don't have time for any of those let me know.  I'll just accept the pull request and do it myself eventually.

--
Bill Burke
JBoss, a division of Red Hat
http://bill.burkecentral.com

The information contained in this communication may be CONFIDENTIAL and is intended only for the use of the recipient(s) named above.  If you are not the intended recipient, you are hereby notified that any dissemination, distribution, or copying of this communication, or any of its contents, is strictly prohibited.  If you have received this communication in error, please notify the sender and delete/destroy the original message and any copy of it from your computer or paper files.