|
From: Bill B. <bb...@re...> - 2008-07-08 22:33:01
|
Martin, couple problems with your commit: 1) You broke other tests that depended on 400. Please run whole testsuite next time, thanks. 2) I believe, after looking at those broken tests, that I ported the test from Jersey's testsuite. This means that we might have to change the behavior back to the way it was. We'll see what happens with the TCK. Bill Burke wrote: > Would be cool to have a regression unit test that duplicates the > problems you and ryan are seeing too. > > Bill Burke wrote: >> Change the code to check for Failure (if it doesn't already) and rethrow >> that. >> >> Martin Algesten wrote: >>> In ResourceMethod.invoke() line 153, there's a try-catch that makes >>> all Failure exceptions thrown below be translated to 400. Is this >>> deliberate? To make NumberFormatException result in 404 I want to pass >>> my error code in the Failure exception, and then get that set in the >>> response. >>> >>> I've checked in a change where we always set the error code passed in >>> the Failure - it looks reasonable. >>> >>> Martin >>> >>> >>> ------------------------------------------------------------------------- >>> Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW! >>> Studies have shown that voting for your favorite open source project, >>> along with a healthy diet, reduces your potential for chronic lameness >>> and boredom. Vote Now at http://www.sourceforge.net/community/cca08 >>> _______________________________________________ >>> Resteasy-developers mailing list >>> Res...@li... >>> https://lists.sourceforge.net/lists/listinfo/resteasy-developers > -- Bill Burke JBoss, a division of Red Hat http://bill.burkecentral.com |