Re: [Rest2web-develop] ConfigObj 4 Beta 1

[Michael F. <mi...@pc...>]

Nicola Larosa wrote:
>>It would be appreciated if you could the zips and standalone files and
>>check they are 'unmangled' and the documentation files look ok from the
>>zip. I'm not at any kind of development station - so doing this myself
>>is a PITA.
> 
> 
> There's a number of issues, mainly minor. I list them in descending
> priority order.
> 
> 1. the zip file, *and* the main directory inside it, should be named
>    "configobj-4.0.0b1";
> 

Ok (This is the *highest* priority - the *name* of the zip file ? ;-)

> 2. we should have a simple "setup.py" file in there;
> 

Great if you can do one. I'm about to commit a setup.py  for
'pythonutils' though.... (marginally less trivial because it generates
the '.pth' file when used).

> 3. a friend of mine pointed out two problems:
> 
>   3a. the two doctests in the ConfigObj class docstring should raise
>       DuplicateError, but instead raise ConfigObjError;
> 

Ok - I'll leave you to sort it :-)

>   3b. we may want to try minimizing the usage of the isinstance
>       built-in, especially to allow passing dict-like objects that
>       are not subclasses of dict;
> 

What alternative do you suggest ?

``IsmappingType`` is hopeless (it returns ``True`` for *any* class). I
don't think restricting input to dicts or genuine subclasses is too
restrictive.

We could assume that any item with a ``__getitem__`` method *and* a
``keys`` method will behave like a dictionary ? (I'd be happy with this
as a solution - but it will need documenting).

> 4. we may want to omit the private API docs, by using the
>    "--no-private" switch of the epydoc command;
> 

I think that removes *all* the Section documentation. I don't have a
problem with distributing the private documentation - it's all nicely
written.

> 5. it would be nice to have a tar.gz file on Sourceforge, in addition
>    to the zip: it's smaller than the zip, and more "native" to Linux;
> 

I can upload it if you generate it :-)
Or I can add you to the sourceforge project ? (Let me know your user
name and I'll add you)

> 6. the "BSD-LICENSE.txt" and the generated HTML files have CRLF
>    line endings, while the sources have LF ones. Also, the
>    "configobj.txt" has LF ones, except for the HTML fragment at the
>    end, that has ten CRLF endings.
> 

Ok - I can sort this. Committing will remove the carriage returns from
configobj.txt.

I can remove them from the generated HTML. I've changed these slightly
anyway. I'm about to commit all my changes.

> I'll check issues 2. , 3a. and 3b . Let me know how to address issue 6. .
> 

Best Regards,


Fuzzy
http://www.voidspace.org.uk/python