Fantastic tool that I'm looking forward to extensively using; thanks a million! So much work!
I'm running Excel on a 64-bit machine, and the declare statements on several of your modules are missing the Ptrsafe declaration that 64-bit VBA requires. It's silly, but it's annoying to deal with the pop-up warning that happens each time you run a macro, and all it requires is the "Ptrsafe" declaration to be included before each "Declare" (see https://msdn.microsoft.com/en-us/library/office/ee691831(v=office.14).aspx).
I plan on directing more people to your tool, and I wondered if you could update the download with this in mind? That will prevent them from having to do it themselves. The code can be altered without affecting 32-bit machines at all.
Best regards and thanks again,
-Chilangosta
Thank you for the kind words. You are the first person to ever reach out to
me, so I'm very happy to know that somebody likes my humble little tool.
I will be happy to make the change you are requesting. Thank you for
sending the link to the article with the information. My computer is 64
bits, and Graphviz 32 bits, so I thought all was good. The article said
that office installs 32 bit by default, so I guess that is why I never
observed it. I'll have to reinstall office or find a 64 bit version to test
on, so most likely it will take me until the weekend to make and test the
change.
I will also get an answer for you on an open source license, and then you
should be free to spread the word.
Best regards,
Jeff Long
On Wed, Feb 1, 2017 at 7:44 PM Kyle Tuft chilangosta@users.sf.net wrote:
Related
Tickets:
#1Fantastic! Thanks for the prompt reply! I think this a great tool, given that Graphviz is one of the foremost graphing tools freely available, and Excel is one of the most widely used programs around, so your tool is greatly appreciated. You make Graphviz accessible to many that wouldn't otherwise be aware of it.
If it's any help, the declarations in question are just at the top of Pearson's modShellAndWait:
I think those 3
PtrSafemodifiers are the only changes needed!Thanks again!
The "PtrSafe" change has been made to the Excel Macro-enabled Template (xltm) file and all the samples. The hardest part of the change was for me to get my hands on a 64-bit version of Excel. Excel installs the 32 bit version by default, and has a nice little restriction that prevents you from switching to 64 bits if a 32 bit edition was previously installed. I had to track down a virgin PC without Office on it, and get the 64 bit media and a license key. Once I cleared that hurdle I was able to see the error occur, make the fix, and test it. The 3 modifications you presented were all the changes that needed to be made.
As to the Open Source License question, I've licensed it under the GNU General Public License v2.0. All VBA modules were updated to reference the license, I added the license disclaimer to the "about..." worksheet, and revised the users manual.
I did a little housekeeping while I was at it. I created a 'video' subdirectory in the distribution which has the two training videos, and a 'license' subdirectory with copies of the GNU GPL v2.0 license files. I also updated several screen prints in the users manual and elaborated on a couple of minor topics such as head and tail labels.
I did not convert all the sample spreadsheets over to the latest version, but I did make them "PtrSafe". For now they will be released without the license text embedded in them. That is the drawback of having the VBA code embedded in the spreadsheet. The data and logic are bound together. When I have more time I will get the samples synced with the template, but I knew you are eager for an update so I released the most essential stuff.
Let me know if you have more questions or need anything else, I'm here to help.
Jeff
The zip file published on 2017-02-05 contains the requested change to add the "ptrsafe" keyword to the function declarations. It has been tested on 32 bit and 64 bit versions of Excel.