#1 Made output format Regedit compatible

v1.9.x
unread
None
5
2013-03-06
2008-03-14
No

This patch makes registry difference output compatible with Regedit 5.0. The output file can also be exported into VS installer projects (after removing comment lines starting with ;)

Discussion

  • Aleksoft.net

    Aleksoft.net - 2008-03-18

    Updated patch

     
  • Aleksoft.net

    Aleksoft.net - 2008-03-18

    Logged In: YES
    user_id=1928816
    Originator: YES

    This is an improved patch which properly handles dword output plus some minor bug fixes.
    File Added: regshot.diff

     
  • M. Buecher

    M. Buecher - 2011-03-10

    Thanks for the patch. We will definitely have a look at it.

     
  • Aleksoft.net

    Aleksoft.net - 2011-03-11

    Glad to see the project revived.

     
  • XhmikosR

    XhmikosR - 2011-04-18

    Can you update the patch to apply to the latest trunk? And maybe add a few more comments in the source code which explain more about the changes.
    BTW, there's no need to include the makefile in the patch.

     
  • Aleksoft.net

    Aleksoft.net - 2011-04-22

    I've uploaded an updated RegEdit compatibility patch series here.
    The first three patches contain trivial changes.
    The first patch to enable the windres compile the resource file.
    Second - to shut up the compiler warning
    Third - introduce the MYREALLOC macro, which will be used in the last patch
    Fourth - the actual change

     
  • XhmikosR

    XhmikosR - 2011-04-22

    Hi. For starters, I don't see why you provide git diffs. Is the official repo a git repo? No, it's an svn repository and your patches won't apply using TortoiseSVN. I don't see why one should install and configure git or MSYSGit to apply your patches.

    1st patch: I don't know how you compile Regshot, but you should use the solution that is provided in the SVN. I have no problem building Regshot with GCC under MinGW with the provided Codeblocks projects. I get no errors or warnings. (well, I get a couple of warnings but nothing related to what you change here). So, if you get errors you should try using more recent versions of GCC/MinGW. I use v4.5.2. You can find the MSYS/MinGW packages I use in the following link if you are interested:

    http://xhmikosr.1f0.de/index.php?folder=dG9vbHM=

    Now, on a side note, I do prefer makefiles, I just didn't feel like creating one at the time I created the Codeblocks project. If you provide a makefile which should work in all cases, I'd be happy to commit it and remove the Codeblocks project.

    2nd patch: I don't get any warning regarding that code. So, please, shed some light on how you compile Regshot so that we are all on the same boat.

    3rd and 4th patch: I'll leave this to someone else to review. But if no one does it, maybe it should go in as long as you confirm that there are no problems, i.e. it's been tested enough.

     
  • Aleksoft.net

    Aleksoft.net - 2011-04-22
     
  • Aleksoft.net

    Aleksoft.net - 2011-04-22

    Hi.
    You can scratch off the #1, I don't know why, but now it seems like it works OK as is. At first, it didn't give me any warnings, but the resulting exe had no icon, and upon start didn't show GUI at all, though the process was running.

    2

    $ make
    windres -Ocoff -iregshot.rc -o resource.o
    gcc -c .c
    winmain.c: In function 'WinMain':
    winmain.c:499:5: warning: passing argument 4 of 'CreateDialogParamA' from incompatible pointer type
    c:\mingw\bin../lib/gcc/mingw32/4.5.0/../../../../include/winuser.h:3544:24: note: expected 'DLGPROC' but argument is of type 'LRESULT (
    )(struct HWND__ , UINT, WPARAM, LPARAM)'
    gcc -O0 -o Regshot.exe
    .o -mwindows

    BTW, Does it matter how I generate the diffs? Diffs are diffs. I don't know about the TortoiseSVN, but the patches apply cleanly
    from the msys shell like this:

    patch < 0003*

    I use the GCC 4.5.0 at the moment.

     
  • XhmikosR

    XhmikosR - 2011-12-31

    1 is ignored then.

    2 committed

    3 Not sure why is that needed if it's not used

    4 tianwei or maddes should have a look

    I have committed my own makefile. There are a couple of things I want to do but it works as it is now.

     
  • Matt Cox

    Matt Cox - 2012-02-08

    Merging patch and updating the binary would be much appreciated (at least by me)!

     
  • M. Buecher

    M. Buecher - 2013-01-24

    Will have a look at it after the 1.9.0 release.

    Sorry for the delay
    Your Regshot Team

     
  • M. Buecher

    M. Buecher - 2013-01-24
    • status: open --> unread
    • assigned_to: M. Buecher
    • milestone: --> v1.9.x
     
  • M. Buecher

    M. Buecher - 2013-03-06

    Alex, Regshot has been reworked a lot.
    Did you adopt your patch to the current version?

     

Log in to post a comment.

Get latest updates about Open Source Projects, Conferences and News.

Sign up for the SourceForge newsletter:





No, thanks