Menu ▾ ▴

#56 Possible diffs from Debian official package about to be upgraded to 3.9.5.

v1.0 (example)
accepted
Mark Hessling
None
5
2024-03-31
2024-03-31
Agustin Martin Domingo
No

Hi, Mark,

I am helping with upgrading official Debian package to regina-rexx 3.9.5. There are some diffs I am attaching for your consideration in case they are useful in some way.

  • 0000_configures_fix-alpha-compilation.diff: This is an ancient patch for alpha arch which, when original patch was created, did not support -m64 option. Do not know if this still applies or has been addressed upstream in a different way. http://bugs.debian.org/661883 is the reference to the original bug report.

  • 2000_Makefile.in_Do-not-hardcode-FLAGS.diff: This just makes some compilation variables not be hardcoded, while still have a reasonable default it nothing else sets them. I would expect different make implementations to support ?= assignation.

Those patches will go with the release. There is another thing, honouring CPPFLAGS is currently handled by appending CPPFLAGS to CFLAGS and passing the result to make. I wonder if it would be convenient to explicitly add CPPFLAGS in Makefile.in like in attached patch 2001_Makefile.in_support-CPPFLAGS.diff or it may have other drawbacks.

Other more Debian specific changes (or incomplete) may be found at

https://salsa.debian.org/debian/regina-rexx/-/tree/master/debian/patches

Thanks for keeping regina-rexx alive, even if I do not program rexx for way too many years.

Regards,

--
Agustin

4 Attachments
0000_configures_fix-alpha-compilation.diff
2000_Makefile.in_Do-not-hardcode-FLAGS.diff
2001_Makefile.in_support-CPPFLAGS.diff
inclibarch.patch

Discussion

  • Mark Hessling

    Mark Hessling - 2024-03-31
    • status: open --> accepted
    • assigned_to: Mark Hessling
    • Attachments has changed:

    Diff:

    --- old
+++ new
@@ -1,3 +1,4 @@
 0000_configures_fix-alpha-compilation.diff (1.1 kB; text/x-patch)
 2000_Makefile.in_Do-not-hardcode-FLAGS.diff (795 Bytes; text/x-patch)
 2001_Makefile.in_support-CPPFLAGS.diff (810 Bytes; text/x-patch)
+inclibarch.patch (557 Bytes; text/x-patch)
     

  • Mark Hessling

    Mark Hessling - 2024-03-31

    Hi Agustin,

    Thank you (and Alen) for continuing to support Regina in the Debian distribution. I have added the patches you proposed. to my source. I will be releasing Regina 3.9.6 in the next couple of months hopefully.
    FYI I already had the "alpha" patch. I have attached a patch file for common/inclibarch.m4 (and indirectly configure) which has extra 64bit platforms which had caused me issues on OpenSUSE Build Service.
    These patches however do raise a maintenance issue. Would it be better to use an autoconf test for sizeof(long) to determine if the platform is 32 or 64 bit?

    Regards, Mark