Wrong icon for Windows 10 entry since 1.13

[patlefort]

Since version 1.13, my detected Windows 10 EFI boot entry is getting os_uefi.png icon instead of os_win8.png.

[Roderick W. Smith]

The os_uefi.png icon is new for version 0.13.0. (There is no version 1.13 of rEFInd.) The way rEFInd links OS loaders to icons involves trying to match various parts of filenames, directory names, partition names, filesystem names, etc., to the icon filename. Chances are that one of those components contains the string "UEFI" -- maybe your ESP has that as part of its partition name, for instance. This could then override the setting of the Windows icon. I suggest you look for such elements and rename whatever you find to avoid this problem. You can read more about this subject here:

https://www.rodsbooks.com/refind/configfile.html#icons

[patlefort]

Yes my esp does in fact contain UEFI. Thanks, I would have never guessed. But then wouldn't it be better if it didn't scan that portion? Or is there situations where the label of the ESP is important?

[Roderick W. Smith]

Using the partition label as a clue to the icon isn't likely to be important for Windows, but it can be for other OSes. For instance, I tend to name partitions after the Linux distributions they hold, and distinguishing one Linux distribution from another can be difficult or impossible without that information.

That said, the relevant clues are collected at several points in rEFInd's code, and it would probably be good to consolidate that into a single function that can prioritize things differently than the way it's done now. The current design just sort of grew organically, so it's not really optimal.