Re: [Refdb-devel] Some thoughts about packaging and compilation...

[<ste...@jo...>]

Markus Hoenicka a =E9crit :
> Hi St=E9phane,
>=20
> St=E9phane T=E9letch=E9a writes:
>  > 	b) i add the 'status' option in the cases (not sure this is complet=
ely=20
>  > portable), and correct the *) case since it misses some existing opt=
ions:
>  >=20
>  > Original:
>  >       *)
>  > -       echo "Usage: $(basename $0) {start|stop}" >&2
>  > -       exit 1;;
>  > Corrected:
>  >=20
>  > +       echo "Usage: $(basename $0)=20
>  > {start|stop|status|restart|force-reload}" >&2
>  > +       RETVAL 1
>  > +       ;;
>  >=20
>  > In your provided script, the options restart and force-reload are=20
>  > mentionned so i presume this is a good thing to indicate it in the U=
sage=20
>  > line. (do not bother about the RETVAL 1, this is exactly the same as=
=20
>  > exit 1).
>  >=20
>=20
> I've added restart and force-reload to the usage message. What is
> "status" supposed to do?

Most of the time, it indicates :

service refdb status
refdb is running...

But it may report:
refdb is stopped
of refdb is stop but the subsystem is dead.

Actually, this is done by grepping /var/run/refdb.pib and/or=20
/var/lock/subsys/refdb

But as i told, it is probably Mandriva or at least SYS-V's specific=20
(thus not very portable). It was just for your information, just in case.

>  > 3 - some permissions seem incorrect:
>  > -rwxr-xr-x  1 steletch mig  1403 avr 14 00:07 AUTHORS*
>  > -rwxr-xr-x  1 steletch mig 29746 avr 14 00:07 COPYING*
>  > -rwxr-xr-x  1 steletch mig  2964 jun 25 23:38 INSTALL*
>  > -rwxr-xr-x  1 steletch mig 10280 avr 14 00:07 missing*
>  > -rwxr-xr-x  1 steletch mig 30690 jun 25 15:39 NEWS*
>  > -rwxr-xr-x  1 steletch mig  8876 mai 26 15:47 README*
>  > -rw-r--r--  1 steletch mig 12660 mai 27 23:18 UPGRADING
>  >=20
>  > All of these should be 644 instead of 755 (no executable bit ...) si=
nce=20
>  > they are only texty files ;-).
>  >=20
>=20
> I'm sorry that you had to bug me so long to make me fix it. This does
> not mean that I only fix bugs that make their way into the bug tracker
> :-) I was simply too busy updating my laptop during the past days.
>=20
>  > Those are details but since i cannot help much in coding, i try to g=
et=20
>  > some feedback on little things ;-)
>  >=20
>=20
> Your input is much appreciated. For a programmer other stuff may
> always appear more important, but these pesky details often affect the
> user experience more than a serious bug that occurs only once in a
> while. Don't hesitate to mention these annoyances, as unimportant as
> they may seem.
>=20
> regards,
> Markus

I did use the bug tracking system since it is the way i do for other=20
stuff (and i think this is the easiest way to do it).

I wasn't aware of it before getting the mail about it, next time i'll=20
find something, i'll use it, this is a robust way to work off-line (i.e=20
not expecting an answer while other persons have other things to do).

Last, while i'll be confident (when i'll have made backports of refdb to=20
Mandriva 2006.0 and did more thorough tests), i'll send you the=20
description for the rpm installation.

Cheers,

St=E9phane

--=20
St=E9phane T=E9letch=E9a, PhD.                  http://www.steletch.org
Unit=E9 Math=E9matique Informatique et G=E9nome http://migale.jouy.inra.f=
r/mig
INRA, Domaine de Vilvert                  T=E9l : (33) 134 652 891
78352 Jouy-en-Josas cedex, France         Fax : (33) 134 652 901