[Refdb-devel] Some thoughts about packaging and compilation...

[<ste...@jo...>]

Hi everyone,

I've done the newest 0.9.8-pre1 package (still for cooker) and=20
encountered the same problems as i had before.

1 - there is no specific option to define the doc directory.

By default it builds on=20
/usr/(local/)share/doc/refdb-<version><-prerelease>/ although in the rpm=20
build process (basically uncompress, run autotools and configure, make,=20
make install), the doc directory is /usr/(local/)share/doc/refdb-<version=
>/
(please note there is no <-prerelease> although in this case there is one=
).

I've not get where the difference comes from but i suspect the=20
install.sh you provide in scripts/ to produce this difference in behaviou=
rs.

2 - i've slightly modify the scripts/refdb.in to get two points into=20
account:
	a) Mandriva uses pinit and thus needs specific headers (nothing to do=20
with refDB though)
	b) i add the 'status' option in the cases (not sure this is completely=20
portable), and correct the *) case since it misses some existing options:

Original:
      *)
-       echo "Usage: $(basename $0) {start|stop}" >&2
-       exit 1;;
Corrected:

+       echo "Usage: $(basename $0)=20
{start|stop|status|restart|force-reload}" >&2
+       RETVAL 1
+       ;;

In your provided script, the options restart and force-reload are=20
mentionned so i presume this is a good thing to indicate it in the Usage=20
line. (do not bother about the RETVAL 1, this is exactly the same as=20
exit 1).

3 - some permissions seem incorrect:
-rwxr-xr-x  1 steletch mig  1403 avr 14 00:07 AUTHORS*
-rwxr-xr-x  1 steletch mig 29746 avr 14 00:07 COPYING*
-rwxr-xr-x  1 steletch mig  2964 jun 25 23:38 INSTALL*
-rwxr-xr-x  1 steletch mig 10280 avr 14 00:07 missing*
-rwxr-xr-x  1 steletch mig 30690 jun 25 15:39 NEWS*
-rwxr-xr-x  1 steletch mig  8876 mai 26 15:47 README*
-rw-r--r--  1 steletch mig 12660 mai 27 23:18 UPGRADING

All of these should be 644 instead of 755 (no executable bit ...) since=20
they are only texty files ;-).

Those are details but since i cannot help much in coding, i try to get=20
some feedback on little things ;-)

Hoping this will help ;-)

Cheers,

St=E9phane

--=20
St=E9phane T=E9letch=E9a, PhD.                  http://www.steletch.org
Unit=E9 Math=E9matique Informatique et G=E9nome http://migale.jouy.inra.f=
r/mig
INRA, Domaine de Vilvert                  T=E9l : (33) 134 652 891
78352 Jouy-en-Josas cedex, France         Fax : (33) 134 652 901