From: Lennart P. <le...@us...> - 2005-02-19 08:16:16
|
Update of /cvsroot/redpos/RedPOS/src/org/redpos/client/contract/db In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv18469/src/org/redpos/client/contract/db Modified Files: RedPOSTable.java Log Message: Stop using UPPER in WHERE clause. Added printStackTrace() when SQLException Index: RedPOSTable.java =================================================================== RCS file: /cvsroot/redpos/RedPOS/src/org/redpos/client/contract/db/RedPOSTable.java,v retrieving revision 1.1 retrieving revision 1.2 diff -C2 -d -r1.1 -r1.2 *** RedPOSTable.java 23 Nov 2004 16:03:31 -0000 1.1 --- RedPOSTable.java 19 Feb 2005 08:16:06 -0000 1.2 *************** *** 31,34 **** --- 31,36 ---- import org.jboss.logging.Logger; + import org.redpos.client.contract.pricelist.PriceListData; + import org.redpos.client.pricelist.PriceListStorage; /** *************** *** 153,157 **** sql.append(" FROM "); sql.append(tableName); ! // add where clause sql.append(" WHERE "); --- 155,159 ---- sql.append(" FROM "); sql.append(tableName); ! // add where clause sql.append(" WHERE "); *************** *** 161,167 **** { // TODO this can be DB specific. Parameterize this then? ! sql.append("UPPER ("); sql.append(where[i]); ! sql.append(")"); } else --- 163,170 ---- { // TODO this can be DB specific. Parameterize this then? ! // UPPER is a real perfomance killer. Using VARCHAR_IGNORECASE in hsqldb instead + adding indexes ! //sql.append("UPPER ("); sql.append(where[i]); ! //sql.append(")"); } else *************** *** 192,196 **** log.debug(sql.toString()); ! // prepare statement PreparedStatement ps = connection.prepareStatement(sql.toString()); --- 195,199 ---- log.debug(sql.toString()); ! // prepare statement PreparedStatement ps = connection.prepareStatement(sql.toString()); *************** *** 254,257 **** --- 257,265 ---- } + catch(SQLException e) + { + e.printStackTrace(); + throw e; + } finally { |