Menu ▾ ▴

#528 Docs+Lint: clear all 675 lint warnings in Fingerprint/hashing.js

open
nobody
7 days ago
7 days ago
Anonymous
No

Originally created by: Redo-San

Fingerprint/hashing.js carries 675 lint warnings across 381 distinct lines — more than any other file in the repo (baseline 2026-10-06, npm run lint = 5,627 warnings / 0 errors).

Count Rule
230 security/detect-object-injection
192 jsdoc/require-param-description
192 jsdoc/require-param-type
54 jsdoc/require-returns
6 no-unused-vars
1 security/detect-unsafe-regex

Suggested order

  1. JSDoc (438 warnings, 64% of the file) — add {type} and a one-line description per @param, plus @returns. Infer types from the typeof/instanceof sites at the call site; do not invent them. This is the single biggest JSDoc block in the repo.
  2. security/detect-object-injection (230) — triage each: keys from internal maps/constants get a targeted // eslint-disable-next-line with a one-line justification; keys that can reach user input get validated against an allowlist or a Map. No blanket disables.
  3. no-unused-vars (6) — these are cross-script globals (see the separate no-unused-vars issue); leave the declarations alone unless they prove unreferenced.
  4. security/detect-unsafe-regex (1) — rewrite with linear constructs or bound input length, and add an adversarial-input test.

Acceptance criteria

  • [ ] npx eslint --config .tools/Developer_Toolkit/eslint.config.mjs Fingerprint/hashing.js → 0 messages.
  • [ ] node --test cli/tests/hashing_core_test.js cli/tests/hashing_perceptual_test.js cli/tests/new_hashes_test.js cli/tests/fingerprint_test.js passes.
  • [ ] npm run lint total warnings ≤ 4,952 (5,627 − 675), no other rule regressed.
  • [ ] npm run check passes.

Discussion


Log in to post a comment.