[Redbutton-devel] SF.net SVN: redbutton: [404] redbutton-author/trunk

[<ski...@us...>]

Revision: 404
          http://redbutton.svn.sourceforge.net/redbutton/?rev=404&view=rev
Author:   skilvington
Date:     2007-09-20 06:05:06 -0700 (Thu, 20 Sep 2007)

Log Message:
-----------
clean up comments about synthetic types

Modified Paths:
--------------
    redbutton-author/trunk/asn1tag.c
    redbutton-author/trunk/asn1tag.h

Modified: redbutton-author/trunk/asn1tag.c
===================================================================
--- redbutton-author/trunk/asn1tag.c	2007-09-20 12:49:08 UTC (rev 403)
+++ redbutton-author/trunk/asn1tag.c	2007-09-20 13:05:06 UTC (rev 404)
@@ -18,8 +18,7 @@
 bool
 is_synthetic(unsigned int asn1tag)
 {
-/* TODO: only need one value for synthetic types (ie no need for separate ASN1TAG_CHOICE etc) */
-	return (asn1tag >= ASN1TAG_SYNTHETIC);
+	return (asn1tag == ASN1TAG_SYNTHETIC || asn1tag == ASN1TAG_CHOICE);
 }
 
 /*

Modified: redbutton-author/trunk/asn1tag.h
===================================================================
--- redbutton-author/trunk/asn1tag.h	2007-09-20 12:49:08 UTC (rev 403)
+++ redbutton-author/trunk/asn1tag.h	2007-09-20 13:05:06 UTC (rev 404)
@@ -572,7 +572,7 @@
 #define ASN1TAGCLASS_SEQUENCE		((ASN1CLASS_UNIVERSAL << 24) | ASN1TAG_SEQUENCE)
 #define ASN1TAGCLASS_SET		((ASN1CLASS_UNIVERSAL << 24) | ASN1TAG_SET)
 
-/* UNIVERSAL ASN1 types in the grammar */
+/* the ASN1 types in the grammar that are not CONTEXT class types */
 #define ASN1TAGCLASS_JointIsoItuIdentifier	ASN1TAGCLASS_INTEGER
 #define ASN1TAGCLASS_MHEGStandardIdentifier	ASN1TAGCLASS_INTEGER
 #define ASN1TAGCLASS_DirectFont	ASN1TAGCLASS_OctetString


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.