Thread: [ros-kernel] CVS Commit: reactos (Page 4)

SourceForge Headquarters 225 Broadway Suite 1600 San Diego, CA 92101 +1 (858) 422-6466

lib\msvcrt\vfwprint.c:
lib\msvcrt\vfprintf.c:
  Reseting the conversion qualifier for each new value from the format string.

- Hartmut



> lib\msvcrt\vfwprint.c:
> lib\msvcrt\vfprintf.c:
>   Reseting the conversion qualifier for each new value from 
> the format string.

Thanks Hartmut. I will test it in just a sec.
Steven

"Every revolution was once a thought in one man's mind"
- Ralph Waldo Emerson 




include/ddk/zwtypes.h
ntoskrnl/ex/sysinfo.c
ntoskrnl/include/internal/ldr.h
ntoskrnl/ldr/loader.c
subsys/smss/init.c
subsys/win32k/ldr/loader.c
subsys/win32k/main/dllmain.c
subsys/win32k/misc/driver.c
    Fixed automatic loading of required modules.
    Cleaned up module loading interface.


Eric





system.hiv
    Added VGA driver.

subsys/csrss/init.c
drivers/dd/vidport/vidport.c
    Pass pointer to CSRSS process on first create request, which is issued
by CSRSS.

subsys/win32k/eng/device.c
    Fixed a direct reference to the miniport driver object.

These changes make gditest run again. :-)


Eric





Nice one!

--- Eric Kohl <ek...@rz...> wrote:
> system.hiv
>     Added VGA driver.
> 
> subsys/csrss/init.c
> drivers/dd/vidport/vidport.c
>     Pass pointer to CSRSS process on first create request, which is
> issued
> by CSRSS.
> 
> subsys/win32k/eng/device.c
>     Fixed a direct reference to the miniport driver object.
> 
> These changes make gditest run again. :-)
> 
> 
> Eric
> 
> 
> 
> _______________________________________________________________
> 
> Don't miss the 2002 Sprint PCS Application Developer's Conference
> August 25-28 in Las Vegas -
> http://devcon.sprintpcs.com/adp/index.cfm?source=osdntextlink
> 
> _______________________________________________
> reactos-kernel mailing list
> rea...@li...
> https://lists.sourceforge.net/lists/listinfo/reactos-kernel


__________________________________________________
Do You Yahoo!?
Yahoo! - Official partner of 2002 FIFA World Cup
http://fifaworldcup.yahoo.com



lib\ntdll\rtl\acl.c
ntoskrnl\se\acl.c

* Fix bug in RtlpAddKnownAce() that caused
  it to place the SID in the wrong location.

* Teach RtlpAddKnownAce() some status values
  other than STATUS_UNSUCCESSFUL.

lib\ntdll\rtl\sid.c
ntoskrnl\se\sid.c

* Fix bug in RtlEqualSid() that caused
  all sids with the same sub-authority
  count to compare equal.

lib/crtdll/stdio/vfprintf.c
lib/msvcrt/stdio/vfprintf.c

* Enable %wZ and %Z format specifiers (remove
  #if 0)

* Fix check for NULL Buffer (it was checking
  for non-null Buffer)

* Fix length field when printing unicode strings;
  it was printing twice as many characters as
  it should have.

  (All these bugs were already fixed in the
  kernel mode version of these functions.)

apps/tests/tokentest/tokentest.c

* Cleanup, add display of token values being
  passed into ZwCreateToken() as well as display
  of values coming out of the token.

All patches by Joseph Galbraith.


Eric




drivers/dd/vga/display/vgaddi.def
drivers/dd/vga/display/vgaddi.edf
drivers/dd/vga/display/main/enable.c
drivers/dd/vga/display/objects/bitblt.c
drivers/dd/vga/display/objects/lineto.c
drivers/dd/vga/display/objects/paint.c
drivers/dd/vga/display/objects/pointer.c
drivers/dd/vga/display/objects/transblt.c
drivers/dd/vga/miniport/vgamp.c
include/ddk/ntddvid.h
include/ddk/winddi.h
include/win32k/driver.h

Changed the calling convention used by the video miniport/port driver
interface and the display driver/win32k interface (DrvXxx functions) to
STDCALL.
The EngXxx and other funtions will be changed in a second step.

This change is needed to run third-party video drivers.


Eric





include/ddk/winddi.h
subsys/win32k/win32k.def
subsys/win32k/win32k.edf
subsys/win32k/include/eng.h
subsys/win32k/include/paint.h (new)
subsys/win32k/eng/bitblt.c
subsys/win32k/eng/brush.c
subsys/win32k/eng/clip.c
subsys/win32k/eng/copybits.c
subsys/win32k/eng/debug.c
subsys/win32k/eng/lineto.c
subsys/win32k/eng/mem.c
subsys/win32k/eng/objects.h
subsys/win32k/eng/paint.c
subsys/win32k/eng/palette.c
subsys/win32k/eng/surface.c
subsys/win32k/eng/transblt.c
subsys/win32k/eng/xlate.c
subsys/win32k/stubs/stubs.c

Changed calling convention of EngXxx funtions to STDCALL.
Added missing includes.

Eric




ntoskrnl/include/internal/ldr.h
ntoskrnl/io/driver.c
ntoskrnl/ldr/loader.c

Fixed loading of symbol files.


system.hiv
ntoskrnl/include/internal/ntoskrnl.h
ntoskrnl/cm/registry.c
ntoskrnl/ke/main.c

Implemented automatic loading of PICE.


Eric





lib/ntdll/rtl/registry.c
    RtlQueryRegistryValues(): Implemented direct query of REG_EXPAND_SZ
values.

subsys/system/services/database.c
    Improved driver loading sequence with respect to the group order.
    Added ability to run user-mode services.

PS.: Where, in the CVS tree, are we going to put user-mode services like
rpcss and eventlog? I think we should put them into the old 'services'
directory. Comments?


Eric





man, 2002-06-17 kl. 17:51 skrev Eric Kohl:
> PS.: Where, in the CVS tree, are we going to put user-mode services like
> rpcss and eventlog? I think we should put them into the old 'services'
> directory. Comments?
> 
> 
> Eric

I think so too. That seems like a good place to put them.

Casper





apps/tests/tokentest.c

* Fix stupidity that prevented tokentest
  from compiling

Joseph






ntoskrnl/cm/rtlfunc.c:
    RtlQueryRegistryValues() must treat REG_MULTI_SZ and REG_EXPAND_SZ
    values like REG_SZ values upon direct queries.


ntoskrnl/io/driver.c
    IoDestroyDriverList(): Free memory of group and service entries.
    IopCreateServiceListEntry(): simplified function and reduced memory
consumption.


Eric





apps/tests/regtest/regtest.c
    Added registry link tests.

system.hiv
include/ddk/cmtypes.h
include/ntos/registry.h
ntoskrnl/cm/cm.h
ntoskrnl/cm/ntfunc.c
ntoskrnl/cm/regfile.c
ntoskrnl/cm/registry.c
ntoskrnl/cm/regobj.c
    Implemented registry links (REG_LINK).
    Create the 'CurrentControlSet' link after the registry has been
initialized.


Eric





services/eventlog/eventlog.c
services/eventlog/eventlog.h
services/eventlog/eventlog.rc
services/eventlog/logport.c
services/eventlog/makefile
services/rpcss/endpoint.c
services/rpcss/makefile
services/rpcss/rpcss.c
services/rpcss/rpcss.h
services/rpcss/rpcss.rc
makefile

    Added eventlog service stub.
    Added RPC server stub.

Both services are not usable yet.
If you want to improve one of them, feel free to do so. :-)

Eric




With latest FreeLoader I cannot successfully boot latest ReactOS.

"\SystemRoot" is not created, but all boot drivers are loaded and initialized.


(ke/main.c:621) Module: 'ntoskrnl.exe' at c0000000, length 0x0009e000
(ke/main.c:621) Module: 'HAL.DLL' at c009e000, length 0x0000fb09
(ke/main.c:621) Module: 'SYSTEM.HIV' at c00ae000, length 0x00001c3c
(ke/main.c:621) Module: 'Scsiport.sys' at c00b0000, length 0x000098f5
(ke/main.c:621) Module: 'Atapi.sys' at c00ba000, length 0x00007abc
(ke/main.c:621) Module: 'Class2.sys' at c00c2000, length 0x0000a877
(ke/main.c:621) Module: 'Disk.sys' at c00cd000, length 0x00007f2e
(ke/main.c:621) Module: 'Vfatfs.sys' at c00d5000, length 0x000164ba
(ke/main.c:669) Process registry chunk at c00ae000
(ke/main.c:697) Initializing driver 'Scsiport.sys' at c00b0000, length 0x000098f5
(ldr/loader.c:1429) DriverBase: dc9c0000
(ke/main.c:697) Initializing driver 'Atapi.sys' at c00ba000, length 0x00007abc
(ldr/loader.c:1429) DriverBase: dc9c8000
(ke/main.c:697) Initializing driver 'Class2.sys' at c00c2000, length 0x0000a877
(ldr/loader.c:1429) DriverBase: dc9cf000
(ke/main.c:697) Initializing driver 'Disk.sys' at c00cd000, length 0x00007f2e
(ldr/loader.c:1429) DriverBase: dc9d8000
(ke/main.c:697) Initializing driver 'Vfatfs.sys' at c00d5000, length 0x000164ba
(ldr/loader.c:1429) DriverBase: dc9df000
(ke/main.c:714) CommandLine: multi(0)disk(0)rdisk(0)partition(1)\reactos /DEBUGPORT=COM1 /BAUDRATE=115200
(io/arcname.c:304) NtOpenSymbolicLinkObject() failed to open '\SystemRoot' (Status c0000001)
(ldr/loader.c:1332) LdrpGetModuleObject: Failed to find module \SystemRoot\system32\drivers\cdrom.sys
(ldr/loader.c:1429) DriverBase: dc9fe000
(ldr/loader.c:1332) LdrpGetModuleObject: Failed to find module \SystemRoot\system32\drivers\fs_rec.sys
(ldr/loader.c:1429) DriverBase: dca04000
(io/create.c:90) Parent is a Directory which is not a device type
(io/create.c:90) Parent is a Directory which is not a device type
(ldr/loader.c:1332) LdrpGetModuleObject: Failed to find module \SystemRoot\system32\drivers\beep.sys
(ldr/loader.c:833) Could not open module file: \SystemRoot\system32\drivers\beep.sys
(io/driver.c:204) LdrLoadModule() failed (Status c0000034)
(ldr/loader.c:1332) LdrpGetModuleObject: Failed to find module \SystemRoot\system32\drivers\null.sys
(ldr/loader.c:1429) DriverBase: dca0a000
(ldr/loader.c:1332) LdrpGetModuleObject: Failed to find module \SystemRoot\system32\drivers\keyboard.sys
(ldr/loader.c:1429) DriverBase: dca11000
(ldr/loader.c:1332) LdrpGetModuleObject: Failed to find module \SystemRoot\system32\drivers\blue.sys
(ldr/loader.c:1429) DriverBase: dca1a000
(ldr/loader.c:1332) LdrpGetModuleObject: Failed to find module \SystemRoot\system32\drivers\vgamp.sys
(ldr/loader.c:1429) DriverBase: dca21000
(ldr/loader.c:1332) LdrpGetModuleObject: Failed to find module vidport.sys
(ldr/loader.c:1332) LdrpGetModuleObject: Failed to find module \SystemRoot\system32\drivers\vidport.sys
(ldr/loader.c:1429) DriverBase: dca2b000
(ldr/loader.c:1332) LdrpGetModuleObject: Failed to find module \SystemRoot\system32\drivers\msfs.sys
(ldr/loader.c:1429) DriverBase: dca33000
Mailslot FSD 0.0.1
(ldr/loader.c:1332) LdrpGetModuleObject: Failed to find module \SystemRoot\system32\drivers\npfs.sys
(ldr/loader.c:1429) DriverBase: dca3a000
Named Pipe FSD 0.0.2
(ldr/loader.c:1332) LdrpGetModuleObject: Failed to find module \SystemRoot\system32\drivers\ndis.sys
(ldr/loader.c:1429) DriverBase: dca43000
Page Fault Exception: 14(4)
CS:EIP 1b:77f765b7 <ntdll.dll: 165b7>
CR2 280cc CR3 3e92000 Process: c01f0902 Pid: 2 <> Thrd: c0205b7a Tid: 13
DS 23 ES 23 FS 3b GS 23
EAX: 000280cc   EBX: 7ffdf000   ECX: 00607930
EDX: 000000a6   EBP: 00606da8   ESI: 00000000
EDI: 00000000   EFLAGS: 00000216 SS:ESP 23:606da8
Frames:   <ntdll.dll: 166c9><ntdll.dll: 12ec7><ntdll.dll: 13869><smss.exe: 1054><smss.exe: 1689><ntdll.dll: f1f7><smss.exe: 187a><smss.exe: 2193><smss.exe: 1132><ntdll.dll: 2c0a>





"Casper Hornstrup" <ch...@us...> wrote:


> With latest FreeLoader I cannot successfully boot latest ReactOS.
>
> "\SystemRoot" is not created, but all boot drivers are loaded and
initialized.
>
[...]
> (ke/main.c:714) CommandLine: multi(0)disk(0)rdisk(0)partition(1)\reactos
/DEBUGPORT=COM1 /BAUDRATE=115200
> (io/arcname.c:304) NtOpenSymbolicLinkObject() failed to open '\SystemRoot'
(Status c0000001)

I rebuilt the current ReactOS and FreeLoader but I cannot reproduce this
bug.
Do you have the latest DJGPP?
If not, get it! I couldn't get the latest FreeLoader running with an older
DJGPP.

Eric





ons, 2002-06-26 kl. 23:18 skrev Eric Kohl:
> 
> "Casper Hornstrup" <ch...@us...> wrote:
> 
> 
> > With latest FreeLoader I cannot successfully boot latest ReactOS.
> >
> > "\SystemRoot" is not created, but all boot drivers are loaded and
> initialized.
> >
> [...]
> > (ke/main.c:714) CommandLine: multi(0)disk(0)rdisk(0)partition(1)\reactos
> /DEBUGPORT=COM1 /BAUDRATE=115200
> > (io/arcname.c:304) NtOpenSymbolicLinkObject() failed to open '\SystemRoot'
> (Status c0000001)
> 
> I rebuilt the current ReactOS and FreeLoader but I cannot reproduce this
> bug.
> Do you have the latest DJGPP?
> If not, get it! I couldn't get the latest FreeLoader running with an older
> DJGPP.
> 
> Eric

I was confused about the messages about the modules not beeing found. Maybe we should
change this message to something like "<module> not found. Trying to load...".

Actually the failure to open the symbolic link was non-critical. I think the OBJ_OPENLINK flag is missing so it should be:

--- arcname.orig	Thu Jun 27 02:19:14 2002
+++ arcname.c	Thu Jun 27 01:36:29 2002
@@ -291,7 +291,7 @@
   /* Check whether '\SystemRoot'(LinkName) can be opened */
   InitializeObjectAttributes(&ObjectAttributes,
 			     &LinkName,
-			     0,
+			     OBJ_OPENLINK,
 			     NULL,
 			     NULL);

 
But, with the following patch, NtOpenSymbolicLinkObject() makes more
sense to me. Comments?

--- symlink.orig	Thu Jun 27 02:20:04 2002
+++ symlink.c	Thu Jun 27 01:22:24 2002
@@ -192,6 +192,8 @@
   DPRINT("NtOpenSymbolicLinkObject (Name %wZ)\n",
 	 ObjectAttributes->ObjectName);
 
+  ObjectAttributes->Attributes |= OBJ_OPENLINK;
+
   return(ObOpenObjectByName(ObjectAttributes,
 			    IoSymbolicLinkType,
 			    NULL,

The real problem was with the new MinGW runtime (1.5). There are several issues related
issues related to this. If we make a release now, we should make a note
in the release notes that MinGW runtime 1.5 currently cannot be used to
compile ReactOS.

Casper





"Casper Hornstrup" <ch...@us...> wrote:


> I was confused about the messages about the modules not beeing found.
Maybe we should
> change this message to something like "<module> not found. Trying to
load...".

What about "<module> not loaded yet. Loading...".

> Actually the failure to open the symbolic link was non-critical. I think
the OBJ_OPENLINK flag is missing so it should be:
>
> --- symlink.orig Thu Jun 27 02:20:04 2002
> +++ symlink.c Thu Jun 27 01:22:24 2002
> @@ -192,6 +192,8 @@
>    DPRINT("NtOpenSymbolicLinkObject (Name %wZ)\n",
>   ObjectAttributes->ObjectName);
>
> +  ObjectAttributes->Attributes |= OBJ_OPENLINK;
> +
>    return(ObOpenObjectByName(ObjectAttributes,
>       IoSymbolicLinkType,
>       NULL,
>
> --- arcname.orig Thu Jun 27 02:19:14 2002
> +++ arcname.c Thu Jun 27 01:36:29 2002
> @@ -291,7 +291,7 @@
>    /* Check whether '\SystemRoot'(LinkName) can be opened */
>    InitializeObjectAttributes(&ObjectAttributes,
>        &LinkName,
> -      0,
> +      OBJ_OPENLINK,
>        NULL,
>        NULL);
>
>
> But, with the following patch, NtOpenSymbolicLinkObject() makes more
> sense to me. Comments?

No! If the OBJ_OPENLINK attribute is set, a link object will be opened
instead of the target it points to. So you have to use OBJ_OPENLINK if you
want to retrieve link's target path, change a link's target path or delete a
link object but not the object it points to. But if you want to open the
target of a link OBJ_OPENLINK must not be set.

In the current case NtOpenSymbolicLink() is used to check whether
\SystemRoot points to an existing target by trying to open the target.
Opening the link object instead will cause the call to succeed even if the
link's target does not exist or cannot be opened for some other reason.


> The real problem was with the new MinGW runtime (1.5). There are several
issues related
> issues related to this. If we make a release now, we should make a note
> in the release notes that MinGW runtime 1.5 currently cannot be used to
> compile ReactOS.

Ooops!


Eric




tor, 2002-06-27 kl. 12:56 skrev Eric Kohl:
> 
> "Casper Hornstrup" <ch...@us...> wrote:
> 
> 
> > I was confused about the messages about the modules not beeing found.
> Maybe we should
> > change this message to something like "<module> not found. Trying to
> load...".
> 
> What about "<module> not loaded yet. Loading...".

Yes this is better.

> 
> > Actually the failure to open the symbolic link was non-critical. I think
> the OBJ_OPENLINK flag is missing so it should be:
> >
> > --- symlink.orig Thu Jun 27 02:20:04 2002
> > +++ symlink.c Thu Jun 27 01:22:24 2002
> > @@ -192,6 +192,8 @@
> >    DPRINT("NtOpenSymbolicLinkObject (Name %wZ)\n",
> >   ObjectAttributes->ObjectName);
> >
> > +  ObjectAttributes->Attributes |= OBJ_OPENLINK;
> > +
> >    return(ObOpenObjectByName(ObjectAttributes,
> >       IoSymbolicLinkType,
> >       NULL,
> >
> > --- arcname.orig Thu Jun 27 02:19:14 2002
> > +++ arcname.c Thu Jun 27 01:36:29 2002
> > @@ -291,7 +291,7 @@
> >    /* Check whether '\SystemRoot'(LinkName) can be opened */
> >    InitializeObjectAttributes(&ObjectAttributes,
> >        &LinkName,
> > -      0,
> > +      OBJ_OPENLINK,
> >        NULL,
> >        NULL);
> >
> >
> > But, with the following patch, NtOpenSymbolicLinkObject() makes more
> > sense to me. Comments?
> 
> No! If the OBJ_OPENLINK attribute is set, a link object will be opened
> instead of the target it points to. So you have to use OBJ_OPENLINK if you
> want to retrieve link's target path, change a link's target path or delete a
> link object but not the object it points to. But if you want to open the
> target of a link OBJ_OPENLINK must not be set.

And opening the target is intended here? But should
NtOpenSymbolicLinkObject() be used here then? It's name suggest that it
does just that - opens the link object itself and not the target. What
does the NT implementation do?

Then there is another problem. When trying to open the target object
here, NtOpenSymbolicLinkObject() fails because the file system is not
mounted yet and the file system is not mounted by this request. IIRC it
is only mounted on the first create request. Should the call to
NtOpenSymbolicLinkObject() cause the filesystem to be mounted?

> 
> In the current case NtOpenSymbolicLink() is used to check whether
> \SystemRoot points to an existing target by trying to open the target.
> Opening the link object instead will cause the call to succeed even if the
> link's target does not exist or cannot be opened for some other reason.
> 
> 
> > The real problem was with the new MinGW runtime (1.5). There are several
> issues related
> > issues related to this. If we make a release now, we should make a note
> > in the release notes that MinGW runtime 1.5 currently cannot be used to
> > compile ReactOS.
> 
> Ooops!

I should have said MinGW runtime 2.0 here. Newest w32api is 1.5.

> 
> 
> Eric





"Casper Hornstrup" <ch...@us...> wrote:

> > No! If the OBJ_OPENLINK attribute is set, a link object will be opened
> > instead of the target it points to. So you have to use OBJ_OPENLINK if
you
> > want to retrieve link's target path, change a link's target path or
delete a
> > link object but not the object it points to. But if you want to open the
> > target of a link OBJ_OPENLINK must not be set.
>
> And opening the target is intended here?
Yes, I want to check whether 'C:\reactos' exists and can be opened.

But should
> NtOpenSymbolicLinkObject() be used here then? It's name suggest that it
> does just that - opens the link object itself and not the target. What
> does the NT implementation do?

You're right! Using NtOpenFile() instead of NtOpenSymbolicLinkObject() is
much more appropriate. I checked NtOpenSymbolicLink() and it doesn't set the
OBJ_OPENLINK attribute. But instead IoDeleteSymbolicLink() needs to be
changed. It needs to open the specified link using the OBJ_OPENLINK
attribute.

> Then there is another problem. When trying to open the target object
> here, NtOpenSymbolicLinkObject() fails because the file system is not
> mounted yet and the file system is not mounted by this request. IIRC it
> is only mounted on the first create request. Should the call to
> NtOpenSymbolicLinkObject() cause the filesystem to be mounted?

The filesystem should be mounted. In case the filesystem cannot be mounted,
the system should issue an INACCESSIBLE_BOOT_DEVICE error and stop (BSOD).


> I should have said MinGW runtime 2.0 here. Newest w32api is 1.5.

Well, runtime 2.0 is still in beta state, isn't it. Does runtime 1.5 work?

Eric





tor, 2002-06-27 kl. 17:20 skrev Eric Kohl:
> 
> "Casper Hornstrup" <ch...@us...> wrote:
> 
> > I should have said MinGW runtime 2.0 here. Newest w32api is 1.5.
> 
> Well, runtime 2.0 is still in beta state, isn't it. Does runtime 1.5 work?

The previous release mingw-runtime 1.3 works fine.

> 
> Eric





drivers/fs/mup/.cvsignore
drivers/fs/mup/create.c
drivers/fs/mup/makefile
drivers/fs/mup/mup.c
drivers/fs/mup/mup.h
drivers/fs/mup/mup.rc
drivers/fs/ntfs/.cvsignore
drivers/fs/ntfs/blockdev.c
drivers/fs/ntfs/create.c
drivers/fs/ntfs/dirctl.c
drivers/fs/ntfs/fcb.c
drivers/fs/ntfs/fsctl.c
drivers/fs/ntfs/makefile
drivers/fs/ntfs/ntfs.c
drivers/fs/ntfs/ntfs.h
drivers/fs/ntfs/ntfs.rc
drivers/fs/ntfs/volinfo.c
install.bat
makefile

Added 'Multi UNC Provider' driver stub.
Added NTFS driver stub.

Eric




rosapps/taskmgr

Updated for building with GCC.
Added graphcntrl for performance page.
Various fixes and additions.

Robert.




include\ddk\iotypes.h:
  Added PCM_PARTIAL_RESOURCE_LIST.

subsys\win32k\misc\object.c:
  Fixed some calculatations in ObmpGetObjectHandle.

drivers\storage\scsiport\scsiport.edf:
  Fixed a typo.

drivers\fs\vfat\blockdev.c:
drivers\fs\vfat\create.c:
drivers\fs\vfat\fat.c:
drivers\fs\vfat\fcb.c:
drivers\fs\vfat\fsctl.c:
drivers\fs\vfat\makefile:
drivers\fs\vfat\rw.c:
drivers\fs\vfat\vfat.h:
  Changed the sector size from BLOCKSIZE to the size from the boot sector.

- Hartmut




Thread: [ros-kernel] CVS Commit: reactos (Page 4)

An operating system based on the best Windows NT design principles

reactos-kernel