Re: [ros-kernel] CVS Commit: reactos

[Eric K. <ek...@rz...>]

"David Welch" <we...@cw...> wrote:


> On Wed, Jul 10, 2002 at 05:24:08PM +0200, Eric Kohl wrote:
> > ntoskrnl/ps/create.c
> > ntoskrnl/ps/suspend.c
> >     Implemented the ability to create suspended threads.
> >
> I don't understand this patch. Why create the wait blocks explicitly?

I did this to make the newly created thread wait for the suspend semaphore.
Using NtWaitForSingleObject() won't work because it always initializes a
wait block in the current thread. Of course I could wrap the explicit wait
block initialiation into a separate function, like
KeThreadWaitForSingleObject().


> Also has the suspend/resume functionality been tested?

I am currently working on SCM <->service communication. AFAICS, tread resume
works as expected since the service's main thread connects to the service
control pipe. The suspend functionality is still untested but a test should
be simple.

Eric