Re: [ros-kernel] bugfix

[Eric K. <ek...@rz...>]

"KJK::Hyperion" <no...@li...> wrote:


> At 00.25 06/07/2002, you wrote:
> > > Sorry, but I think the bug is in the ReactOS shell. It should
> > > ExpandEnvironmentStrings() the command line
> >The ReactOS shell (shell.exe) doesn't support environment variables at
all.
> >The problem was that the expansion of environment variables works on
> >Windows when cmd is used. Although cmd doesn't call
> >ExpandEnvironmentStrings(). SetEnvironmentVariable() expands environment
> >variables but ReactOS didn't implement that.
>
> has this been verified? because here (Windows 2000 Professional) I'm able
> to set a variable to "%PATH%" without it being expanded:
>
> ALDEBARAN\Hyperion [D:\home\Hyperion]
> ::set DOH=^%PATH^%
>
> ALDEBARAN\Hyperion [D:\home\Hyperion]
> ::echo %DOH%
> %PATH%
>

Hyperion, you're absolutely right! Cmd expands envionment variables
internally as part of the commandline analysis. Neither the ntdll functions
nor the kernel32 functions expand environment variables automatically.

I'll revert the patch!

Eric