Re: [ros-kernel] ReactOS not booting correctly

[Casper H. <ch...@us...>]

ons, 2002-06-26 kl. 23:18 skrev Eric Kohl:
> 
> "Casper Hornstrup" <ch...@us...> wrote:
> 
> 
> > With latest FreeLoader I cannot successfully boot latest ReactOS.
> >
> > "\SystemRoot" is not created, but all boot drivers are loaded and
> initialized.
> >
> [...]
> > (ke/main.c:714) CommandLine: multi(0)disk(0)rdisk(0)partition(1)\reactos
> /DEBUGPORT=COM1 /BAUDRATE=115200
> > (io/arcname.c:304) NtOpenSymbolicLinkObject() failed to open '\SystemRoot'
> (Status c0000001)
> 
> I rebuilt the current ReactOS and FreeLoader but I cannot reproduce this
> bug.
> Do you have the latest DJGPP?
> If not, get it! I couldn't get the latest FreeLoader running with an older
> DJGPP.
> 
> Eric

I was confused about the messages about the modules not beeing found. Maybe we should
change this message to something like "<module> not found. Trying to load...".

Actually the failure to open the symbolic link was non-critical. I think the OBJ_OPENLINK flag is missing so it should be:

--- arcname.orig	Thu Jun 27 02:19:14 2002
+++ arcname.c	Thu Jun 27 01:36:29 2002
@@ -291,7 +291,7 @@
   /* Check whether '\SystemRoot'(LinkName) can be opened */
   InitializeObjectAttributes(&ObjectAttributes,
 			     &LinkName,
-			     0,
+			     OBJ_OPENLINK,
 			     NULL,
 			     NULL);

 
But, with the following patch, NtOpenSymbolicLinkObject() makes more
sense to me. Comments?

--- symlink.orig	Thu Jun 27 02:20:04 2002
+++ symlink.c	Thu Jun 27 01:22:24 2002
@@ -192,6 +192,8 @@
   DPRINT("NtOpenSymbolicLinkObject (Name %wZ)\n",
 	 ObjectAttributes->ObjectName);
 
+  ObjectAttributes->Attributes |= OBJ_OPENLINK;
+
   return(ObOpenObjectByName(ObjectAttributes,
 			    IoSymbolicLinkType,
 			    NULL,

The real problem was with the new MinGW runtime (1.5). There are several issues related
issues related to this. If we make a release now, we should make a note
in the release notes that MinGW runtime 1.5 currently cannot be used to
compile ReactOS.

Casper