#20 expose YYCTXMARKER

closed
None
5
2006-02-24
2006-02-24
No

In my initial patch I missed the case that YYFILL
implementation might shift in the buffer an accumulated
token and a partially accumulated trailing context. To
allow YYFILL handle such "shifts" properly we need to
expose the YYCTXMARKER in the same way we always
exposed the YYMARKER.

I attached patches for re2c and htdocs, and new ctx.re.

To test that everything still works I rerun ctx.re
(obviously) and c.re tests. The latter to ensure that
existing specs that do not use trailing context won't
be affected even though they do not define YYCTXMARKER.

Discussion

  • Marcus Börger

    Marcus Börger - 2006-02-24

    Logged In: YES
    user_id=271023

    The change looks good. But it was not made against haed.
    Also you should fix the man page by fixing re2c.1 since
    htdocs/manual.html is generated from the manpage.

     
  • Marcus Börger

    Marcus Börger - 2006-02-24
    • assigned_to: nobody --> helly
     
  • Alexander Demenchuk

    Logged In: YES
    user_id=492233

    I made changes to re2c.1 and updated the patch. Updated test
    case is now in a separate file.

    I used HEAD as supplied by anonymous CVS. Maybe what I see
    though it has not yet been rsync-ed with the dev CVS...

     
  • Alexander Demenchuk

    updated test case

     
  • Marcus Börger

    Marcus Börger - 2006-02-24

    Logged In: YES
    user_id=271023

    You should check all test cases by running 'make test'.
    Also you obviously use windows. Thus i suggest you change
    to tools that do not clobber line endings. For example you
    can change to using cygwin for running the tests and set
    it to automatic file type conversion.

    Good work nonetheless.

     
  • Marcus Börger

    Marcus Börger - 2006-02-24
    • status: open --> closed
     

Log in to post a comment.

Get latest updates about Open Source Projects, Conferences and News.

Sign up for the SourceForge newsletter:





No, thanks