Re: [re2c-general] supporting Gnu-format error messages

[Stephen L. <ste...@st...>]

Stephen Leake <ste...@st...> writes:

>> As for the code, your guess is correct: error reporting is scattered all
>> around the codebase and the patch would probably end up quite big. This
>> is not a problem, as long as all the changes are related to the message
>> format. If you feel that it could be broken into a series of smaller
>> patches, you are welcome.
>
> Even without a new option, we still have to pass 'opts' to the error
> message functions, since that holds the current file name.

I've run into a problem.

In most places where options are already passed, they are passed as
'const opt_t *opts'. However, that type does not contain 'source_file';
'source_file' is only in the higher level Opt type.

So either I need to add an Opt arg to all the places that already get
opt_t (that seems awkward), or move source_file into conopt_t.

Any advice?

I'm tempted to give up; I won't be editing that many .re files, so the
error message format is not too annoying.

-- 
-- Stephe