From: Ulya T. <skv...@gm...> - 2017-09-12 22:00:32
|
>> - what about the errors/warnings that have no column info? > > Then the column is left out. This is from the Gnu coding standards: > https://www.gnu.org/prep/standards/standards.html#Errors Ah, thanks. Probably worth referencing somewhere in the comments. > Even without a new option, we still have to pass 'opts' to the error > message functions, since that holds the current file name. I think it is better to pass the filename only rather than the entire 'opts' (unless the message depends on other options). > One approach would be to simply change the error message format, then > see whether it would be better to introduce an option or change the test > expected results. The changes should be trivial (easily verifiable with a simple shell script, except maybe for a couple of tests that include binary blobs). > I've cloned from the SourceForge repository. The primary repository is on github: https://github.com/skvadrik/re2c.git Sourceforge is a mirror and may be slightly outdated (as of now it is one commit behind github). Ulya |