Re: [Rdkit-devel] new C++ drawing code

[Igor F. <igo...@gm...>]

Greg, David,

> One small point, which I'm sure is down to my poorly annotated/documented
code, is that drawTriangle should draw a solid, filled shape.

Good catch about filled triangles  - I should have seen it myself.
The fix is easy  - just need to change DrawLines to DrawPolygon (attached).

Is there anything special about dashes? I saw something strange going on in
drawLine in cairo version, not sure what it does.

Greg, please go ahead - the fixed version is attached.

Igor


On Thu, Jan 22, 2015 at 5:01 AM, Greg Landrum <gre...@gm...>
wrote:

> Thanks Igor!
> Ok with you if I check this in?
>
> On Wed, Jan 21, 2015 at 10:16 PM, Igor Filippov <igo...@gm...
> > wrote:
>
>> This is very nice!
>> Here is a shim to draw to wxWidgets, header-file only.
>> If anyone needs an example how to use it please let me know.
>>
>> Igor
>>
>> On Tue, Jan 20, 2015 at 2:41 AM, Greg Landrum <gre...@gm...>
>> wrote:
>>
>>> I merged the pull request this morning. The new C++ drawing code is now
>>> available on master.
>>>
>>> Best,
>>> -greg
>>>
>>>
>>> On Thu, Jan 15, 2015 at 5:20 AM, Greg Landrum <gre...@gm...>
>>> wrote:
>>>
>>>> Dear all,
>>>>
>>>> I just created a pull request for integration of some new C++ drawing
>>>> code into the RDKit:
>>>> https://github.com/rdkit/rdkit/pull/412
>>>>
>>>> This is a big one, so I will leave the PR active until the weekend for
>>>> people to look at and comment on before I merge onto the master.
>>>>
>>>> The new code supports rendering to SVG, Cairo (optional), and Qt
>>>> (optional). Adding support for a new backend is pretty straightforward.
>>>>
>>>> There's still work to be done to allow this to be a replacement for the
>>>> Python-based rendering code in rdkit.Chem.Draw, but it's a big step forward.
>>>>
>>>> The original design and code is from Dave Cosgrove. Many thanks to Dave
>>>> for the contribution, which is really going to help improve the quality of
>>>> the molecule drawings the RDKit produces.
>>>>
>>>> Best,
>>>> -greg
>>>>
>>>>
>>>
>>>
>>> ------------------------------------------------------------------------------
>>> New Year. New Location. New Benefits. New Data Center in Ashburn, VA.
>>> GigeNET is offering a free month of service with a new server in Ashburn.
>>> Choose from 2 high performing configs, both with 100TB of bandwidth.
>>> Higher redundancy.Lower latency.Increased capacity.Completely compliant.
>>> http://p.sf.net/sfu/gigenet
>>> _______________________________________________
>>> Rdkit-devel mailing list
>>> Rdk...@li...
>>> https://lists.sourceforge.net/lists/listinfo/rdkit-devel
>>>
>>>
>>
>