Re: [Rdkit-devel] Chem/Draw code: new feature and some refactoring

[Greg L. <gre...@gm...>]

On Wed, Feb 2, 2011 at 12:40 AM, gi...@gm... <gi...@gm...> wrote:
> On Tue, Feb 1, 2011 at 12:51 PM, Uwe Hoffmann <uw...@fa...> wrote:
>> just some idea: what about removing sping and agg altogether ?
>
> Well, agg is not really there, you still need to get it, compile the
> library and let rdklit find it in order to use that backend. On the
> other hand, sping is embedded in the rdkit repository and I agree it
> would be better removed from the rdkit tarball.

I would rather not remove sping (or the possibility to use aggdraw),
for reasons I explained in the previous message.

> If the patches will get merged, I'd like to make more changes along these lines:
>
> 1. remove the sping code
> 2. make the backend selectable from the API
> 3. make cairo the default backend
> 4. further refactor backends (there is still much duplicated code)
> 5. last, but not least, apply more PEP8

Aside from the first bullet point, I agree with all of these.

I am (finally) back in Basel now; I'll take a look at your changes
over the next day or so and make comments.

Best Regards,
-greg