Re: [Rdkit-devel] [Packaging] a suggestion to minimize problems

[Greg L. <gre...@gm...>]

On Thu, Sep 9, 2010 at 3:59 PM, Gianluca Sforna <gi...@gm...> wrote:
> On Wed, Sep 8, 2010 at 6:33 AM, Greg Landrum <gre...@gm...> wrote:
>> Dear all,
>>
>> In order to minimize the problems caused by the packaging-related
>> changes, I suggest that we modify the top level CMakeLists.txt file so
>> that RDK_INSTALL_INTREE defaults to ON. This way people will get the
>> old behavior by default, but can easily switch to the new if they
>> wish.
>
> It's ok for me.
>
> I'm just wondering if we could make it ON by default unless a
> CMAKE_INSTALL_PREFIX is passed; that way I would not even need to add
> -DRDK_INSTALL_INTREE:BOOL=OFF to my build.

I'm fine with the idea, but I'm not at all sure how to do this in cmake.

A couple of updates:
- I merged the changes from the trunk onto the packaging branch. The
builds and tests seem to work with both values of RDK_INSTALL_INTREE
- I've added updated build instructions to the wiki, please let me
know what you think: http://code.google.com/p/rdkit/wiki/NewLinuxBuild

I think it's time to merge the branch back to the trunk; sound ok to you guys?

-greg