[Rdkit-devel] [PATCH] add STATIC keyword to force static linking

[Gianluca S. <gi...@gm...>]

Hi all,
my packaging effort exposed some things that could be improved in the
build system, I will post some patches to address the issues I managed
to overcome.

The first one follows, basically, three libraries linked another
statically generated library, but failed to declare it properly
resulting in breakage when building with a global
"-DBUILD_SHARED_LIBS=TRUE".


commit a414770e549590f196c0bca05fead81d5cb7716b
Author: Gianluca Sforna <gi...@gm...>
Date:   Sat Jul 10 18:12:38 2010 +0200

    Add STATIC keyword

diff --git a/Code/ML/Cluster/Murtagh/CMakeLists.txt
b/Code/ML/Cluster/Murtagh/CMakeLists.txt
index 878953f..1ac93c1 100644
--- a/Code/ML/Cluster/Murtagh/CMakeLists.txt
+++ b/Code/ML/Cluster/Murtagh/CMakeLists.txt
@@ -1,4 +1,4 @@
-add_library(hc hc.c hcdriver.c)
+add_library(hc STATIC hc.c hcdriver.c)

 rdkit_python_extension(Clustering Clustering.cpp
                        DEST ML/Cluster
diff --git a/Code/ML/InfoTheory/CMakeLists.txt
b/Code/ML/InfoTheory/CMakeLists.txt
index 9e6e05f..9fe55ff 100644
--- a/Code/ML/InfoTheory/CMakeLists.txt
+++ b/Code/ML/InfoTheory/CMakeLists.txt
@@ -1,4 +1,4 @@
-add_library(InfoTheory InfoBitRanker.cpp)
+add_library(InfoTheory STATIC InfoBitRanker.cpp)

 rdkit_python_extension(cEntropy cEntropy.cpp
                        DEST ML/InfoTheory
diff --git a/External/cmim-1.0/CMakeLists.txt b/External/cmim-1.0/CMakeLists.txt
index 808cabc..44559bb 100644
--- a/External/cmim-1.0/CMakeLists.txt
+++ b/External/cmim-1.0/CMakeLists.txt
@@ -1,4 +1,4 @@
-add_library(fastentropy fastentropy.cc misc.cc)
+add_library(fastentropy STATIC fastentropy.cc misc.cc)



-- 
Gianluca Sforna

http://morefedora.blogspot.com
http://www.linkedin.com/in/gianlucasforna